Thread: [Phplib-users] rfe to template.inc
Brought to you by:
nhruby,
richardarcher
Menu
▾
▴
phplib-users
|
From: Mike G. <mi...@op...> - 2003-12-30 14:49:46
|
Hello, Presently Back-End.org is using template.inc as is and adding in template header/footer comments with each template just as phpSlash and (and most other phplib template driven apps likely do). In talking to the Back-end.org team though, it seems like the following modification to template.inc would make it easier for us to ensure that the file names are accurate and easily accessible. cvs diff phplib/php/template.inc Index: phplib/php/template.inc =================================================================== RCS file: /cvsroot/back-end/back-end0.7.x/class/phplib/php/template.inc,v retrieving revision 1.1.1.1 diff -r1.1.1.1 template.inc 909c909,911 < --- > > $str = "<!-- START $filename -->' . $str . '<!-- END $filename -->'; > If we implement this we'll have a lot of header/footer comments to delete and I'd just like to try to keep this in step with phpSlash if we can. I'd also like to contribute the following javascript which can just be inserted into a block to easily identify which templates are where. <script type="text/javascript"> <!-- // Code Contributed by Lasse Nielsen - http://www.infimum.dk function convert(node) { if (!node) {node = document.body;} switch (node.nodeType) { case Node.COMMENT_NODE: var text = node.nodeValue; if (text.substr(0,7)==" START ") { var newNode = createNewNode(text.substr(7)); node.parentNode.replaceChild(newNode,node); } break case Node.ELEMENT_NODE: for (var i=0;i<node.childNodes.length;i++) { convert(node.childNodes[i]); } break; default: break; } } function createNewNode(text) { var a = document.createElement("a"); a.href = "/admin/BE_editTemplateAdmin.php?submit=edit&file="+escape(text); var img = document.createElement("img"); img.src = "/images/BE/buttons/spacer.gif"; a.appendChild(img); return a; } --> </script> <input type="button" value="Convert!" onclick="convert()"> Mike -- Mike Gifford, OpenConcept Consulting Free Software for Social Change -> http://www.openconcept.ca Stop Cdn Pension Plan War Investments -> http://coat.openconcept.ca/ Another world is not only possible, she is on her way -Arundhati Roy |
|
From: Mike G. <mi...@op...> - 2004-01-05 15:36:05
|
Hello Layne, On Wed, 31 Dec 2003, Layne wrote: > On Dec 31, 2003, at 10:25 AM, Mike Gifford wrote: > > On Tue, 2003-12-30 at 12:16, Joe Stewart wrote: > >> On Tue, Dec 30, 2003 at 09:49:43AM -0500, Mike Gifford wrote: > >>> In talking to the Back-end.org team though, it seems like the > >>> following > >>> modification to template.inc would make it easier for us to ensure > >>> that > >>> the file names are accurate and easily accessible. > >> I like it if optional or debug type setting. Or if your template > >> editor > >> module can turn display on. I don't like the comments on all > >> production sites. > I've committed this option into the php-lib-stable tree. Thanks! I've pulled that into the CVS for Back-End so that it is in the next release. Now I just need to go through and get rid of all of the comments that have been added to the templates manually. > > Glad to know that there is general agreement on: > > $str = "<!-- START $filename -->' . $str . '<!-- END $filename > -->'; > I changed "START" and "END" to "START FILE" and "END FILE" so that the > end comment would be easily distinguishable from any undeclared block > comments. Fine with me. > > I also think that turning the comments on/off would be very useful. > I > > guess it's a matter of being something that is configured within > > template.inc or passed to template.inc from slashTemplate.class (and > > probably set in the config.ini.php file).. > The functionality is controlled via a class variable - > $filename_comments. This defaults to false to preserve consistent > functionality with previous versions as well as to provide minimal > configuration for production sites. Yup. Makes sense. Thanks for including this so quickly... Mike -- Mike Gifford, OpenConcept Consulting Free Software for Social Change -> http://www.openconcept.ca Stop Cdn Pension Plan War Investments -> http://coat.openconcept.ca/ Another world is not only possible, she is on her way -Arundhati Roy |
|
From: Mike G. <mi...@op...> - 2003-12-31 16:25:36
|
Howdy Joe, On Tue, 2003-12-30 at 12:16, Joe Stewart wrote: > On Tue, Dec 30, 2003 at 09:49:43AM -0500, Mike Gifford wrote: > > In talking to the Back-end.org team though, it seems like the following > > modification to template.inc would make it easier for us to ensure that > > the file names are accurate and easily accessible. > I like it if optional or debug type setting. Or if your template editor > module can turn display on. I don't like the comments on all production sites. Glad to know that there is general agreement on: $str = "<!-- START $filename -->' . $str . '<!-- END $filename -->'; I also think that turning the comments on/off would be very useful. I guess it's a matter of being something that is configured within template.inc or passed to template.inc from slashTemplate.class (and probably set in the config.ini.php file).. I'm not sure how you'd make it configurable without something like: function loadfile($varname, $showComments=true) { or perhaps another global variable. I do think the comments should be there by default, but would be awfully nice if they could be turned off in a live site. Mike -- Mike Gifford, OpenConcept Consulting Free Software for Social Change -> http://www.openconcept.ca Stop Cdn Pension Plan War Investments -> http://coat.openconcept.ca/ Another world is not only possible, she is on her way -Arundhati Roy |
|
From: Layne W. <la...@dr...> - 2003-12-31 17:26:03
|
On Dec 31, 2003, at 10:25 AM, Mike Gifford wrote: > On Tue, 2003-12-30 at 12:16, Joe Stewart wrote: >> On Tue, Dec 30, 2003 at 09:49:43AM -0500, Mike Gifford wrote: >>> In talking to the Back-end.org team though, it seems like the >>> following >>> modification to template.inc would make it easier for us to ensure >>> that >>> the file names are accurate and easily accessible. >> I like it if optional or debug type setting. Or if your template >> editor >> module can turn display on. I don't like the comments on all >> production sites. I've committed this option into the php-lib-stable tree. > Glad to know that there is general agreement on: > $str = "<!-- START $filename -->' . $str . '<!-- END $filename -->'; I changed "START" and "END" to "START FILE" and "END FILE" so that the end comment would be easily distinguishable from any undeclared block comments. > I also think that turning the comments on/off would be very useful. I > guess it's a matter of being something that is configured within > template.inc or passed to template.inc from slashTemplate.class (and > probably set in the config.ini.php file).. The functionality is controlled via a class variable - $filename_comments. This defaults to false to preserve consistent functionality with previous versions as well as to provide minimal configuration for production sites. > I'm not sure how you'd make it configurable without something like: > function loadfile($varname, $showComments=true) { > > or perhaps another global variable. > > I do think the comments should be there by default, but would be > awfully > nice if they could be turned off in a live site. Layne Weathers |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X