phplib-trackers — List for monitoring the phplib SourceForge trackers.

[Phplib-trackers] [ phplib-Bugs-500340 ] bug in function query() in db_mysql.inc

[<no...@so...>]

Bugs item #500340, was opened at 2002-01-07 02:50
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=500340&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: bug in function query() in db_mysql.inc 

Initial Comment:
function query() in db_mysql.inc dont take care of the 
Record field.
a line shoul be added :

$this->Record = @mysql_fetch_array($this->Query_ID);

cheers,
miko_il



----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2002-01-18 13:57

Message:
Logged In: NO 

THIS IS WRONG!!!
Please ignore it and remove it ASAP.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=500340&group_id=31885

[Phplib-trackers] [ phplib-Bugs-504005 ] Session.put_headers wrong for PHP3

[<no...@so...>]

Bugs item #504005, was opened at 2002-01-15 10:58
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=504005&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Fred Yankowski (fredy)
Assigned to: Nobody/Anonymous (nobody)
Summary: Session.put_headers wrong for PHP3

Initial Comment:
The put_headers() method in session.inc calls header() 
with 'false' as the second argument in some cases, to 
append to a header rather than replacing it.  This 
feature does not exist in PHP3, causing the header 
values to be incomplete because only the last value 
obtains.

The attached patch fixes this problem and should work 
in both PHP3 and PHP4.


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=504005&group_id=31885

[Phplib-trackers] [ phplib-Bugs-466835 ] small bug in Table::table_row()

[<no...@so...>]

Bugs item #466835, was opened at 2001-10-01 07:16
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=466835&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Jesse Swensen (swensenj)
Summary: small bug in Table::table_row()  

Initial Comment:
Lines 475 and 476 of table.inc (version 7.2d) read:

    $d = $this->select_colnames($data);    
    $this->table_row_open($row, $d, $class);    

According to the docs (and the description of table_row_open), the second argument "is for derived 
classes that override this function that want access to the row data for the row about to be opened." In 
reality, table_row_open() receives an array with fieldnames, not a hash with fieldname/value pairs.

Solution:
  o delete line 475
  o replace $d in line 476 with $data

Regards, Peter Fokkinga

----------------------------------------------------------------------

Comment By: Fred Yankowski (fredy)
Date: 2002-01-15 10:47

Message:
Logged In: YES 
user_id=20580

Patch #504000 should fix this problem.


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=466835&group_id=31885

[Phplib-trackers] [ phplib-Patches-504000 ] fix calls to table_row_open()

[<no...@so...>]

Patches item #504000, was opened at 2002-01-15 10:46
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=504000&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Fred Yankowski (fredy)
Assigned to: Nobody/Anonymous (nobody)
Summary: fix calls to table_row_open()

Initial Comment:
According to its comment, the second argument to 
table_row_open() in table.inc should be the array of 
data for the cells.  This patch updates code in 
table.inc so that that data is actually passed, rather 
than passing an array of column names (as current).

I have found this change to be very useful in practice 
as it allows me to override table_row_open in a 
subclass, where that specialized function stores away 
some information from $data so that data from one cell 
can be used when processing another cell.

This patch should fix bug #466835.


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=504000&group_id=31885

[Phplib-trackers] [ phplib-Bugs-445389 ] table.inc unused vairable

[<no...@so...>]

Bugs item #445389, was opened at 2001-07-27 18:32
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=445389&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Chris Johnson (chaska)
Assigned to: Jesse Swensen (swensenj)
Summary: table.inc unused vairable

Initial Comment:
table.inc -- function table_heading_cell() sets $found 
but never uses it.

----------------------------------------------------------------------

Comment By: Fred Yankowski (fredy)
Date: 2002-01-15 10:32

Message:
Logged In: YES 
user_id=20580

Patch #503992 fixes this problem.


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=445389&group_id=31885

[Phplib-trackers] [ phplib-Patches-503992 ] fix show_table_cells() in table.inc

[<no...@so...>]

Patches item #503992, was opened at 2002-01-15 10:30
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=503992&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Fred Yankowski (fredy)
Assigned to: Nobody/Anonymous (nobody)
Summary: fix show_table_cells() in table.inc

Initial Comment:
The show_table_cells() method in table.inc sets 'cell' 
without using it, and uses 'col' not having set it.  
The latter causes a warning.

This patch changes 'col' to 'cell'.

This patch should fix bug #445388.


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=503992&group_id=31885

[Phplib-trackers] [ phplib-Bugs-488605 ] Menu.inc under PHP for Windows

[<no...@so...>]

Bugs item #488605, was opened at 2001-12-03 13:58
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=488605&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Menu.inc under PHP for Windows

Initial Comment:
In (menu.inc,v 1.3 2001/08/20):

the setup() function in Menu.inc uses the php dirname
() call, expecting Unix style slashes in dir names. 
This breaks the top level menu on a Windows system 
where forward slashes are used. I replaced:

298:  $base = dirname($v);

with:
298 :  $base = dirname($v);
299+:  $base = str_replace("\","/",$base);

This fix cleared up the 'problem'.

jesse

----------------------------------------------------------------------

Comment By: Marco Müller (dk2sf)
Date: 2002-01-14 17:08

Message:
Logged In: YES 
user_id=328473

fixed it on my windose platform too.

Thanks
Marco

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=488605&group_id=31885

[Phplib-trackers] [ phplib-Bugs-501788 ] & char in URIs is invalid XHML

[<no...@so...>]

Bugs item #501788, was opened at 2002-01-10 06:11
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=501788&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Gaetano Giunta (ggiunta)
Assigned to: Nobody/Anonymous (nobody)
Summary: & char in URIs is invalid XHML

Initial Comment:
Intro:

when writing XHTML docs the href attribute cannot ever 
contain the & char. So all URIs containing a query part with more than 
1 params need to be rewritten using the & escape sequence (I 
tried it and it works!)

Problem:

the url(), self_url() 
etc... functions in phplib all use/search for only the & char as a 
query separator

Suggestion:

make new xurl(), 
xself_url(), ... functions, or modify existing 
ones...

Thanks, Gaetano

----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-01-14 12:25

Message:
Logged In: YES 
user_id=279311

Are you sure the "&" character is not allowed? That would
seem to me to be illogical. 

Example: in order to pass a parameter "tv=black&white" you
need to escape the '&'.

The XHTML spec at: 
http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd
defines a URI as:

<!ENTITY % URI "CDATA">
<!-- a Uniform Resource Identifier, see [RFC2396] -->


RFC 2396 http://www.faqs.org/rfcs/rfc2396.html defines '&'
as a reserved character. These may appear unescaped in URIs
and indeed *must* not be escaped or the meaning of the URI
may change.

Perhaps the implementation of XHTML you're using is buggy?

Otherwise, I'd appreciate a link to an XHTML spec that
defines URI's differently!


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=501788&group_id=31885

[Phplib-trackers] [ phplib-Patches-501754 ] removed call-by-ref from user.inc

[<no...@so...>]

Patches item #501754, was opened at 2002-01-10 04:41
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=501754&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Gaetano Giunta (ggiunta)
Assigned to: Nobody/Anonymous (nobody)
Summary: removed call-by-ref from user.inc

Initial Comment:
modified calls to session->serialize() that will give warning 
messages with allow-call-by-refernce set to Off in php.ini

----------------------------------------------------------------------

>Comment By: Gaetano Giunta (ggiunta)
Date: 2002-01-14 03:35

Message:
Logged In: YES 
user_id=114789

DOH! forgot to mention: patch is against version 7.4rc1

in this 
release definition of sess->serialize in session.inc is ok! I think user-
>freeze was added to override session->freeze (since user is a descendent 
of session this is correct); the main difference is that if user==nobody 
(not authenticated user), session data is not frozen. Actually code 
could be simpler: if user!= nobody then call inherited 
method...

Gaetano

----------------------------------------------------------------------

Comment By: Dieter Steinwedel (dsteinwe)
Date: 2002-01-11 08:53

Message:
Logged In: YES 
user_id=373951

You must also change the function header of "serialize" in 
session.inc. Add a "&" before the param "$str". Otherwise 
it doesn't work!

Why do you put "freeze" to the class "user"? It is a part 
of "session".

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=501754&group_id=31885

[Phplib-trackers] [ phplib-Feature Requests-502655 ] binary

[<no...@so...>]

Feature Requests item #502655, was opened at 2002-01-12 04:17
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403614&aid=502655&group_id=31885

Category: None
Group: None
Status: Open
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: binary

Initial Comment:
Hi!

did anyone thik that this template class would be nice 
to be portet in C and that it can be used as php 
module.

I tried yats and it's 15 times faster becasue it is 
always avaliable (you don't have to require anything), 
and execution is also faster.


Thanks


Uros

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403614&aid=502655&group_id=31885

[Phplib-trackers] [ phplib-Patches-501872 ] fallback error patch

[<no...@so...>]

Patches item #501872, was opened at 2002-01-10 07:41
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=501872&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Gaetano Giunta (ggiunta)
Assigned to: Nobody/Anonymous (nobody)
Summary: fallback error patch

Initial Comment:
For a detailed description, see the posts in the bugs 
section (bug #487852).

The idea is to avoid the user seeing the Session ID in 
the URL of a page when a session is sarted with 
cookies and fallback enabled.

The code: replace in session.inc the function 
release_token with the one in the attached file

NOTE: I tested this only with IE5.5 and cookiwes 
on/off, might need some more extensive testing...

----------------------------------------------------------------------

Comment By: Dieter Steinwedel (dsteinwe)
Date: 2002-01-12 02:39

Message:
Logged In: YES 
user_id=373951

Unfortunally, it forces on my system a endless-loop. But 
I've solved the problem: The cause is, that the get-var 
won't be erased on the second reload. My solution updates 
the url-rewriting function "url()" of the class "session":

  function url($url){
    $url=ereg_replace("[&?]+$", "", $url);
 
    switch ($this->mode) {
      case "get":
 
        $url .= ( strpos($url, "?") != false ?  "&" : "?" ).
                urlencode($this->name)."=".$this->id;
 
      break;
      default:
	$ssp = strpos($url,urlencode($this->name)."="); ## 
DS1 added -> BEGIN
	if ($ssp > 0)
	{
		$sspe = strpos($url,"&",$ssp);
		if ($sspe > 0) $url = substr($url, 0, 
$ssp) . substr($url, $sspe + 1);
		else $url = substr($url, 0, $ssp);
		if ($url[strlen($url)-1] == "?") $url = 
substr($url, 0, strlen($url)-1);
	} ## DS1 added -> END
      break;
    }
    return $url;
  }

I will soon add all mods to the "bigger patch".

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=501872&group_id=31885

[Phplib-trackers] [ phplib-Patches-501754 ] removed call-by-ref from user.inc

[<no...@so...>]

Patches item #501754, was opened at 2002-01-10 04:41
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=501754&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Gaetano Giunta (ggiunta)
Assigned to: Nobody/Anonymous (nobody)
Summary: removed call-by-ref from user.inc

Initial Comment:
modified calls to session->serialize() that will give warning 
messages with allow-call-by-refernce set to Off in php.ini

----------------------------------------------------------------------

Comment By: Dieter Steinwedel (dsteinwe)
Date: 2002-01-11 08:53

Message:
Logged In: YES 
user_id=373951

You must also change the function header of "serialize" in 
session.inc. Add a "&" before the param "$str". Otherwise 
it doesn't work!

Why do you put "freeze" to the class "user"? It is a part 
of "session".

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=501754&group_id=31885

[Phplib-trackers] [ phplib-Patches-501872 ] fallback error patch

[<no...@so...>]

Patches item #501872, was opened at 2002-01-10 07:41
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=501872&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Gaetano Giunta (ggiunta)
Assigned to: Nobody/Anonymous (nobody)
Summary: fallback error patch

Initial Comment:
For a detailed description, see the posts in the bugs 
section (bug #487852).

The idea is to avoid the user seeing the Session ID in 
the URL of a page when a session is sarted with 
cookies and fallback enabled.

The code: replace in session.inc the function 
release_token with the one in the attached file

NOTE: I tested this only with IE5.5 and cookiwes 
on/off, might need some more extensive testing...

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=501872&group_id=31885

[Phplib-trackers] [ phplib-Bugs-501870 ] fallback error

[<no...@so...>]

Bugs item #501870, was opened at 2002-01-10 07:38
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=501870&group_id=31885

Category: None
Group: None
>Status: Deleted
Resolution: Rejected
Priority: 5
Submitted By: Gaetano Giunta (ggiunta)
Assigned to: Nobody/Anonymous (nobody)
Summary: fallback error

Initial Comment:
For a detailed description, see the posts in the bugs 
section (bug #487852).

The idea is to avoid the user seeing the Session ID in 
the URL of a page when a session is sarted with 
cookies and fallback enabled.

The code: replace in session.inc the function 
release_token with the one in the attached file

NOTE: I tested this only with IE5.5 and cookiwes 
on/off, might need some more extensive testing...

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=501870&group_id=31885

[Phplib-trackers] [ phplib-Bugs-501870 ] fallback error

[<no...@so...>]

Bugs item #501870, was opened at 2002-01-10 07:38
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=501870&group_id=31885

Category: None
Group: None
Status: Open
>Resolution: Rejected
Priority: 5
Submitted By: Gaetano Giunta (ggiunta)
Assigned to: Nobody/Anonymous (nobody)
Summary: fallback error

Initial Comment:
For a detailed description, see the posts in the bugs 
section (bug #487852).

The idea is to avoid the user seeing the Session ID in 
the URL of a page when a session is sarted with 
cookies and fallback enabled.

The code: replace in session.inc the function 
release_token with the one in the attached file

NOTE: I tested this only with IE5.5 and cookiwes 
on/off, might need some more extensive testing...

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=501870&group_id=31885

[Phplib-trackers] [ phplib-Bugs-501870 ] fallback error

[<no...@so...>]

Bugs item #501870, was opened at 2002-01-10 07:38
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=501870&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Gaetano Giunta (ggiunta)
Assigned to: Nobody/Anonymous (nobody)
Summary: fallback error

Initial Comment:
For a detailed description, see the posts in the bugs 
section (bug #487852).

The idea is to avoid the user seeing the Session ID in 
the URL of a page when a session is sarted with 
cookies and fallback enabled.

The code: replace in session.inc the function 
release_token with the one in the attached file

NOTE: I tested this only with IE5.5 and cookiwes 
on/off, might need some more extensive testing...

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=501870&group_id=31885

[Phplib-trackers] [ phplib-Bugs-487852 ] fallback error

[<no...@so...>]

Bugs item #487852, was opened at 2001-12-01 08:36
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=487852&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Dieter Steinwedel (dsteinwe)
Assigned to: Nobody/Anonymous (nobody)
Summary: fallback error

Initial Comment:
I've recognized that the fallback mechanism from 
cookie to get doesn't work correctly. The created 
session always works, but sometimes the mechanism 
fallsback to "get" on session creation on browser with 
cookie support. 

The source of this behaviour may be "release_token()" 
and/or "get_id()" in "session.inc".

Dieter

----------------------------------------------------------------------

Comment By: Gaetano Giunta (ggiunta)
Date: 2002-01-10 07:01

Message:
Logged In: YES 
user_id=114789

DOH! I think the final suggestion in my previous post
is BULL$#!^: on the 
second load of the page you will NOT get back a session id from the browser, 
so you can't match it in the database!

Anyway, the brilliant idea to 
solve the problem is here:
1st hit: set cookie, reload adding GET 
params
2nd hit: if no cookie found continue using GETs, else
         reload, 
eliminating GET params
3rd hit: you're OK now, sure to get the 
cookie

the tradeoff is a slightly slower load-time of 1st-page-of-
session, your take...

the patch to session.inc I just posted here 
(see the patches section)


----------------------------------------------------------------------

Comment By: Gaetano Giunta (ggiunta)
Date: 2002-01-10 03:47

Message:
Logged In: YES 
user_id=114789

My 2 eurocents of analysis: it depends on session.inc, function 
release_token, line 406 (in release 7.4rc1): mode is set to 
fallback.

This looks unnecessary (and if your'sure all your users 
have cookies enabled just comment the line and all will be smooth), but it 
stems from a logic problem: if a page is hit by the browser and there's no 
cookie found containing the session id, there's no (easy) way that PHPLIB 
can possibly know if it is the first time that the page was hit and the 
session cookie has yet to be set, or if it is the second time that the page is 
hit and the cookie is not working, so session should switch to fallback 
mode. To make sure it gets it right, phplib adds the session id in the URL, 
although it looks a bit nasty to the end user.

An (hard and long ?) way to 
do it could be storing in the db container the session info on the first page 
hit, before redirecting the user. This way the second page hit would find 
the session id already defined in the db and know that if no cookie is there 
it should fall back to get mode and try a second redirect including the 
session id in the url...

Hope this helps a bit (and maybe even gets 
implemented in verion 8 or someting...)
Gaetano

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=487852&group_id=31885

[Phplib-trackers] [ phplib-Bugs-501788 ] & char in URIs is invalid XHML

[<no...@so...>]

Bugs item #501788, was opened at 2002-01-10 06:11
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=501788&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Gaetano Giunta (ggiunta)
Assigned to: Nobody/Anonymous (nobody)
Summary: & char in URIs is invalid XHML

Initial Comment:
Intro:

when writing XHTML docs the href attribute cannot ever 
contain the & char. So all URIs containing a query part with more than 
1 params need to be rewritten using the & escape sequence (I 
tried it and it works!)

Problem:

the url(), self_url() 
etc... functions in phplib all use/search for only the & char as a 
query separator

Suggestion:

make new xurl(), 
xself_url(), ... functions, or modify existing 
ones...

Thanks, Gaetano

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=501788&group_id=31885

[Phplib-trackers] [ phplib-Bugs-480851 ] Warnings in sessions.inc

[<no...@so...>]

Bugs item #480851, was opened at 2001-11-12 02:02
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=480851&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Warnings in sessions.inc

Initial Comment:
Hi,

I get following warnings on using "sessions.inc":

Warning: Call-time pass-by-reference has been 
deprecated - argument passed
by value; If you would like to pass it by reference, 
modify the declaration
of [runtime function name](). If you would like to 
enable call-time
pass-by-reference, you can set 
allow_call_time_pass_reference to true in
your INI file. However, future versions may not 
support this any longer. in
session.inc on line 262

Warning: Call-time pass-by-reference has been 
deprecated - argument passed
by value; If you would like to pass it by reference, 
modify the declaration
of [runtime function name](). If you would like to 
enable call-time
pass-by-reference, you can set 
allow_call_time_pass_reference to true in
your INI file. However, future versions may not 
support this any longer. in
session.inc on line 273

Warning: Call-time pass-by-reference has been 
deprecated - argument passed
by value; If you would like to pass it by reference, 
modify the declaration
of [runtime function name](). If you would like to 
enable call-time
pass-by-reference, you can set 
allow_call_time_pass_reference to true in
your INI file. However, future versions may not 
support this any longer. in
session.inc on line 304

Warning: Call-time pass-by-reference has been 
deprecated - argument passed
by value; If you would like to pass it by reference, 
modify the declaration
of [runtime function name](). If you would like to 
enable call-time
pass-by-reference, you can set 
allow_call_time_pass_reference to true in
your INI file. However, future versions may not 
support this any longer. in
session.inc on line 305

Warning: Call-time pass-by-reference has been 
deprecated - argument passed
by value; If you would like to pass it by reference, 
modify the declaration
of [runtime function name](). If you would like to 
enable call-time
pass-by-reference, you can set 
allow_call_time_pass_reference to true in
your INI file. However, future versions may not 
support this any longer. in
session.inc on line 311

Warning: Cannot add header information - headers 
already sent by (output
started at session.inc:262) in session.inc on line 392

Warning: Cannot add header information - headers 
already sent by (output
started at session.inc:262) in session.inc on line 117

Warning: Cannot add header information - headers 
already sent by (output
started at session.inc:262) in session.inc on line 404


By the way, I have 
switched "allow_call_time_pass_reference" to true, but 
it doesn't matter. Can someone help me?

----------------------------------------------------------------------

Comment By: Gaetano Giunta (ggiunta)
Date: 2002-01-10 04:44

Message:
Logged In: YES 
user_id=114789

NB: the previous comment stated that the error lies in file session.inc, 
while it actually is in user.inc: not the function definition (it is 
correct in 7.2d and later), but the function usage

For a fix look at the 
patch I submitted (a new version of file user.inc)

----------------------------------------------------------------------

Comment By: Gaetano Giunta (ggiunta)
Date: 2002-01-10 02:52

Message:
Logged In: YES 
user_id=114789

It depends on php.ini settings: in version 4.1 the default value for 
allow_call_time_pass_reference has been set to Off. 

If you have 
this, and error_reporting = ALL, you will get some warnings (the warnings 
come before PHPLIB sends the headers for caching, thus generating the 
rest of the warnings).

The problem lies in calls to seesion-
>serialize() in session.inc wrongly using &$string instead of 
$string.

Short-term Solution: set 
allow_call_time_pass_reference to On

Long-term Solution: fix damn 
calls to session->serialize() in session.inc (PLEEZ, SOMEONE WITH A CVS 
ACCOUNT DO THIS BEFORE 7.4 FINAL IS OUT)!!!

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2001-12-09 21:10

Message:
Logged In: NO 

I am running into the same problem.  Has anyone come up 
with a solution to this?

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=480851&group_id=31885

[Phplib-trackers] [ phplib-Patches-501754 ] removed call-by-ref from user.inc

[<no...@so...>]

Patches item #501754, was opened at 2002-01-10 04:41
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=501754&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Gaetano Giunta (ggiunta)
Assigned to: Nobody/Anonymous (nobody)
Summary: removed call-by-ref from user.inc

Initial Comment:
modified calls to session->serialize() that will give warning 
messages with allow-call-by-refernce set to Off in php.ini

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=501754&group_id=31885

[Phplib-trackers] [ phplib-Patches-487847 ] Bigger patch

[<no...@so...>]

Patches item #487847, was opened at 2001-12-01 08:22
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=487847&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Dieter Steinwedel (dsteinwe)
Assigned to: Nobody/Anonymous (nobody)
Summary: Bigger patch

Initial Comment:
Hi folks,

I've posted here a set of my patched files of the 
phplib. The files "db_oracle.inc" and "db_oci8.inc" 
are rewritten and therefore renamed as "db_*_ds.inc". 
Additionally, the "db_sql" class has got the new 
method "column_names()". This method gives you the 
column names of a query in an array. The class "Table" 
uses this function to avoid seeking in the query 
result, because some DBs don't like "seeking". I 
hope "table_ds.inc" (after renaming as "table.inc") 
will be a part of the phplib. This *requires* the 
additional implementation of the method "column_names
()" in all other "db_*.inc" files. The implementation 
should be quite simple and is - in my eyes - very 
useful. 

By the way, I've fixed some further bugs found in the 
messages: #445385, #445386, #445389, #472136, #482372, 
#445388 and #450706 (my new version 
of "db_oci8_ds.inc" makes possibly this message 
superfluous).

All modified files contains further informations about 
the changes. Changes are marked with a "DS1".

I would be glad about feedback!!! 
Please, mail and help to make the phplib perfect.


Dieter

----------------------------------------------------------------------

Comment By: Gaetano Giunta (ggiunta)
Date: 2002-01-10 04:33

Message:
Logged In: YES 
user_id=114789

my 2 eurocents:

in page.inc, better use 'if (isset($user) and 
(is_object($user)))'

Gaetano

----------------------------------------------------------------------

Comment By: Dieter Steinwedel (dsteinwe)
Date: 2001-12-29 09:20

Message:
Logged In: YES 
user_id=373951

Unfortunally, there is an error occurred on uploading. 
Please, don't download the file "PAGE.INC" (I cannot delete 
it). All you need is "patch.zip".

----------------------------------------------------------------------

Comment By: Dieter Steinwedel (dsteinwe)
Date: 2001-12-29 09:15

Message:
Logged In: YES 
user_id=373951

Missing files added ...

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=487847&group_id=31885

[Phplib-trackers] [ phplib-Patches-472136 ] Bug in session.inc with HTTP_POST_VARS

[<no...@so...>]

Patches item #472136, was opened at 2001-10-17 09:41
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=472136&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Oliver Kurz (ojk)
Assigned to: Nobody/Anonymous (nobody)
Summary: Bug in session.inc with HTTP_POST_VARS

Initial Comment:
We realized in one of our projects a little "bug" in the file session.inc (PHPLib 7.2c). If you set the  
mode to cookie and the fallbackmode to get and then sending the session__id with post through a 
html-form, than your session is lost. 

The reason is, the function release_token only looks in $HTTP_GET_VARS for the session_id, if 
fallbackmode is necessary. But not in $HTTP_POST_VARS, but this could also be possible, if no 
cookies are allowed and the session_id is transmitted by a hidden form field. 

We fixed the function as you can see at the bottom of this text. Now the function looks for 
fallbackmode also in the post-vars for the session_id, if it isn't set in cookie- or get-vars.

  // Fix
  function release_token(){ 
    // Old Version
//    global $HTTP_COOKIE_VARS, $HTTP_GET_VARS, $HTTP_HOST, $HTTPS;
    // New Version
    global $HTTP_COOKIE_VARS, $HTTP_GET_VARS, $HTTP_HOST, $HTTPS, $HTTP_POST_VARS;
    if (   isset($this->fallback_mode)
    && ( "get" == $this->fallback_mode ) 
    && ( "cookie" == $this->mode )
    && ( ! isset($HTTP_COOKIE_VARS[$this->name]) ) ) {
      // Old Version
//      if ( isset($HTTP_GET_VARS[$this->name]) ) {
      // New Version
      if ( isset($HTTP_GET_VARS[$this->name]) || isset($HTTP_POST_VARS[$this->name]) ) {
        $this->mode = $this->fallback_mode;
      } else {
        header("Status: 302 Moved Temporarily");
        $this->get_id($sid);
	$this->mode = $this->fallback_mode;
        if( isset($HTTPS) && $HTTPS == 'on' ){
        ## You will need to fix suexec as well, if you use Apache and CGI PHP
          $PROTOCOL='https';
        } else {
          $PROTOCOL='http';
        }
        header("Location: ". $PROTOCOL. "://".$HTTP_HOST.$this->self_url());
        exit;
      }
    }
  }   


----------------------------------------------------------------------

Comment By: Gaetano Giunta (ggiunta)
Date: 2002-01-10 04:28

Message:
Logged In: YES 
user_id=114789

Well, fallback='get' gives you a clear idea of supported fallback 
methods.

Instead of adding post support this way another (cleaner ?) 
idea would be to add a 'post' and 'both' options to fallback.

The main 
problem is that there is no easy way in PHP to send POST data to a web page 
(there are hacks involving use of sockets, but I dunno if they're 
bulletproof). And the id data needs to be sent not only expressly by the 
user when clicking on forms with hidden fields, but also by phplib itself 
(e.g. it adds it to urls with sess_url()).
My best guess is the POST only 
method is completely impracticable, so maybe your hack is the best option 
in the end)

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=472136&group_id=31885

[Phplib-trackers] [ phplib-Bugs-489961 ] Problem with Phplib 7.2d

[<no...@so...>]

Bugs item #489961, was opened at 2001-12-06 11:27
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=489961&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Carlos M.Viales Solorzano (carviaso)
Assigned to: Nobody/Anonymous (nobody)
Summary: Problem with Phplib 7.2d

Initial Comment:
Hi

I intented install PhpLib but all time say me this 
error:

Parse error: parse error, expecting `T_STRING' or 
`T_VARIABLE' or `T_NUM_STRING' in 
E:\Inetpub\php\phplib-7.2d\php\prepend.php3 on line 15


For what is this error.

Thanks for all

----------------------------------------------------------------------

Comment By: Gaetano Giunta (ggiunta)
Date: 2002-01-10 03:55

Message:
Logged In: YES 
user_id=114789

You probably have not defined correctly (maybe some typo?) the variable 
$_PHPLIB["libdir"] on line 13 of prepend.php3:

$_PHPLIB is an 
array

$_PHPLIB["libdir"] is (a string) the element of the array that 
contains the base path of the phplib include files
(e.g. 
E:\Inetpub\php\phplib-7.2d\php in your case)

Please answer if this 
is the case so the bug can be closed
Gaetano


----------------------------------------------------------------------

Comment By: Carlos M.Viales Solorzano (carviaso)
Date: 2001-12-06 13:20

Message:
Logged In: YES 
user_id=348350

This error i correcting 
  if ( !defined('$_PHPLIB')) {
  $_PHPLIB = array();
  $_PHPLIB["libdir"] = ""; 
  }

But say a new error, example:
  Fatal error: Cannot instantiate non-existent class:
  hordesession in E:\Inetpub\php\phplib-7.2d\php\page.inc
  on line 18

For what is this???


----------------------------------------------------------------------

Comment By: Carlos M.Viales Solorzano (carviaso)
Date: 2001-12-06 13:01

Message:
Logged In: YES 
user_id=348350

This error i correcting 
  if ( !defined('$_PHPLIB')) {
  $_PHPLIB = array();
  $_PHPLIB["libdir"] = ""; 
  }

But say a new error, example:
  Fatal error: Cannot instantiate non-existent class:
  hordesession in E:\Inetpub\php\phplib-7.2d\php\page.inc
  on line 18

For what is this???


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=489961&group_id=31885

[Phplib-trackers] [ phplib-Bugs-487852 ] fallback error

[<no...@so...>]

Bugs item #487852, was opened at 2001-12-01 08:36
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=487852&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Dieter Steinwedel (dsteinwe)
Assigned to: Nobody/Anonymous (nobody)
Summary: fallback error

Initial Comment:
I've recognized that the fallback mechanism from 
cookie to get doesn't work correctly. The created 
session always works, but sometimes the mechanism 
fallsback to "get" on session creation on browser with 
cookie support. 

The source of this behaviour may be "release_token()" 
and/or "get_id()" in "session.inc".

Dieter

----------------------------------------------------------------------

Comment By: Gaetano Giunta (ggiunta)
Date: 2002-01-10 03:47

Message:
Logged In: YES 
user_id=114789

My 2 eurocents of analysis: it depends on session.inc, function 
release_token, line 406 (in release 7.4rc1): mode is set to 
fallback.

This looks unnecessary (and if your'sure all your users 
have cookies enabled just comment the line and all will be smooth), but it 
stems from a logic problem: if a page is hit by the browser and there's no 
cookie found containing the session id, there's no (easy) way that PHPLIB 
can possibly know if it is the first time that the page was hit and the 
session cookie has yet to be set, or if it is the second time that the page is 
hit and the cookie is not working, so session should switch to fallback 
mode. To make sure it gets it right, phplib adds the session id in the URL, 
although it looks a bit nasty to the end user.

An (hard and long ?) way to 
do it could be storing in the db container the session info on the first page 
hit, before redirecting the user. This way the second page hit would find 
the session id already defined in the db and know that if no cookie is there 
it should fall back to get mode and try a second redirect including the 
session id in the url...

Hope this helps a bit (and maybe even gets 
implemented in verion 8 or someting...)
Gaetano

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=487852&group_id=31885

[Phplib-trackers] [ phplib-Bugs-480851 ] Warnings in sessions.inc

[<no...@so...>]

Bugs item #480851, was opened at 2001-11-12 02:02
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=480851&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Warnings in sessions.inc

Initial Comment:
Hi,

I get following warnings on using "sessions.inc":

Warning: Call-time pass-by-reference has been 
deprecated - argument passed
by value; If you would like to pass it by reference, 
modify the declaration
of [runtime function name](). If you would like to 
enable call-time
pass-by-reference, you can set 
allow_call_time_pass_reference to true in
your INI file. However, future versions may not 
support this any longer. in
session.inc on line 262

Warning: Call-time pass-by-reference has been 
deprecated - argument passed
by value; If you would like to pass it by reference, 
modify the declaration
of [runtime function name](). If you would like to 
enable call-time
pass-by-reference, you can set 
allow_call_time_pass_reference to true in
your INI file. However, future versions may not 
support this any longer. in
session.inc on line 273

Warning: Call-time pass-by-reference has been 
deprecated - argument passed
by value; If you would like to pass it by reference, 
modify the declaration
of [runtime function name](). If you would like to 
enable call-time
pass-by-reference, you can set 
allow_call_time_pass_reference to true in
your INI file. However, future versions may not 
support this any longer. in
session.inc on line 304

Warning: Call-time pass-by-reference has been 
deprecated - argument passed
by value; If you would like to pass it by reference, 
modify the declaration
of [runtime function name](). If you would like to 
enable call-time
pass-by-reference, you can set 
allow_call_time_pass_reference to true in
your INI file. However, future versions may not 
support this any longer. in
session.inc on line 305

Warning: Call-time pass-by-reference has been 
deprecated - argument passed
by value; If you would like to pass it by reference, 
modify the declaration
of [runtime function name](). If you would like to 
enable call-time
pass-by-reference, you can set 
allow_call_time_pass_reference to true in
your INI file. However, future versions may not 
support this any longer. in
session.inc on line 311

Warning: Cannot add header information - headers 
already sent by (output
started at session.inc:262) in session.inc on line 392

Warning: Cannot add header information - headers 
already sent by (output
started at session.inc:262) in session.inc on line 117

Warning: Cannot add header information - headers 
already sent by (output
started at session.inc:262) in session.inc on line 404


By the way, I have 
switched "allow_call_time_pass_reference" to true, but 
it doesn't matter. Can someone help me?

----------------------------------------------------------------------

Comment By: Gaetano Giunta (ggiunta)
Date: 2002-01-10 02:52

Message:
Logged In: YES 
user_id=114789

It depends on php.ini settings: in version 4.1 the default value for 
allow_call_time_pass_reference has been set to Off. 

If you have 
this, and error_reporting = ALL, you will get some warnings (the warnings 
come before PHPLIB sends the headers for caching, thus generating the 
rest of the warnings).

The problem lies in calls to seesion-
>serialize() in session.inc wrongly using &$string instead of 
$string.

Short-term Solution: set 
allow_call_time_pass_reference to On

Long-term Solution: fix damn 
calls to session->serialize() in session.inc (PLEEZ, SOMEONE WITH A CVS 
ACCOUNT DO THIS BEFORE 7.4 FINAL IS OUT)!!!

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2001-12-09 21:10

Message:
Logged In: NO 

I am running into the same problem.  Has anyone come up 
with a solution to this?

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=480851&group_id=31885