phplib-trackers — List for monitoring the phplib SourceForge trackers.

[Phplib-trackers] [ phplib-Bugs-467993 ] db_odbc does not close

[<no...@so...>]

Bugs item #467993, was opened at 2001-10-05 04:11
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=467993&group_id=31885

Category: None
Group: None
>Status: Closed
>Resolution: Invalid
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Richard Archer (richardarcher)
Summary: db_odbc does not close

Initial Comment:
I'm using PHPlib with the PHPshop-core and installed 
it on a win2k/IIS/ODBC/Access server and found out 
that in the DB_ODBC class odbc_pconnect is used, but 
it isn't closed.

It took me a while to find it out because it doesn't 
give back an error! Now I changed it to odbc_(without 
p)connect and it works.

I don't know if it is the best solution so I would 
like to know if a pconnect with a close is beter...

grtz,

Mark

----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 20:02

Message:
Logged In: YES 
user_id=279311

This isn't the correct forum for a support query.

And it seems you've found the solution to your problems.
 

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=467993&group_id=31885

[Phplib-trackers] [ phplib-Feature Requests-450665 ] logging authenticated users

[<no...@so...>]

Feature Requests item #450665, was opened at 2001-08-14 11:39
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403614&aid=450665&group_id=31885

Category: None
Group: None
Status: Open
Priority: 3
Submitted By: Richard Archer (richardarcher)
Assigned to: Nobody/Anonymous (nobody)
Summary: logging authenticated users

Initial Comment:
Transferred from old phplib-users list

Alec Effrat wrote:
> But what is lacks is sufficient logging.  Is there
any effort going on
> right now to create a logging object?  Or maybe there
is a way to have
> PHP register a user with Apache's authentication
module as a "regularly
> authenticated user", without prompting the user to
login, so apache will
> track this info in it's logs automatically?


----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 19:55

Message:
Logged In: YES 
user_id=279311

The demo "setup.inc" which comes with the PHPLIB
distribution contains code to log the beginning of each
session. This could be used as a basis for a user activity
report.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403614&aid=450665&group_id=31885

[Phplib-trackers] [ phplib-Feature Requests-455856 ] PHPLib fails with register_globals off

[<no...@so...>]

Feature Requests item #455856, was opened at 2001-08-28 04:26
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403614&aid=455856&group_id=31885

Category: None
Group: Next Release (example)
>Status: Closed
>Priority: 1
Submitted By: Bob Gorman (rag56)
>Assigned to: Richard Archer (richardarcher)
Summary: PHPLib fails with register_globals off

Initial Comment:
PHPLib should work when register_globals is off. 

See bug #446455. (Also submitted accidently as patch 
#455851, oops).

Many PHPLib scripts depend on PHP automatically 
registering variables into the global name space. 

If we set register_globals to off via .htaccess (or 
another method) for security reasons then portions of 
PHPLib fail to function properly. 

In bug #446455 I document a short-term work around. 
It would be better if the PHPLib scripts would work 
properly regardless to the setting of 
register_globals. 

In specific PHPLib should use the HTTP_*_VARS to 
gather the values of variables passed from the client. 

For example: 

  In function auth_validatelogin() we see: 

    global $username, $password; 

  This should be re-coded as: 

    global $HTTP_POST_VARS; 
    $username = $HTTP_POST_VARS["username"]; 
    $password = $HTTP_POST_VARS["password"]; 

  Or even better is: 

    $username = isset($HTTP_POST_VARS 
    ["username"]) ? $HTTP_POST_VARS["username"] : ""; 
    $password = isset($HTTP_POST_VARS 
    ["password"]) ? $HTTP_POST_VARS["password"] : ""; 

Use of isset() is added to prevent errors when using 
E_NOTICE. 

The script session.inc is coded pretty well. Others 
are not. 

I think this is important for the long-term viablility 
of PHPLib. 


----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 19:48

Message:
Logged In: YES 
user_id=279311

This is fixed in CVS.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403614&aid=455856&group_id=31885

[Phplib-trackers] [ phplib-Feature Requests-548508 ] DB class enhancements

[<no...@so...>]

Feature Requests item #548508, was opened at 2002-04-25 19:32
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403614&aid=548508&group_id=31885

Category: None
Group: None
Status: Open
Priority: 5
Submitted By: Richard Archer (richardarcher)
Assigned to: Nobody/Anonymous (nobody)
Summary: DB class enhancements

Initial Comment:
From Ben Drushell

I have been working on various projects that utilize
phpLib. For functionality uniformity purposes, I
modified several of the DB classes. I also made
enhancements and included a child class "CiaoSQL".


http://www.technobreeze.com/php/objects/

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403614&aid=548508&group_id=31885

[Phplib-trackers] [ phplib-Feature Requests-516694 ] nextid() missing in db_odbc.inc

[<no...@so...>]

Feature Requests item #516694, was opened at 2002-02-13 10:11
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403614&aid=516694&group_id=31885

Category: None
Group: None
>Status: Closed
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Richard Archer (richardarcher)
Summary: nextid() missing in db_odbc.inc

Initial Comment:
Hello,

I use PHPShop which uses PHPLIB and the nextid() 
database function. But that function is not present in the 
db_odbc.inc. And therefore there lacks a bit of functionality. 

I've seen the problem is noticed before, but I haven't found a 
solution. Is there one (besides writing it myself 
:)?

grtz,

Mark

----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 19:00

Message:
Logged In: YES 
user_id=279311

I have implemented this in the devel tree. Table locking and
nextid. It hasn't been tested extensively, but should make a
good basis for any future work on this feature.


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403614&aid=516694&group_id=31885

[Phplib-trackers] [ phplib-Feature Requests-526911 ] template.inc Hack: Send output to FILES

[<no...@so...>]

Feature Requests item #526911, was opened at 2002-03-07 23:04
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403614&aid=526911&group_id=31885

Category: None
Group: Next Release (example)
>Status: Closed
Priority: 5
Submitted By: Carlos Sanchez (txarly)
>Assigned to: Richard Archer (richardarcher)
Summary: template.inc Hack: Send output to FILES

Initial Comment:
Hi to all!

I've been working in a project in which I needed to 
send HTML emails. I love the PHPLib's template Class, 
but It didn't have any method to output the whole 
bunch of HTML to a file instead to the browser. I 
needed this because the HTML of the email was dynamic, 
you know: It needed brackets in it. {user_name}, etc.
I generated an HTMl file, and then attached to the 
email using a fantastic class that I found out there.

I've added a new method, called p_file(), that is 
quite similar to p(), but instead of printing all the 
output of the page, it stores the whole bunch in a 
file.

So... here is it:


/***********************************************/
/* public: p(string $varname)
 * varname: name of variable to print.
 */
function p($varname) {
  print $this->finish($this->get_var($varname));
}
  
/**********************************************/ 
/* public: p_file(string $varname, string $path, 
string $file_name)
 * varname: name of variable to print.
 * Txarly :) Hack!! Print the complete output to a 
file!!
 */
function p_file($varname , $path , $file_name) {
  // Open the file
  $fp = fopen ($path.$file_name, "w+");
  // Send the output
  fwrite($fp,$this->finish($this->get_var($varname)));
  fclose($fp);
}

Pretty simple, isn't it??

Hope this'd help. Maybe it could be added in the next 
release!! 

Thankx for a great library.

Txarly :)





----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 18:57

Message:
Logged In: YES 
user_id=279311

Closing this because the feature should be part of the
application logic, not the template engine. 

----------------------------------------------------------------------

Comment By: Richard Archer (richardarcher)
Date: 2002-03-08 07:35

Message:
Logged In: YES 
user_id=279311

I suggest using the already-present t->get() function?

Get the finished template output and write it to a file in
your code. Or inject it straight into your mail queue. 

 ...R.


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403614&aid=526911&group_id=31885

[Phplib-trackers] [ phplib-Patches-480713 ] template.inc: Backslashes disappear

[<no...@so...>]

Patches item #480713, was opened at 2001-11-12 08:55
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=480713&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Julian Ladisch (jula)
>Assigned to: Richard Archer (richardarcher)
Summary: template.inc: Backslashes disappear

Initial Comment:
Backslashes used in value strings of set_var()
disappear.

Example:

$t = new Template();
$t->set_var("field", "\\\\");   // four escaped
backslashes
$t->set_var("area", "{field}");
$t->set_var("test", "{out}");

echo "field = " . $t->get_var("field");
echo ", area = " . $t->parse("out", "area");
echo ", test = " . $t->parse("out", "test");

Result is
field = \\, area = \, test = \

It should be
field = \\, area = \\, test = \\

Reason is preg_replace (pattern, replacement,
subject).  It needs preg_quote() for parameter pattern,
which is already done, but also escaping of any
backslash in parameter replacement, which is done for
special cases (\[0-9], \[0-9]) only.

The attached diff provides a patch for this.  It is
even faster because of using str_replace() instead of
preg_replace().

This also fixes the following error:

$t = new Template();
$t->set_var("foo", "\1 \1");
echo htmlspecialchars($t->get("foo"));

Result is "\1 \1", it should be "\1 \1".

----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 18:53

Message:
Logged In: YES 
user_id=279311

This patch does not work well for me. 

I can't think of a better method than the one currently in
use. Except perhaps adding a third expression in the
preg_replace: '/\\\\/' -> '\\'

Try this code:

<?php

	include("template.inc");

	$t = new Template(".","comment");
	$t->debug=7;

	$t->set_file("page", "testspecialchars.tmpl");
	
	$t->set_var("dollarone", "\");
	$t->set_var("ampdollarone", "&#36;1");
	
	$t->set_var("sone", "\1");
	$t->set_var("ssone", "\\1");
	$t->set_var("sssone", "\\\1");
	$t->set_var("ssssone", "\\\\1");
	$t->set_var("ampslashone", "&#92;1");
	
	$t->get_vars();
	
	$t->parse("output", "page");
	$t->p("output");

?> 


on this template:

<html>
<body>
<pre>
dollar one: $1 = {dollarone}
amp dollar one: &#36;1 = {ampdollarone}

slash one: \1 = {sone}
ss one: \1 = {ssone}
sss one: \\1 = {sssone}
ssss one: \\1 = {ssssone}
amp slash one: &#92;1 = {ampslashone}

</pre>
</body>
</html>


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=480713&group_id=31885

[Phplib-trackers] [ phplib-Patches-501754 ] removed call-by-ref from user.inc

[<no...@so...>]

Patches item #501754, was opened at 2002-01-10 23:41
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=501754&group_id=31885

Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Gaetano Giunta (ggiunta)
Assigned to: Nobody/Anonymous (nobody)
Summary: removed call-by-ref from user.inc

Initial Comment:
modified calls to session->serialize() that will give warning 
messages with allow-call-by-refernce set to Off in php.ini

----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 17:39

Message:
Logged In: YES 
user_id=279311

These are already fixed in CVS.

----------------------------------------------------------------------

Comment By: Gaetano Giunta (ggiunta)
Date: 2002-01-14 22:35

Message:
Logged In: YES 
user_id=114789

DOH! forgot to mention: patch is against version 7.4rc1

in this 
release definition of sess->serialize in session.inc is ok! I think user-
>freeze was added to override session->freeze (since user is a descendent 
of session this is correct); the main difference is that if user==nobody 
(not authenticated user), session data is not frozen. Actually code 
could be simpler: if user!= nobody then call inherited 
method...

Gaetano

----------------------------------------------------------------------

Comment By: Dieter Steinwedel (dsteinwe)
Date: 2002-01-12 03:53

Message:
Logged In: YES 
user_id=373951

You must also change the function header of "serialize" in 
session.inc. Add a "&" before the param "$str". Otherwise 
it doesn't work!

Why do you put "freeze" to the class "user"? It is a part 
of "session".

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=501754&group_id=31885

[Phplib-trackers] [ phplib-Patches-511458 ] Patches for phplib7.2c

[<no...@so...>]

Patches item #511458, was opened at 2002-02-01 09:46
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=511458&group_id=31885

Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Thomas L. Kjeldsen (tlk)
>Assigned to: Richard Archer (richardarcher)
Summary: Patches for phplib7.2c

Initial Comment:
Hi,
about one year ago I made some patches for phplib7.2c
which makes the code in db_mysql.inc more robust.

I believe the patches are still relevant for phplib7.2d.

A description of the problem and patches is available
at http://intra.dipcard.com/people/tlk/phplib/


regards,
Thomas L. Kjeldsen

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=511458&group_id=31885

[Phplib-trackers] [ phplib-Patches-472136 ] Bug in session.inc with HTTP_POST_VARS

[<no...@so...>]

Patches item #472136, was opened at 2001-10-18 02:41
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=472136&group_id=31885

Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Oliver Kurz (ojk)
>Assigned to: Richard Archer (richardarcher)
Summary: Bug in session.inc with HTTP_POST_VARS

Initial Comment:
We realized in one of our projects a little "bug" in the file session.inc (PHPLib 7.2c). If you set the  
mode to cookie and the fallbackmode to get and then sending the session__id with post through a 
html-form, than your session is lost. 

The reason is, the function release_token only looks in $HTTP_GET_VARS for the session_id, if 
fallbackmode is necessary. But not in $HTTP_POST_VARS, but this could also be possible, if no 
cookies are allowed and the session_id is transmitted by a hidden form field. 

We fixed the function as you can see at the bottom of this text. Now the function looks for 
fallbackmode also in the post-vars for the session_id, if it isn't set in cookie- or get-vars.

  // Fix
  function release_token(){ 
    // Old Version
//    global $HTTP_COOKIE_VARS, $HTTP_GET_VARS, $HTTP_HOST, $HTTPS;
    // New Version
    global $HTTP_COOKIE_VARS, $HTTP_GET_VARS, $HTTP_HOST, $HTTPS, $HTTP_POST_VARS;
    if (   isset($this->fallback_mode)
    && ( "get" == $this->fallback_mode ) 
    && ( "cookie" == $this->mode )
    && ( ! isset($HTTP_COOKIE_VARS[$this->name]) ) ) {
      // Old Version
//      if ( isset($HTTP_GET_VARS[$this->name]) ) {
      // New Version
      if ( isset($HTTP_GET_VARS[$this->name]) || isset($HTTP_POST_VARS[$this->name]) ) {
        $this->mode = $this->fallback_mode;
      } else {
        header("Status: 302 Moved Temporarily");
        $this->get_id($sid);
	$this->mode = $this->fallback_mode;
        if( isset($HTTPS) && $HTTPS == 'on' ){
        ## You will need to fix suexec as well, if you use Apache and CGI PHP
          $PROTOCOL='https';
        } else {
          $PROTOCOL='http';
        }
        header("Location: ". $PROTOCOL. "://".$HTTP_HOST.$this->self_url());
        exit;
      }
    }
  }   


----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 16:59

Message:
Logged In: YES 
user_id=279311

Looks like this is already fixed in CVS.

----------------------------------------------------------------------

Comment By: Dieter Steinwedel (dsteinwe)
Date: 2002-01-26 04:05

Message:
Logged In: YES 
user_id=373951

I have written a patch for submitted post_vars. If you are 
interested in, look for the title "Patch for auth/session 
with post_vars".

Dieter

----------------------------------------------------------------------

Comment By: Gaetano Giunta (ggiunta)
Date: 2002-01-10 23:28

Message:
Logged In: YES 
user_id=114789

Well, fallback='get' gives you a clear idea of supported fallback 
methods.

Instead of adding post support this way another (cleaner ?) 
idea would be to add a 'post' and 'both' options to fallback.

The main 
problem is that there is no easy way in PHP to send POST data to a web page 
(there are hacks involving use of sockets, but I dunno if they're 
bulletproof). And the id data needs to be sent not only expressly by the 
user when clicking on forms with hidden fields, but also by phplib itself 
(e.g. it adds it to urls with sess_url()).
My best guess is the POST only 
method is completely impracticable, so maybe your hack is the best option 
in the end)

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=472136&group_id=31885

[Phplib-trackers] [ phplib-Patches-508534 ] Patch for auth/session with post_vars

[<no...@so...>]

Patches item #508534, was opened at 2002-01-26 04:06
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=508534&group_id=31885

Category: None
Group: None
>Status: Closed
>Resolution: Invalid
Priority: 5
Submitted By: Dieter Steinwedel (dsteinwe)
>Assigned to: Richard Archer (richardarcher)
Summary: Patch for auth/session with post_vars

Initial Comment:
This patch fixes the problem with post_vars in auth 
and session. This patch is developed for "phplib-7.2d".

Have fun with it ...
	Dieter

----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 16:51

Message:
Logged In: YES 
user_id=279311

The register_globals issue has already been fixed.

----------------------------------------------------------------------

Comment By: Dieter Steinwedel (dsteinwe)
Date: 2002-01-26 23:21

Message:
Logged In: YES 
user_id=373951

I have fixed in the new version some bugs ...

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=508534&group_id=31885

[Phplib-trackers] [ phplib-Patches-548449 ] CC validation formula

[<no...@so...>]

Patches item #548449, was opened at 2002-04-25 16:33
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=548449&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Richard Archer (richardarcher)
Assigned to: Nobody/Anonymous (nobody)
Summary: CC validation formula

Initial Comment:
From: Lindsay Haisley

Here's a neat little piece which I put together to
check credit card
numbers.  The algorithm for doing this is based on
what's called the LUHN
formula which you can find lots of places such as
<http://www.webopedia.com/TERM/L/Luhn_formula.html>
although credit card
companies won't tell you what it is :-).  This might
make a nice add-on to
the cart class, although it's certainly functionally
peripheral to operation
of the class.



----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=548449&group_id=31885

[Phplib-trackers] [ phplib-Bugs-545551 ] PHP 4.3.0-DEV incompatibility

[<no...@so...>]

Bugs item #545551, was opened at 2002-04-18 19:18
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=545551&group_id=31885

Category: None
Group: 7.4pre1
Status: Closed
>Resolution: Fixed
>Priority: 1
Submitted By: David S. (dazo)
>Assigned to: Richard Archer (richardarcher)
Summary: PHP 4.3.0-DEV incompatibility

Initial Comment:
Hello!

I'm running Apache 2.0.35 and PHP-4.3.0-DEV on my
machine and tried to install phplib-7.4pre1

Ok!  Since the latest PHP has some great security
improvements, it's not fully compatible with your
latest phplib.

I noticed these two differences which led to a
modification in php.ini file.

** 1.  allow_call_time_pass_reference (comment taken
out php ini file)
; Whether to enable the ability to force arguments to
be passed by reference
; at function call time.  This method is deprecated and
is likely to be
; unsupported in future versions of PHP/Zend.  The
encouraged method of
; specifying which arguments should be passed by
reference is in the function
; declaration.  You're encouraged to try and turn this
option Off and make
; sure your scripts work properly with it in order to
ensure they will work
; with future versions of the language (you will
receive a warning each time
; you use this feature, and the argument will be passed
by value instead of by
; reference).
allow_call_time_pass_reference = Off

This has to be set to 'On' ... You might want to
consider rewriting this since this option/feature
probably will disapear in the near future ...

** 2.  register_globals (comment from php.ini)
;     Global variables are no longer registered for
input data (POST, GET, cookies,
;     environment and other server variables).  Instead
of using $foo, you must use
;     you can use $_REQUEST["foo"] (includes any
variable that arrives through the
;     request, namely, POST, GET and cookie variables),
or use one of the specific
;     $_GET["foo"], $_POST["foo"], $_COOKIE["foo"] or
$_FILES["foo"], depending
;     on where the input originates.  Also, you can
look at the
;     import_request_variables() function.
;     Note that register_globals is going to be
depracated (i.e., turned off by
;     default) in the next version of PHP, because it
often leads to security bugs.
;     Read
http://php.net/manual/en/security.registerglobals.php
for further
;     information.
register_globals = Off

This also has to be set to 'On'  ... this feature I
simply decline to set to On due to security risks.  And
this feature/option will also disapear in the near
future ...

I also noticed that a line is missing in the
db_pgsql.inc ...  Add
	var $Port     = "";
in the DB_Sql class.

And one last thing ... since PHP4 ... all the
extensions on this PHP scripts are .php ... so you
might want to rename all the files ... if not, the user
have to edit the Apache configuration file (httpd.conf)
to enable .php3 files to act as .php files.  

If it wasn't for all this, I would have started using
the library today, but I don't dare to do that now
because I must rely on features in the latest PHP
version and since the most important PHP options might
disapear I can not bind myself to this library.

Except for this, this library seems to be great!

----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 15:33

Message:
Logged In: YES 
user_id=279311

Most of these are now fixed.
Added a cheap fix to a broken concept in the -devel
auth/sql/auth.inc.

----------------------------------------------------------------------

Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 15:32

Message:
Logged In: YES 
user_id=279311

Most of these are now fixed.
Added a cheap fix to a broken concept in the -devel
auth/sql/auth.inc.

----------------------------------------------------------------------

Comment By: David S. (dazo)
Date: 2002-04-19 19:16

Message:
Logged In: YES 
user_id=231324

I took the latest CVS version and tried it!  Much better!

But I do get a strange error/notice from PHP:

Notice: Undefined index: error in phplib/auth/sql/auth.inc
on line 194

I tried to add the an error variable (var $error = "") in
both the phplib/auth/auth.inc and phplib/auth/sql/auth.inc

But it didn't seem to work ... I'm gonna have a close look
on this one. (In my php.ini I have: error_reporting  = 
E_ALL; display_errors = On; display_startup_errors = On; 
--- and thats the reason it screams about it, but I'm
paranoid so I like to see my mistakes! ;-)

Keep up the good work!  This is great!


David S.
I also added a patch for the pgsql driver (the $Port
variable)

----------------------------------------------------------------------

Comment By: Layne Weathers (layne_weathers)
Date: 2002-04-19 02:01

Message:
Logged In: YES 
user_id=278685

1. allow_call_time_pass_reference
This was fixed in session.inc last August so it should be 
fixed in 7.4pre1 - user.inc has since been fixed in CVS 
(fix yours by removing the ampersand in the calls to $this-
>serialize()) and there is one roque occurrence in 
layout_html.inc (on its way to being fixed) and one use in 
db_odbc.inc's next_record().

2. register_globals
This also is fixed in CVS. 

3. db_pgsql.inc
If you will provide a patch for using that parameter, we 
can get it into CVS.

4. file extensions
This has been asked before - I hate to keep .php3, but I 
also hate sending files to the CVS Attic just to change 
their name - it disconnects their history. I'll let someone 
else do the deed.

Unfortunately, I think there's still a bit of work to do 
before the next release. I have tested the latest CVS and 
it is now on my production servers - I recommend checking 
it out.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=545551&group_id=31885

[Phplib-trackers] [ phplib-Bugs-545551 ] PHP 4.3.0-DEV incompatibility

[<no...@so...>]

Bugs item #545551, was opened at 2002-04-18 19:18
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=545551&group_id=31885

Category: None
Group: 7.4pre1
>Status: Closed
>Resolution: Fixed
>Priority: 1
Submitted By: David S. (dazo)
>Assigned to: Richard Archer (richardarcher)
Summary: PHP 4.3.0-DEV incompatibility

Initial Comment:
Hello!

I'm running Apache 2.0.35 and PHP-4.3.0-DEV on my
machine and tried to install phplib-7.4pre1

Ok!  Since the latest PHP has some great security
improvements, it's not fully compatible with your
latest phplib.

I noticed these two differences which led to a
modification in php.ini file.

** 1.  allow_call_time_pass_reference (comment taken
out php ini file)
; Whether to enable the ability to force arguments to
be passed by reference
; at function call time.  This method is deprecated and
is likely to be
; unsupported in future versions of PHP/Zend.  The
encouraged method of
; specifying which arguments should be passed by
reference is in the function
; declaration.  You're encouraged to try and turn this
option Off and make
; sure your scripts work properly with it in order to
ensure they will work
; with future versions of the language (you will
receive a warning each time
; you use this feature, and the argument will be passed
by value instead of by
; reference).
allow_call_time_pass_reference = Off

This has to be set to 'On' ... You might want to
consider rewriting this since this option/feature
probably will disapear in the near future ...

** 2.  register_globals (comment from php.ini)
;     Global variables are no longer registered for
input data (POST, GET, cookies,
;     environment and other server variables).  Instead
of using $foo, you must use
;     you can use $_REQUEST["foo"] (includes any
variable that arrives through the
;     request, namely, POST, GET and cookie variables),
or use one of the specific
;     $_GET["foo"], $_POST["foo"], $_COOKIE["foo"] or
$_FILES["foo"], depending
;     on where the input originates.  Also, you can
look at the
;     import_request_variables() function.
;     Note that register_globals is going to be
depracated (i.e., turned off by
;     default) in the next version of PHP, because it
often leads to security bugs.
;     Read
http://php.net/manual/en/security.registerglobals.php
for further
;     information.
register_globals = Off

This also has to be set to 'On'  ... this feature I
simply decline to set to On due to security risks.  And
this feature/option will also disapear in the near
future ...

I also noticed that a line is missing in the
db_pgsql.inc ...  Add
	var $Port     = "";
in the DB_Sql class.

And one last thing ... since PHP4 ... all the
extensions on this PHP scripts are .php ... so you
might want to rename all the files ... if not, the user
have to edit the Apache configuration file (httpd.conf)
to enable .php3 files to act as .php files.  

If it wasn't for all this, I would have started using
the library today, but I don't dare to do that now
because I must rely on features in the latest PHP
version and since the most important PHP options might
disapear I can not bind myself to this library.

Except for this, this library seems to be great!

----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 15:32

Message:
Logged In: YES 
user_id=279311

Most of these are now fixed.
Added a cheap fix to a broken concept in the -devel
auth/sql/auth.inc.

----------------------------------------------------------------------

Comment By: David S. (dazo)
Date: 2002-04-19 19:16

Message:
Logged In: YES 
user_id=231324

I took the latest CVS version and tried it!  Much better!

But I do get a strange error/notice from PHP:

Notice: Undefined index: error in phplib/auth/sql/auth.inc
on line 194

I tried to add the an error variable (var $error = "") in
both the phplib/auth/auth.inc and phplib/auth/sql/auth.inc

But it didn't seem to work ... I'm gonna have a close look
on this one. (In my php.ini I have: error_reporting  = 
E_ALL; display_errors = On; display_startup_errors = On; 
--- and thats the reason it screams about it, but I'm
paranoid so I like to see my mistakes! ;-)

Keep up the good work!  This is great!


David S.
I also added a patch for the pgsql driver (the $Port
variable)

----------------------------------------------------------------------

Comment By: Layne Weathers (layne_weathers)
Date: 2002-04-19 02:01

Message:
Logged In: YES 
user_id=278685

1. allow_call_time_pass_reference
This was fixed in session.inc last August so it should be 
fixed in 7.4pre1 - user.inc has since been fixed in CVS 
(fix yours by removing the ampersand in the calls to $this-
>serialize()) and there is one roque occurrence in 
layout_html.inc (on its way to being fixed) and one use in 
db_odbc.inc's next_record().

2. register_globals
This also is fixed in CVS. 

3. db_pgsql.inc
If you will provide a patch for using that parameter, we 
can get it into CVS.

4. file extensions
This has been asked before - I hate to keep .php3, but I 
also hate sending files to the CVS Attic just to change 
their name - it disconnects their history. I'll let someone 
else do the deed.

Unfortunately, I think there's still a bit of work to do 
before the next release. I have tested the latest CVS and 
it is now on my production servers - I recommend checking 
it out.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=545551&group_id=31885

[Phplib-trackers] [ phplib-Bugs-480403 ] prepend.php3 needs change in quickstart

[<no...@so...>]

Bugs item #480403, was opened at 2001-11-11 05:48
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=480403&group_id=31885

Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Allan Høiberg (allanh)
Assigned to: Nobody/Anonymous (nobody)
Summary: prepend.php3 needs change in quickstart

Initial Comment:
In version 7.2d prepend.php has the line

$_PHPLIB["libdir"] = "/home/nathan/webDevel/php-lib-
stable/php/";

which effectively stops every PHP page from working 
once the quick guide has been followed.

The line needs to be changed to whatever the include 
directory created in step 1 was called.


----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 15:18

Message:
Logged In: YES 
user_id=279311

This got fixed for 7.4pre1.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=480403&group_id=31885

[Phplib-trackers] [ phplib-Bugs-445191 ] sessions redirection problem on ISP

[<no...@so...>]

Bugs item #445191, was opened at 2001-07-28 01:08
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=445191&group_id=31885

Category: None
Group: None
>Status: Closed
>Resolution: Rejected
Priority: 5
Submitted By: SUAU Romain (rsuau)
>Assigned to: Richard Archer (richardarcher)
Summary: sessions redirection problem on ISP

Initial Comment:
Hello,

I got trouble for monthes on my french ISP www.free.fr 
using phplib for session handling. I thought it was 
their fault but I discovered the bug was caused by 
sessions.inc + crcloginform.ihtml. On some ISP like 
the one I use, your personal website URL 
(personal.free.fr) is different from the server 
hostname (proxyphp3.free.fr). So when redirection is 
done after setting the cookie, the url becomes wrong.

It acts the same way on a Windows box when you get 
redirected to http://localhost/php.exe/...

So is it possible to add a parameter in local.inc as 
to specify the website address for redirections.

I tweaked the two files, like this (not a very good 
way):
       - sessions.inc (function release_token):
header("Location: ". $PROTOCOL. "://".$HTTP_HOST.$this-
>self_url());

becomes =>

// Patch
	if ("$HTTP_HOST" == "proxyphp3.free.fr")
	{
		header("Location: ". 
$PROTOCOL. ":/".$this->self_url());
	}
	else
	{
		header("Location: ". 
$PROTOCOL. "://".$HTTP_HOST.$this->self_url());
	}
// patch end


       - crcloginform.ihtml (form generation):

<form name="login" action="<?php 
	$bonne_adresse=$this->url();
	print ereg_replace("/personal.free.fr" , "" , 
$bonne_adresse);

?>" method=post>


If you could do something in the next version, many 
people would appreciate I think.

Regards

SUAU Romain
(rsuau.free.fr & www.hifiprix.com)


----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 15:17

Message:
Logged In: YES 
user_id=279311

I'm killing this bug off. If you can't use cookies to
maintain state, set $sess->mode="get". Don't forget to run
all URLs in the site through $sess->url. Template makes this
a breeze.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2001-07-28 16:24

Message:
Logged In: NO 

But what do you use as
cookie_domain =

If you specify nothing there, the cookie left on the client
is valid only for that very host, eg proxyphp3.free.fr, not
for personal.free.fr

Did you try specifying 
cookie_domain= free.fr  ### ?

Prpbbly this solves your ptoblem



----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=445191&group_id=31885

[Phplib-trackers] [ phplib-Bugs-460463 ] Default Auth "cancel" button

[<no...@so...>]

Bugs item #460463, was opened at 2001-09-11 07:27
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=460463&group_id=31885

Category: None
Group: None
>Status: Closed
>Resolution: Rejected
Priority: 5
Submitted By: Richard Archer (richardarcher)
>Assigned to: Richard Archer (richardarcher)
>Summary: Default Auth "cancel" button

Initial Comment:
Reposted from -users list:

I need a little help with a problem I'm having. It's
probably really simple,
but I can't seem to hack my way through it. 

I am using default authentication on a site. I have a
link at the top of the
page that can be used to login. When you click the
link, it takes you to a
page that does a:

page_open(...);
$auth->login_if ( $auth->auth[uid] == "nobody" );
page_close();

This pulls up auth's corresponding login dialog. The
problem is, I have a
cancel button on this dialog. No matter what I put
behind the cancel, I
can't get rid of the login dialog (unless I enter a
valid username and
password). I'm currently trying to make the cancel
button link to a logout
page that does:

my_page_open();
$auth->logout (true);
my_page_close();

But this doesn't work. The logout page apparently
generates another login
page before it gets to the logout() function. 

Thanks in advance for ANY help!

-bpopp

-------------------------------------------------

But there a specific name for that cancel button,
default I think
'cancel_button', specified in the Auth var $cl. Did you
use that name
for the input field/link_querystr? Then method start of
Auth (that is
any phplib Auth'd page) should take care of that. No
need for a special
ACTION

also see:
http://marc.theaimsgroup.com/?l=phplib&m=94269299705992&w=2

dunno if it's already in the code.
-Gian

--------------------------------------------------

List:     phplib
Subject:  Re: [PHPLIB] Bailing out of loginform.ihtml?
From:     Mike Green <Mik...@sa...>
Date:     1999-11-15 18:58:54
[Download message RAW]

Well, maybe I'm not quite tuned in to your problem, but
if I am the following
could help:

I use have modified the function auth_validatelogin()
given in the sample
local.inc (local.inc,v 1.23 1999/08/25 11:40:48 kk) so
that the first few lines
are:

function auth_validatelogin() {
    global $username, $password;
    if(isset($username)) {
        $this->auth["uname"]=$username;     ## This
provides access for
"loginform.ihtml"
    }else if ($this->nobody){                      ## 
provides for "default
login cancel"
        $uid = $this->auth["uname"] =
$this->auth["uid"] = "nobody";
        return $uid;
    }
    $uid = false;
...

[instead of
function auth_validatelogin() {
    global $username, $password;
    if(isset($username)) {
      $this->auth["uname"]=$username;        ## This
provides access for
"loginform.ihtml"
    }
    $uid = false;
...
]

As I study what I've done here I can see that it
suffers from a classic case of
insufficient documentation.  When I created this
("hack"?!) I think I figured
out what needed to be done and did this.  Now that I
look at it I'm cannot
explain it -- except that it is working :-) ... or
should that be a ;-(...

Cheers!

Mike




----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 15:13

Message:
Logged In: YES 
user_id=279311

I have confirmed that there is nothing wrong with the
existing code as long as it is used correctly.

Oh, and this isn't the place for tech support queries :)



----------------------------------------------------------------------

Comment By: James Wigdahl (jwigdahl)
Date: 2001-09-17 12:34

Message:
Logged In: YES 
user_id=294845

I've done all this and it's still not working for me.

I have a page "page.php" that opens as such:

### PROTECTED PAGE ###

<?php

if (isset($HTTP_GET_VARS["l"])) {
  $l = $HTTP_GET_VARS["l"];
}
if (isset($HTTP_POST_VARS["cancel_login"])) {
  $cancel_login = $HTTP_POST_VARS["cancel_login"];
  $l = 0;
} else if (isset($HTTP_GET_VARS["cancel_login"])) {
  $cancel_login = $HTTP_GET_VARS["cancel_login"];
  $l = 0;
}

require ("../inc/config.php"); 

page_open( array( "sess" => "Wg_Session", "auth" => 
"Wg_Default_Auth"));

if ($cancel_login) {
  $auth->nobody = true;
}
$auth->login_if($l);

[stuff]

?>
### END OF PROTECTED PAGE ###



There is a link on this page, that if clicked, reloads the 
page as "page.php?l=yes" which effectively triggers the 
login_if() and presents the login form specified in 
auth_loginform() of my Auth subclass.

My login form looks like the following:



### LOGIN FORM ###

[stuff]

<a href="<?php $sess->purl("page.php?cancel_login=yes"); ?>">
Go back to the protected page</a>.
<form method="post" name="cancel" action="<?php $sess->
purl(); ?>"><input type="submit" name="cancel_button" value=
"Go Back"></form>

[stuff]

### END OF LOGIN FORM ###



I have added the following code to auth_validatelogin() of my 
subclassed Auth as indicated at http://marc.theaimsgroup.com/
?l=phplib&m=94269299705992&w=2 (thank you Gian):



### STUFF ADDED TO auth_validatelogin() ###

if (isset($username)) {
  $this->auth["uname"] = $username;  // This provides access 
for "loginform.ihtml"
} else if ($this->nobody) {          // Provides for default 
login cancel
  $uid = $this->auth["uname"] = $this->auth["uid"] = 
"nobody";
  return $uid;
}

### END STUFF ADDED TO auth_validatelogin() ###


I have even explicitly set "var $cancel_login   = 
"cancel_login";" in my Auth subclass.

I am still unable to get the login process to cancel whether 
I click the link on the login page, or whether I click the 
button named "cancel_button". No matter where I go, I just 
get the login page.

I have begun delving into auth.inc into the code that's 
supposed to make this happen, but I haven't found why this is 
failing yet. Anyone have any ideas?


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=460463&group_id=31885

[Phplib-trackers] [ phplib-Bugs-466835 ] small bug in Table::table_row()

[<no...@so...>]

Bugs item #466835, was opened at 2001-10-02 00:16
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=466835&group_id=31885

Category: None
Group: None
>Status: Closed
>Resolution: Rejected
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Richard Archer (richardarcher)
Summary: small bug in Table::table_row()  

Initial Comment:
Lines 475 and 476 of table.inc (version 7.2d) read:

    $d = $this->select_colnames($data);    
    $this->table_row_open($row, $d, $class);    

According to the docs (and the description of table_row_open), the second argument "is for derived 
classes that override this function that want access to the row data for the row about to be opened." In 
reality, table_row_open() receives an array with fieldnames, not a hash with fieldname/value pairs.

Solution:
  o delete line 475
  o replace $d in line 476 with $data

Regards, Peter Fokkinga

----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 15:10

Message:
Logged In: YES 
user_id=279311

This is an API change, and would possibly break existing
PHPLIB installations which rely on the existing behaviour.

There is an identical change listed in Patches which 
may be reconsidered for a future release.

----------------------------------------------------------------------

Comment By: Fred Yankowski (fredy)
Date: 2002-01-16 05:47

Message:
Logged In: YES 
user_id=20580

Patch #504000 should fix this problem.


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=466835&group_id=31885

[Phplib-trackers] [ phplib-Patches-504000 ] fix calls to table_row_open()

[<no...@so...>]

Patches item #504000, was opened at 2002-01-16 05:46
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=504000&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Fred Yankowski (fredy)
>Assigned to: Richard Archer (richardarcher)
Summary: fix calls to table_row_open()

Initial Comment:
According to its comment, the second argument to 
table_row_open() in table.inc should be the array of 
data for the cells.  This patch updates code in 
table.inc so that that data is actually passed, rather 
than passing an array of column names (as current).

I have found this change to be very useful in practice 
as it allows me to override table_row_open in a 
subclass, where that specialized function stores away 
some information from $data so that data from one cell 
can be used when processing another cell.

This patch should fix bug #466835.


----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 15:08

Message:
Logged In: YES 
user_id=279311

I'm not too keen on applying this patch. 

While it makes more sense to pass the full array, this patch
changes the current API, possibly breaking existing
installations which depend on the old method.


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=504000&group_id=31885

[Phplib-trackers] [ phplib-Patches-503992 ] fix show_table_cells() in table.inc

[<no...@so...>]

Patches item #503992, was opened at 2002-01-16 05:30
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=503992&group_id=31885

Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Fred Yankowski (fredy)
>Assigned to: Richard Archer (richardarcher)
Summary: fix show_table_cells() in table.inc

Initial Comment:
The show_table_cells() method in table.inc sets 'cell' 
without using it, and uses 'col' not having set it.  
The latter causes a warning.

This patch changes 'col' to 'cell'.

This patch should fix bug #445388.


----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 15:05

Message:
Logged In: YES 
user_id=279311

I already fixed this!

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403613&aid=503992&group_id=31885

[Phplib-trackers] [ phplib-Bugs-445386 ] table.inc, print_array() calls

[<no...@so...>]

Bugs item #445386, was opened at 2001-07-28 11:27
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=445386&group_id=31885

Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Chris Johnson (chaska)
>Assigned to: Richard Archer (richardarcher)
Summary: table.inc, print_array() calls

Initial Comment:
table.inc -- several places where it should read $this-
>print_array($d), instead of print_array($d).

----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 14:07

Message:
Logged In: YES 
user_id=279311

search and replace

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=445386&group_id=31885

[Phplib-trackers] [ phplib-Bugs-445389 ] table.inc unused vairable

[<no...@so...>]

Bugs item #445389, was opened at 2001-07-28 11:32
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=445389&group_id=31885

Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Chris Johnson (chaska)
>Assigned to: Richard Archer (richardarcher)
Summary: table.inc unused vairable

Initial Comment:
table.inc -- function table_heading_cell() sets $found 
but never uses it.

----------------------------------------------------------------------

Comment By: Fred Yankowski (fredy)
Date: 2002-01-16 05:32

Message:
Logged In: YES 
user_id=20580

Patch #503992 fixes this problem.


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=445389&group_id=31885

[Phplib-trackers] [ phplib-Bugs-445388 ] Var name wrong in table.inc

[<no...@so...>]

Bugs item #445388, was opened at 2001-07-28 11:31
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=445388&group_id=31885

Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Chris Johnson (chaska)
>Assigned to: Richard Archer (richardarcher)
Summary: Var name wrong in table.inc

Initial Comment:
table.inc -- function show_table_heading_cells() has 
the line:
$cell = 0;
It should probably be $col = 0; (or the later line in 
the that function should be $cell++).

Since table_heading_cell() doesn't use the first 
argument, it seems like there is no observable 
defect.  table_heading_cell() should probably be 
corrected to eliminate the unused variable.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=445388&group_id=31885

[Phplib-trackers] [ phplib-Bugs-445387 ] Unset argument variables in table.inc

[<no...@so...>]

Bugs item #445387, was opened at 2001-07-28 11:29
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=445387&group_id=31885

Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Chris Johnson (chaska)
>Assigned to: Richard Archer (richardarcher)
Summary: Unset argument variables in table.inc

Initial Comment:
table.inc -- function show_table_page_rows() uses $key 
and $val but does not set them:
$this->table_row($row, $key, $val, $class);

----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 14:01

Message:
Logged In: YES 
user_id=279311

Fixed, now uses $row and $ary[$row].

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=445387&group_id=31885

[Phplib-trackers] [ phplib-Bugs-445385 ] table.inc, show_result() swallows first

[<no...@so...>]

Bugs item #445385, was opened at 2001-07-28 11:25
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=445385&group_id=31885

Category: None
Group: None
>Status: Closed
>Resolution: Invalid
Priority: 5
Submitted By: Chris Johnson (chaska)
>Assigned to: Richard Archer (richardarcher)
Summary: table.inc, show_result() swallows first 

Initial Comment:
table.inc -- next_record() is called twice in 
show_result() method, swallowing the first result row.

----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 12:37

Message:
Logged In: YES 
user_id=279311

I can't replicate this bug.

show_table_heading_row_result performs a
$db->seek($db->Row-1) after $db->next_record() which should
rewind the result set to the original position.

I'm closing this one... feel free to re-open it if I'm
missing something.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=445385&group_id=31885