[Phplib-users] rfe to template.inc

[Mike G. <mi...@op...>]

Hello Layne,

On Wed, 31 Dec 2003, Layne wrote:
> On Dec 31, 2003, at 10:25 AM, Mike Gifford wrote:
> > On Tue, 2003-12-30 at 12:16, Joe Stewart wrote:
> >> On Tue, Dec 30, 2003 at 09:49:43AM -0500, Mike Gifford wrote:
> >>> In talking to the Back-end.org team though, it seems like the 
> >>> following
> >>> modification to template.inc would make it easier for us to ensure
> >>> that
> >>> the file names are accurate and easily accessible.
> >> I like it if optional or debug type setting.  Or if your template 
> >> editor
> >> module can turn display on.  I don't like the comments on all 
> >> production sites.
> I've committed this option into the php-lib-stable tree.

Thanks!  I've pulled that into the CVS for Back-End so that it is in the
next release.  Now I just need to go through and get rid of all of the
comments that have been added to the templates manually.

> > Glad to know that there is general agreement on:
> > $str = "<!-- START $filename -->' . $str . '<!-- END  $filename
> -->';
> I changed "START" and "END" to "START FILE" and "END FILE" so that the
> end comment would be easily distinguishable from any undeclared block 
> comments.

Fine with me.

> > I also think that turning the comments on/off would be very useful. 
> I
> > guess it's a matter of being something that is configured within
> > template.inc or passed to template.inc from slashTemplate.class (and
> > probably set in the config.ini.php file)..
> The functionality is controlled via a class variable - 
> $filename_comments. This defaults to false to preserve consistent 
> functionality with previous versions as well as to provide minimal 
> configuration for production sites.

Yup.  Makes sense.  Thanks for including this so quickly...

Mike
-- 
Mike Gifford, OpenConcept Consulting
Free Software for Social Change -> http://www.openconcept.ca
Stop Cdn Pension Plan War Investments -> http://coat.openconcept.ca/
Another world is not only possible, she is on her way -Arundhati Roy