Re: [Phplib-users] Re: [Phpslash-devel] rfe to template.inc

[Layne W. <la...@dr...>]

On Dec 31, 2003, at 10:25 AM, Mike Gifford wrote:

> On Tue, 2003-12-30 at 12:16, Joe Stewart wrote:
>> On Tue, Dec 30, 2003 at 09:49:43AM -0500, Mike Gifford wrote:
>>> In talking to the Back-end.org team though, it seems like the 
>>> following
>>> modification to template.inc would make it easier for us to ensure 
>>> that
>>> the file names are accurate and easily accessible.
>> I like it if optional or debug type setting.  Or if your template 
>> editor
>> module can turn display on.  I don't like the comments on all 
>> production sites.

I've committed this option into the php-lib-stable tree.

> Glad to know that there is general agreement on:
> $str = "<!-- START $filename -->' . $str . '<!-- END  $filename -->';

I changed "START" and "END" to "START FILE" and "END FILE" so that the 
end comment would be easily distinguishable from any undeclared block 
comments.

> I also think that turning the comments on/off would be very useful.  I
> guess it's a matter of being something that is configured within
> template.inc or passed to template.inc from slashTemplate.class (and
> probably set in the config.ini.php file)..

The functionality is controlled via a class variable - 
$filename_comments. This defaults to false to preserve consistent 
functionality with previous versions as well as to provide minimal 
configuration for production sites.

> I'm not sure how you'd make it configurable without something like:
> 	function loadfile($varname, $showComments=true) {
>
> or perhaps another global variable.
>
> I do think the comments should be there by default, but would be 
> awfully
> nice if they could be turned off in a live site.


Layne Weathers