Re: [Phplib-users] Patch to page.inc

[Giancarlo P. <gia...@na...>]

Dr Tarique Sani wrote:
> 
> On Wed, 30 Oct 2002, Giancarlo Pinerolo wrote:
> 
> > Isn't this what is actually in the new auth->check_feature() function?
> > I think this is all in the snapshot already.
> > Joe, Tarique, when are we going to make a new distrib out of the
> > snapshot?
> 
> I think it is ready... ...
> 
> If not anything for a Beta release OR as a Release candidate
> 
> We need people to download it and try it ... ...
>

That's why I say let's put it somewhere more visible, few people are
aware of the snapshots. Let's freeze on something and feed it.

To get the latest fixes (upon *just reading* the 20021022.dev code, as
I cannot test it here), we need to correct the login_if url rewriting 
so that it will keep other GET data in the string. 

Rub Hutt proposed this change I don't know if that works, but..

$HTTP_SERVER_VARS["QUERY_STRING"] = ereg_replace("([?&])" .
$this->urlaction . "=(.)*&*", "\\1",   
$HTTP_SERVER_VARS["QUERY_STRING"]);
$HTTP_SERVER_VARS["QUERY_STRING"] = ereg_replace("[&][&]+", "&",
$HTTP_SERVER_VARS["QUERY_STRING"]);

I can't try it, and don't know if it works, and I don't know why
there's two ereg_replace there. I have  a bad relation with regexp in
general.

I posted my correction recently to Joe, and that could be tried too.

And BTW this change should be applied to the url rewriting in the
session(4) url() function too, when the SID (Example_Session=xyz) is
cleared from the url
 

The other still unclear point is where/how/when the auth_preauth
function should be called in the start() method cascade.

For the rest everything seems a quite stable compromise of choices in
line with the goal of being a drop-in replacement that will also woork
for most existing sites. So for me it's OK as it is.

Gian