Re: [Phplib-users] snapshots available on sf.net

[Joe S. <jo...@cm...>]

On Tue, Oct 08, 2002 at 10:49:32AM +0200, Marko Kaening wrote:
> Hi Joe,
> 
> > A request to please test the snapshots on sf.net:
> > 	http://phplib.sourceforge.net/snapshots/
> 
> I installed this snapshot and it seems to work with my app without
> problems. The only strange behaviour I noticed is that during loading of
> the loginform I get the following PHP notices:
> 
>  [Tue Oct  8 09:53:42 2002] [error] PHP Notice:  Undefined index:
>  username in /usr/local/lib/phplib-0.74.20021007.patches/php/local.inc on
>  line 175
> 
> I use the Challenge_Crypt_Auth class, which nobody seems to have looked at
> with latest changes.
> Here username is used in the sql-select in auth_validatelogin() eventhough
> it's undefined, instead the select should be circumvented if the username
> wasn't defined yet.

Okay corrected.  The select shouldn't even be done if the username isn't 
submitted.

> I wonder whether the formids functionality could be transferred also to
> this class?
> 

A little tweak to the challenge auth provides this functionality.  It 
expires the challenge word after a succeful login.

> 
>  [Tue Oct  8 09:53:42 2002] [error] PHP Notice:  Undefined variable:  sess
>  in /usr/local/lib/phplib-0.74.20021007.patches/php/auth.inc on line 109
> 
> $sess should be global in start_actions()!
> 
> 
>  [Tue Oct  8 10:32:25 2002] [error] PHP Notice:  Undefined property:
>  newid in /usr/local/lib/phplib-0.74.20021007.patches/php/auth.inc on
>  line 110
> 
> Var newid is obviously not created and cannot be used in the same
> function. I use PHP4 sessions in files mode.
> 

Okay, I made php happy, but Gian may just want to change the newid 
conditional.

> 
>  [Tue Oct  8 09:53:42 2002] [error] PHP Notice:  Undefined index:  mode
>  in /usr/local/lib/phplib-0.74.20021007.patches/php/page.inc on line 95
> 
> It should read I guess:
> 
>  $mode=(isset($HTTP_GET_VARS['mode']) ? .....
> 
> 

Gian?

> 
> Otherwise everything seems to work as expected. No further problems up to
> now.
> 
> 

Thanks for the feedback,

Joe

> Good luck,
> Marko