[Phplib-trackers] [ phplib-Bugs-466835 ] small bug in Table::table_row()

[<no...@so...>]

Bugs item #466835, was opened at 2001-10-02 00:16
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=466835&group_id=31885

Category: None
Group: None
>Status: Closed
>Resolution: Rejected
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Richard Archer (richardarcher)
Summary: small bug in Table::table_row()  

Initial Comment:
Lines 475 and 476 of table.inc (version 7.2d) read:

    $d = $this->select_colnames($data);    
    $this->table_row_open($row, $d, $class);    

According to the docs (and the description of table_row_open), the second argument "is for derived 
classes that override this function that want access to the row data for the row about to be opened." In 
reality, table_row_open() receives an array with fieldnames, not a hash with fieldname/value pairs.

Solution:
  o delete line 475
  o replace $d in line 476 with $data

Regards, Peter Fokkinga

----------------------------------------------------------------------

>Comment By: Richard Archer (richardarcher)
Date: 2002-04-25 15:10

Message:
Logged In: YES 
user_id=279311

This is an API change, and would possibly break existing
PHPLIB installations which rely on the existing behaviour.

There is an identical change listed in Patches which 
may be reconsidered for a future release.

----------------------------------------------------------------------

Comment By: Fred Yankowski (fredy)
Date: 2002-01-16 05:47

Message:
Logged In: YES 
user_id=20580

Patch #504000 should fix this problem.


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=466835&group_id=31885