[Phplib-trackers] [ phplib-Bugs-513935 ] local.inc inconsistencies

[<no...@so...>]

Bugs item #513935, was opened at 2002-02-06 12:11
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=513935&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Richard Archer (richardarcher)
Assigned to: Nobody/Anonymous (nobody)
Summary: local.inc inconsistencies

Initial Comment:
Problems reported via email by Christopher Vrooman:

  I noticed a couple of things when I compared the
latest local.inc (v 1.8 
2001/08/29 12:34:47 richardarcher) and local4.inc (v
1.3 2001/09/01 07:09:42 
richardarcher) that are in the PHPLIB CVS:

1.
  in local.inc a check of:
          if ($this->db->num_rows() == 0) {
            return false;
          }
  was added to the classes Example_Challenge_Auth and 
Example_Challenge_Crypt_Auth; however, local4.inc does
not have this check in any of the Auth classes.

2.
  in the Example_Challenge_Crypt_Auth of local4.inc the
new variable "$passenc" was added, but is not used
anywhere in the class, and

3.
  shouldn't the comment from this comment read
something like, ## This provides 
access for "CRCloginform.ihtml" (and if so, then the
same change should be made 
to the stable local.inc v1.8 in the CVS):
if(isset($username)) {
 $this->auth["uname"]=$username; ## This provides
access for "loginform.ihtml"
}



----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=513935&group_id=31885