[Phplib-trackers] [ phplib-Bugs-450749 ] possible prob in session.inc/add_query()

[<no...@so...>]

Bugs item #450749, was opened at 2001-08-14 02:48
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=450749&group_id=31885

Category: None
Group: None
Status: Open
Resolution: None
>Priority: 5
Submitted By: Richard Archer (richardarcher)
>Assigned to: Richard Archer (richardarcher)
Summary: possible prob in session.inc/add_query()

Initial Comment:
reposted from mailing list... 

I really can't see this being a *real* problem after
all this time, but the code hasn't changed so we should
double-check. The logic in that function looks pretty
dodgy to me.

At 11:53 AM +0100 9/2/00, Detlev Wagner wrote:

>The add_query() function produces URLs like
>filename.php3&var1=123&var2=abc when used together
with the purl()
>function while in cookie mode. I think this is caused
by the if-clause
>of the function, which should not read (like now):
>    if ((isset($QUERY_STRING) && ("" != $QUERY_STRING))
>     || ($this->mode == "get")) {
>     ....}
>but:
>    if ((isset($QUERY_STRING) && ("" != $QUERY_STRING)) &&
>(!($this->mode == "cookie"))
>     || ($this->mode == "get")) {
>     ....}
>This doesn't affect the use of the function in get
mode (fallback) and
>it works properly in cookie mode, too.
>phplib version 7.2 used.
>
>Detlev


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=403611&aid=450749&group_id=31885