Menu

#2 artist class ignores mbid

open
nobody
None
5
2010-11-18
2010-11-18
Tim Jones
No

In the Last.fm API spec, the Artist methods can be called with either the 'artist' parameter or the 'mbid' parameter. (The "musicbrainz id".)

However, this library's instantiation of those methods all fail if no 'artist' is provided, regardless of whether an 'mbid' is provided.

Discussion

  • Tim Jones

    Tim Jones - 2010-11-18
    • summary: artist class ignored mbid --> artist class ignores mbid
     
  • Tim Jones

    Tim Jones - 2010-11-18

    Could be fixed by changing these lines
    ~~
    if ( !empty($methodVars['artist']) ) {
    ~~

    To instead read

    ~~
    if ( !(empty($methodVars['artist']) && empty($methodVars['mbid'])) ) {
    ~~

     

Log in to post a comment.