Re: [Phpipam-development] Bug/issues in 1.15.001 regarding assignment of vlans to subnet + masking of password

[Miha P. <mih...@gm...>]

Hi Jonas,

Fixed:
* Mail IP
* IP request loading
* Tag default Used
* Gateway tag

Todo:
* Discovery > Will check. Which OS are you using? 

Partially implemented:
* button for adding new IP address > before I permit adding new IP address I would have to check usage for each subnet without slaves, meaning fetching addresses for each subnet etc which would cause quite more time to load page. I have added button to favourite subnets.

VLAN move is already implemented - clicking on button under vlan administration.


Will look at other two emails tomorrow.

brm

> On 17 Apr 2015, at 10:57, Jonas Hauge Jensen <jh...@na...> wrote:
> 
> Hi Miha,
> 
> Thanks! I can verify that is works as expected :-)
> 
> A couple of others things I have found or thought about:
> 
> * Mails regarding approved IP requests includes faulty data:
> 
> Accept an request for 172.16.10.0/24 and assigns next available
> (172.16.10.3) but assigned address is always shown as "0.0.0.172". Example
> output from email below:
> 
> ----start----
> IP address request172.16.10.3 accepted
> . Subnet 	172.16.10.0/24
> . assigned IP address	0.0.0.172
> . Description 	test
> . Hostname 	test
> . Owner 	
> . Requested from 	XXX
> 
> . Comment (request) 	
> . Admin accept/reject comment 	
> Sent by user Jonas Hauge Jensen at 2015/04/17 10:03
> ----end------
> 
> * IP request from login site keeps showing the "loading progress circle"
> when changing subnet for a request. The actual request is done in the right
> subnet.
> 
> * Disovery script ends up adding ALL IP addresses as online even they
> aren't. When pingcheck comes by the discovered IPs goes into warning and
> then offline status.
> This gave almost 10000 new IP address entries in the database :-)
> 
> I have tried pinging the IPs in question and they do not answer on ping. I
> tried removing all new entries from the DB and they were re-added during
> next discovery which leads me to think it's another bug in the array-code.
> 
> * Not an actual bug but proposed changes to default behaviour:
> ** When adding a new address the default tag is "offline" - I would suggest
> it to be "Used" as this will be the case for most additions. Otherwise make
> it possible to reprioritize the order just like you can reorder the sections
> today.
> ** Change the "Is gateway" field to check box instead of the dropdown. Just
> like the "Ping exclude".
> 
> * Feature request #1: 
> **Add a button just before the "edit subnet" button on the
> /?page=subnets&section=1 which should open the "Add IP address" dialogue for
> the subnet and prefill it with the next available IP. This should make it
> quick to just add an extra IP. This button should also be shown under the
> list of favorite subnets.
> 
> * Feature request #2:
> Make it possible to migrate vlans from one L2-domain to another. This is
> especially needed for people who already have vlans in the system. Currently
> you will have to move these to other L2-domain via direct row updates in the
> database.
> 
> -- 
> Best regards
> 
> Jonas Hauge Jensen
> 
> -----Oprindelig meddelelse-----
> Fra: Miha Petkovsek [mailto:mih...@gm...] 
> Sendt: 16. april 2015 18:40
> Til: Jonas Hauge Jensen
> Cc: php...@li...
> Emne: Re: [Phpipam-development] Bug/issues in 1.15.001 regarding assignment
> of vlans to subnet + masking of password
> 
> Hi, thanks for noticing / reporting.
> 
> * l2 domains should be printed out but there was a small bug, it is fixed
> now.
> * Passwords are also masked, forgot to do it :/
> 
> pushed to svn.
> 
> If you find anything else let me know!
> 
> br, Miha
> 
>> On 16 Apr 2015, at 10:25, Jonas Hauge Jensen <jh...@na...>
> wrote:
>> 
>> Hi,
>> 
>> First of all - thank you for a great product!
>> 
>> We have just upgraded to the latest development release (R521) and 
>> have found a couple of bugs/issues:
>> 
>> Vlan assignment on subnets
>> ---------------------------------------
>> 
>> When you define which vlan a subnet belongs to there are multiple 
>> instances of "+ Add new VLAN" listed. One for each defined L2-domain. 
>> You are not able to see which L2-domain before actually selecting it 
>> and if you select the wrong one and hit cancel, you end up cancelling the
> whole "edit subnet"
>> dialogue instead only the "create vlan dialogue".
>> 
>> I would suggest that the "+ add new VLAN" entry add info about which 
>> L2-domain you would add the vlan to and at the same time also list 
>> L2-domain for already existing vlans in a format like "1234 (name of 
>> vlan) (L2-domain)"
>> 
>> Masking of password for AD/LDAP connections
>> -----------------------------------------------------------------
>> When entering the overview page for authentication methods
>> (/?page=administration&section=authentication-methods) the password  
>> for at least AD authentication is shown in clear text. When trying to 
>> edit, the password is masked.
>> I would suggest the password to be masked in all places. Maybe an 
>> option to unmask in the edit dialogue.
>> 
>> Let me know if anything is unclear.
>> 
>> --
>> Best regards
>> 
>> Jonas Hauge Jensen
>> 
>> 
>> 
>> ----------------------------------------------------------------------
>> -------- BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT 
>> Develop your own process in accordance with the BPMN 2 standard Learn 
>> Process modeling best practices with Bonita BPM through live exercises
>> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- 
>> event?utm_ 
>> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
>> _______________________________________________
>> Phpipam-development mailing list
>> Php...@li...
>> https://lists.sourceforge.net/lists/listinfo/phpipam-development
>