phpicalendar-devel

[PHPiCalendar-DEV] Another version of template.php in CVS (1.68)

[Jim Hu <ji...@ta...>]

David Fallon noticed a bug in the template.php I uploaded last night.   
An all-day event suppresses display of later events that start before  
$cal_time.  It turns out that this was a problem in earlier versions of  
template.php as well.  I've uploaded his solution to CVS as version  
1.68...I had previously uploaded a kludge as 1.67.  This also makes the  
$keys to $this_time_arr consistent between events copied from the  
master array directly and prepended events that start before $cal_time.

See it in action at:

http://dimer.tamu.edu/phpicalendar-2.0a/week.php? 
cal=all_calendars_combined971&getdate=20050504

Try setting the starting times to different times.

Jim Hu

Re: [PHPiCalendar-DEV] Another version of template.php in CVS (1.68)

[Jamin W. C. <jco...@as...>]

On Thu, May 05, 2005 at 02:13:38AM -0500, Jim Hu wrote:
> David Fallon noticed a bug in the template.php I uploaded last night.   
> An all-day event suppresses display of later events that start before  
> $cal_time.  It turns out that this was a problem in earlier versions of  
> template.php as well.  I've uploaded his solution to CVS as version  
> 1.68...I had previously uploaded a kludge as 1.67.  This also makes the  
> $keys to $this_time_arr consistent between events copied from the  
> master array directly and prepended events that start before $cal_time.

Not sure if this should also have corrected the display of events that
span days, but the current CVS is also not displaying items of this
nature properly.  With the current CVS, events that span multiple days
only appear to be displayed on the day they start.

-- 
Jamin W. Collins

This is the typical unix way of doing things: you string together lots
of very specific tools to accomplish larger tasks. -- Vineet Kumar

Re: [PHPiCalendar-DEV] Another version of template.php in CVS (1.68)

[David F. <da...@d2...>]

Hmm, that's odd. I just tried this out, and it seems to render properly. 
I have both an allday event spanning multiple days, and an event that 
went from 10am thursday to 11am sunday. Both seemed to display fine - 
the only "weirdness" was on the day view on friday/sat, the times listed 
for the event were 12:am -> 11am (not the actual start, just the start 
in the day). That's semi-bogus, but I'm not sure what the 'intent' there 
is. If that is a bug, let me know and I'll fix it. It'd also be nice if 
it listed the date for events that ran into other days, so you knew just 
how long it is, but that's how it's worked. Can you post a calendar and 
explain in more detail, so I can fix it?

dave

Jamin W. Collins wrote:
> On Thu, May 05, 2005 at 02:13:38AM -0500, Jim Hu wrote:
> 
>>David Fallon noticed a bug in the template.php I uploaded last night.   
>>An all-day event suppresses display of later events that start before  
>>$cal_time.  It turns out that this was a problem in earlier versions of  
>>template.php as well.  I've uploaded his solution to CVS as version  
>>1.68...I had previously uploaded a kludge as 1.67.  This also makes the  
>>$keys to $this_time_arr consistent between events copied from the  
>>master array directly and prepended events that start before $cal_time.
> 
> 
> Not sure if this should also have corrected the display of events that
> span days, but the current CVS is also not displaying items of this
> nature properly.  With the current CVS, events that span multiple days
> only appear to be displayed on the day they start.
> 

Re: [PHPiCalendar-DEV] Another version of template.php in CVS (1.68)

[Jamin W. C. <jco...@as...>]

On Thu, May 05, 2005 at 10:43:24AM -0700, David Fallon wrote:
> Hmm, that's odd. I just tried this out, and it seems to render properly. 
> I have both an allday event spanning multiple days, and an event that 
> went from 10am thursday to 11am sunday. Both seemed to display fine - 
> the only "weirdness" was on the day view on friday/sat, the times listed 
> for the event were 12:am -> 11am (not the actual start, just the start 
> in the day). That's semi-bogus, but I'm not sure what the 'intent' there 
> is. If that is a bug, let me know and I'll fix it. It'd also be nice if 
> it listed the date for events that ran into other days, so you knew just 
> how long it is, but that's how it's worked. Can you post a calendar and 
> explain in more detail, so I can fix it?

Take a look here:
http://asgardsrealm.net/~jcollins/phpicalendar/

Calendar files are here:
http://asgardsrealm.net/~jcollins/phpicalendar/calendars/Home.ics
http://asgardsrealm.net/~jcollins/phpicalendar/calendars/Work.ics

This seems to be a problem with parsing a file created by Sunbird.  I
tried replicating this using iCal under OS X and was unable to do so.

-- 
Jamin W. Collins

Linux is not The Answer. Yes is the answer. Linux is The Question. - Neo

Re: [PHPiCalendar-DEV] Another version of template.php in CVS (1.68)

[David F. <da...@d2...>]

So, upon further investigation, I found the problem - it specifically 
was when you had multi-day events that ran until $day_start - this 
should have been a problem before anything we did recently w/ 
template.php. $bleed_time is generally broken, and I think I have a 
handle on how to fix - patch forthcoming tomorrow. I also comitted the 
language fix, my first patch! Woo! Please let me know if I've completely 
trashed CVS. :)

dave

Jamin W. Collins wrote:
> On Thu, May 05, 2005 at 10:43:24AM -0700, David Fallon wrote:
> 
>>Hmm, that's odd. I just tried this out, and it seems to render properly. 
>>I have both an allday event spanning multiple days, and an event that 
>>went from 10am thursday to 11am sunday. Both seemed to display fine - 
>>the only "weirdness" was on the day view on friday/sat, the times listed 
>>for the event were 12:am -> 11am (not the actual start, just the start 
>>in the day). That's semi-bogus, but I'm not sure what the 'intent' there 
>>is. If that is a bug, let me know and I'll fix it. It'd also be nice if 
>>it listed the date for events that ran into other days, so you knew just 
>>how long it is, but that's how it's worked. Can you post a calendar and 
>>explain in more detail, so I can fix it?
> 
> 
> Take a look here:
> http://asgardsrealm.net/~jcollins/phpicalendar/
> 
> Calendar files are here:
> http://asgardsrealm.net/~jcollins/phpicalendar/calendars/Home.ics
> http://asgardsrealm.net/~jcollins/phpicalendar/calendars/Work.ics
> 
> This seems to be a problem with parsing a file created by Sunbird.  I
> tried replicating this using iCal under OS X and was unable to do so.
> 

Re: [PHPiCalendar-DEV] Another version of template.php in CVS (1.68)

[David F. <da...@d2...>]

upon further review, the right answer is twofold - I change ical_parser 
to be a little more generous w/ bleed_time, and then I changed the 
default of bleed_time to "off" - '-1'. This is because, as it stands, 
the whole point of bleed_time is to not display multi-day events past 
the first day, if they're before bleed_time. Since the default is 
day_start, any 3 day events that end before bleed_time won't show up, 
and things are working "correctly" in that if you specifically set 
bleed_time to day_start, you'd get what you're looking for. However, 
that's not what the users who don't set bleed_time expect - they expect 
no "filtering" of their events, I think. So, does that make sense? Can 
someone with the know-how buy off on this, and I'll commit the patch? 
Jamin, you can test this by turning bleed_time off - let me know if 
there are still rendering issues when you do that. Attached is a patch 
to do the above, btw.

dave

Jamin W. Collins wrote:
> On Thu, May 05, 2005 at 10:43:24AM -0700, David Fallon wrote:
> 
>>Hmm, that's odd. I just tried this out, and it seems to render properly. 
>>I have both an allday event spanning multiple days, and an event that 
>>went from 10am thursday to 11am sunday. Both seemed to display fine - 
>>the only "weirdness" was on the day view on friday/sat, the times listed 
>>for the event were 12:am -> 11am (not the actual start, just the start 
>>in the day). That's semi-bogus, but I'm not sure what the 'intent' there 
>>is. If that is a bug, let me know and I'll fix it. It'd also be nice if 
>>it listed the date for events that ran into other days, so you knew just 
>>how long it is, but that's how it's worked. Can you post a calendar and 
>>explain in more detail, so I can fix it?
> 
> 
> Take a look here:
> http://asgardsrealm.net/~jcollins/phpicalendar/
> 
> Calendar files are here:
> http://asgardsrealm.net/~jcollins/phpicalendar/calendars/Home.ics
> http://asgardsrealm.net/~jcollins/phpicalendar/calendars/Work.ics
> 
> This seems to be a problem with parsing a file created by Sunbird.  I
> tried replicating this using iCal under OS X and was unable to do so.
>