phpicalendar-devel

[PHPiCalendar-DEV] Is CVS clean ?

[Nicolas C. <nic...@gm...>]

Hi,
Today seemed to be a bad day for me. I've turn my calendars to CVS
version, and many bugs appeared ...

First, a former one :
* This event (For those who doesn't want to click below, it's a
'COUNT' recurring event with 4 deleted items) is displayed COUNT+1
(!!!!) time in every views except year !!!
http://eidolon.univ-lyon2.fr/~nicoconta/phpicalendar/year.php?cal=3Dloop_te=
st&getdate=3D20051215
(calendar contains just this event, and is available at
%BASE%/calendars/loop_event.ics)

* If I display multiple calendars, and use the jumpTo section of the
sidebar (this week, particularly), the calendar list in the URL is
troncated (and the error page is shown, depending on the last element
of the cpath_list).
Example:
Go to my default vue : http://eidolon.univ-lyon2.fr/~nicoconta/phpicalendar=
/
And then select 'Cette semaine' ('This week', for non-french speaking)

This could be a language bug (I haven't test this with really default
config., but I don't this that's so).
I've more daily time to dedicate to dev (until christmas), so if
you've any clue about where to search, it would be great.


Nicolas.

[PHPiCalendar-DEV] PHPiCalendar-2.1 vs. PHP-5.1.1

[<ad...@jp...>]

To All:
	This probably isn't the right place for this -- but there seems to be 
no mailing list devoted to reporting bugs.  Just wanted to know if 
anyone here as upgraded to PHP-5.1.1, and if they're having problems 
with PHPiCalendar-2.1.  Just from doing a little research of my own, it 
appears that PHP-5.1.1 changed the way they handle the strtotime() 
function.  Any thoughts on fixes/patches?


  - Justin Kulikowski
	[ http://www.jpk236.com ]

Re: [PHPiCalendar-DEV] PHPiCalendar-2.1 vs. PHP-5.1.1

[Chad L. <ch...@ch...>]

We use the bug reporting built into sourceforge, no need to mail us  
here -- your report will be received by us there. There is a 5.1.1  
discussion on the website if you'd like to read more.

-Chad

On Dec 14, 2005, at 6:47 PM, ad...@jp... wrote:

> To All:
> 	This probably isn't the right place for this -- but there seems to  
> be no mailing list devoted to reporting bugs.  Just wanted to know  
> if anyone here as upgraded to PHP-5.1.1, and if they're having  
> problems with PHPiCalendar-2.1.  Just from doing a little research  
> of my own, it appears that PHP-5.1.1 changed the way they handle  
> the strtotime() function.  Any thoughts on fixes/patches?
>
>
>  - Justin Kulikowski
> 	[ http://www.jpk236.com ]
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through  
> log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD  
> SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel

Re: [PHPiCalendar-DEV] PHPiCalendar-2.1 vs. PHP-5.1.1

[Nicolas C. <nic...@gm...>]

On 12/15/05, Chad Little <ch...@ch...> wrote:
> We use the bug reporting built into sourceforge, no need to mail us
> here -- your report will be received by us there. There is a 5.1.1
> discussion on the website if you'd like to read more.
>

It seems that more and more people is swithcing to php 5.1.1 :-(

So I've made the change
* in 'date_function.php', by adding 'twoChar2Day()'
* and changing calls in 'ical_parser.php'

Can someone put this
(http://eidolon.univ-lyon2.fr/~nicoconta/diff_files/php511.diff.tgz)
into CVS. or simply make the changes.

Thanks.


Danon'.
Ps: I'll keep working on my loop bug

Re: [PHPiCalendar-DEV] PHPiCalendar-2.1 vs. PHP-5.1.1

[<ad...@jp...>]

Nicolas,
	You need to change a few other things as well to get PHPiCalendar to 
work under PHP-5.1.1:

1.)  in week.php, day.php, year.php, and month.php; you must change 
strtotime("now + $second_offset seconds") to read strtotime("now 
+$second_offset seconds").  The +/- must now be directly adjacent to the 
offset.
2.)  in config.inc.php -- $second_offset must be given a value, even if 
it just is set to '0'.


  - Justin Kulikowski
	[ http://www.jpk236.com ]


Nicolas Contamin wrote:
> On 12/15/05, Chad Little <ch...@ch...> wrote:
> 
>>We use the bug reporting built into sourceforge, no need to mail us
>>here -- your report will be received by us there. There is a 5.1.1
>>discussion on the website if you'd like to read more.
>>
> 
> 
> It seems that more and more people is swithcing to php 5.1.1 :-(
> 
> So I've made the change
> * in 'date_function.php', by adding 'twoChar2Day()'
> * and changing calls in 'ical_parser.php'
> 
> Can someone put this
> (http://eidolon.univ-lyon2.fr/~nicoconta/diff_files/php511.diff.tgz)
> into CVS. or simply make the changes.
> 
> Thanks.
> 
> 
> Danon'.
> Ps: I'll keep working on my loop bug
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> http://ads.osdn.com/?ad_idv37&alloc_id865&op=click
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel

Re: [PHPiCalendar-DEV] PHPiCalendar-2.1 vs. PHP-5.1.1

[Jim Hu <ji...@ta...>]

I thought I had caught these in CVS by replacing

	strtotime("now +$second_offset seconds")

with

	time()+$second_offset

There's no reason to use strings here, guys.
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Jim Hu

On Dec 16, 2005, at 10:46 AM, ad...@jp... wrote:

> Nicolas,
> 	You need to change a few other things as well to get =
PHPiCalendar =20
> to work under PHP-5.1.1:
>
> 1.)  in week.php, day.php, year.php, and month.php; you must change =20=

> strtotime("now + $second_offset seconds") to read strtotime("now +=20
> $second_offset seconds").  The +/- must now be directly adjacent to =20=

> the offset.
> 2.)  in config.inc.php -- $second_offset must be given a value, =20
> even if it just is set to '0'.
>
>
>  - Justin Kulikowski
> 	[ http://www.jpk236.com ]
>
>
> Nicolas Contamin wrote:
>> On 12/15/05, Chad Little <ch...@ch...> wrote:
>>> We use the bug reporting built into sourceforge, no need to mail us
>>> here -- your report will be received by us there. There is a 5.1.1
>>> discussion on the website if you'd like to read more.
>>>
>> It seems that more and more people is swithcing to php 5.1.1 :-(
>> So I've made the change
>> * in 'date_function.php', by adding 'twoChar2Day()'
>> * and changing calls in 'ical_parser.php'
>> Can someone put this
>> (http://eidolon.univ-lyon2.fr/~nicoconta/diff_files/php511.diff.tgz)
>> into CVS. or simply make the changes.
>> Thanks.
>> Danon'.
>> Ps: I'll keep working on my loop bug
>> -------------------------------------------------------
>> This SF.net email is sponsored by: Splunk Inc. Do you grep through =20=

>> log files
>> for problems?  Stop!  Download the new AJAX search engine that makes
>> searching your log files as easy as surfing the  web.  DOWNLOAD =20
>> SPLUNK!
>> http://ads.osdn.com/?ad_idv37&alloc_id=16865&op=3Dclick
>> _______________________________________________
>> Phpicalendar-devel mailing list
>> Php...@li...
>> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through =20
> log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD =20
> SPLUNK!
> http://ads.osdn.com/?ad_id=3D7637&alloc_id=3D16865&op=3Dclick
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel

Re: [PHPiCalendar-DEV] Is CVS clean ?

[Wesley M. <we...@we...>]

On Dec 13, 2005, at 4:50 PM, Nicolas Contamin wrote:
>
> * If I display multiple calendars, and use the jumpTo section of the
> sidebar (this week, particularly), the calendar list in the URL is
> troncated (and the error page is shown, depending on the last element
> of the cpath_list).
> Example:
> Go to my default vue : http://eidolon.univ-lyon2.fr/~nicoconta/ 
> phpicalendar/
> And then select 'Cette semaine' ('This week', for non-french speaking)

Fixed this. list_jumps() was passing in multiple calendar names to  
getCalendarName(), instead of one at a time.
--
Wesley Miaw
we...@we...

Re: [PHPiCalendar-DEV] Is CVS clean ?

[Nicolas C. <nic...@gm...>]

On 12/15/05, Wesley Miaw <we...@we...> wrote:
> Fixed this. list_jumps() was passing in multiple calendar names to
> getCalendarName(), instead of one at a time.

Thanks. That works great!

I've not seen anything about your other request (month/week view).
Would you mind to explain it a bit more ?

--
Nicolas.

Re: [PHPiCalendar-DEV] Is CVS clean ?

[Jim Hu <ji...@ta...>]

I see that this went back to the change in basename I had tried  
before, which I think is better.
With respect to the larger question of CVS cleanliness...I think that  
I'm guilty of not checking all features when I add a patch.    
Sometimes I'm too quick on the uploads late at night!  I'd like to  
hear what others think should be the protocol for feature checking  
before uploads to CVS.  For example,

- I never check the different languages, but
- I'm probably the only one who always checks the directories  
specified by cpath, because I keep all my calendars in subdirectoris.
- But I don't check recursive_path.
- There's no way I can check against the different server configs and  
the different php versions out there...I usually just try to infer  
those issues from the php.net docs.
- I've started putting more and more test calendars on my server for  
things like repeating events.
- Until recently, I didn't check webcals.

Before the push to get 2.2 out, I would make a temporary backup of my  
phpicalendar folder and try stuff on my real install.  This tended to  
identify bugs quickly, since the real installation was driving some  
class webpages via rss (students would email to ask where the reading  
assignments went!)...but that's kind of dangerous.  So now I have 3  
copies on my server.  1 the current CVS.  2. my "real" one. 3. a copy  
that is mangled with things I'm trying.

I feel like I need a better checklist before I upload to CVS...or a  
tester script!
=====================================
Jim Hu


On Dec 14, 2005, at 9:27 PM, Wesley Miaw wrote:

> On Dec 13, 2005, at 4:50 PM, Nicolas Contamin wrote:
>>
>> * If I display multiple calendars, and use the jumpTo section of the
>> sidebar (this week, particularly), the calendar list in the URL is
>> troncated (and the error page is shown, depending on the last element
>> of the cpath_list).
>> Example:
>> Go to my default vue : http://eidolon.univ-lyon2.fr/~nicoconta/ 
>> phpicalendar/
>> And then select 'Cette semaine' ('This week', for non-french  
>> speaking)
>
> Fixed this. list_jumps() was passing in multiple calendar names to  
> getCalendarName(), instead of one at a time.
> --
> Wesley Miaw
> we...@we...
>
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through  
> log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD  
> SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel