Menu
▾
▴
phpicalendar-devel
|
From: Wesley M. <we...@we...> - 2003-09-18 01:33:45
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 In sidebar.php:59, the closing FORM tag is commented out. This results in illegal HTML. I know it gets rid of the extra whitespace that shows up in the navigation sidebar box, but it needs to be included. If you don't want the whitespace to show up, we can move the opening and closing form tags outside the enclosing table, and remove the spacer of height 10 from the bottom. Things will end up looking the same. - -- Wesley Miaw, Wesley Miaw Consulting http://www.wesman.net/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (Darwin) iD8DBQE/aQtyQv4agqRAk2kRAsbpAJwLL68Nv2nD551P5X25SJux66dDuQCeIXrM ZTOnL+V3bqDPOINc/iibvDE= =UZjS -----END PGP SIGNATURE----- |
|
From: Chad L. <ch...@ch...> - 2003-09-18 05:59:01
|
I was trying to decide where I could put that and 1) have it not cause space and 2) be valid. Whatever meets those two things should be fine. Im not going to have time to work on it anymore until saturday. Thanks, C On Wednesday, September 17, 2003, at 06:33 PM, Wesley Miaw wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > In sidebar.php:59, the closing FORM tag is commented out. This results > in illegal HTML. I know it gets rid of the extra whitespace that shows > up in the navigation sidebar box, but it needs to be included. > > If you don't want the whitespace to show up, we can move the opening > and closing form tags outside the enclosing table, and remove the > spacer of height 10 from the bottom. Things will end up looking the > same. > - -- > Wesley Miaw, Wesley Miaw Consulting > http://www.wesman.net/ > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.0.7 (Darwin) > > iD8DBQE/aQtyQv4agqRAk2kRAsbpAJwLL68Nv2nD551P5X25SJux66dDuQCeIXrM > ZTOnL+V3bqDPOINc/iibvDE= > =UZjS > -----END PGP SIGNATURE----- > > > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > Welcome to geek heaven. > http://thinkgeek.com/sf > _______________________________________________ > Phpicalendar-devel mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel |
|
From: Wesley M. <we...@we...> - 2003-09-18 17:43:30
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 1. If I add a margin attribute to the calborder style, then all vertical spacing between boxes will be equal, but this margin pixel value must be at least as large as the space inserted by the closing form tag, unless the second approach is used. 2. If I add an empty <form>...</form> pair of tags around each box, then all vertical spacing will also be equal. The two combined will ensure everything looks right everywhere, regardless of CSS support. Is that the preferred solution? I would say yes, but all those empty form tags are kind of yucky, and maybe PHP iCalendar already states CSS as a requirement, in which case only #1 is technically acceptable. On Thursday, September 18, 2003, at 01:58 AM, Chad Little wrote: > I was trying to decide where I could put that and 1) have it not cause > space and 2) be valid. Whatever meets those two things should be fine. > Im not going to have time to work on it anymore until saturday. > > On Wednesday, September 17, 2003, at 06:33 PM, Wesley Miaw wrote: > >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> In sidebar.php:59, the closing FORM tag is commented out. This >> results in illegal HTML. I know it gets rid of the extra whitespace >> that shows up in the navigation sidebar box, but it needs to be >> included. >> >> If you don't want the whitespace to show up, we can move the opening >> and closing form tags outside the enclosing table, and remove the >> spacer of height 10 from the bottom. Things will end up looking the >> same. - -- Wesley Miaw, Wesley Miaw Consulting http://www.wesman.net/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (Darwin) iD8DBQE/ae68Qv4agqRAk2kRAveeAJ9t/c0iZRCRWklKostAychQWV7YxQCfbW8L l8UU/Nzh0cOnzHvb3T8+hNQ= =P/yR -----END PGP SIGNATURE----- |
|
From: Patrick C. <pa...@iC...> - 2003-09-24 14:15:55
|
One question for both of you... Isn't the 2nd form tag (on $display_custom_goto -- line 63) unnecessary? Both forms are pointing to the same spot. Best, Patrick Crowley Creator, iCalShare iCalShare - Share Your iCalendars! http://iCalShare.com |
|
From: Wesley M. <we...@we...> - 2003-09-24 16:11:02
|
Hi Patrick, > Isn't the 2nd form tag (on $display_custom_goto -- line 63) > unnecessary? > Both forms are pointing to the same spot. I'll check on this. I may have introduced an extra form when I was modifying the code. -- Wesley Miaw, Wesley Miaw Consulting http://www.wesman.net/ |
|
From: Wesley M. <we...@we...> - 2003-09-24 16:26:00
|
Hi Patrick, > Isn't the 2nd form tag (on $display_custom_goto -- line 63) > unnecessary? > Both forms are pointing to the same spot. I see Chad made the form tag modifications more elegant on sidebar.php. The second form tag inside $display_custom_goto is necessary because the $search_box might be echoed right before the custom goto. $search_box uses a form that points at search.php instead of day.php. -- Wesley Miaw, Wesley Miaw Consulting http://www.wesman.net/ |
|
From: Patrick C. <pa...@iC...> - 2003-09-24 17:16:18
|
Let's just push the $search_box below the custom_goto then. That way, we can avoid any potential overlap (and remove the need for a double form tag). Simplicity is good. :) I just did this in my copy and it looks fine. I'll check it in later if you guys have no objection. Best, Patrick Crowley Creator, iCalShare iCalShare - Share Your iCalendars! http://iCalShare.com > I see Chad made the form tag modifications more elegant on sidebar.php. > The second form tag inside $display_custom_goto is necessary because > the $search_box might be echoed right before the custom goto. > $search_box uses a form that points at search.php instead of day.php. |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X