While working on some other stuff, found a bug in the day & week display:
My $day_start is set to 0800. I have a calendar w/ 2 events, 1 from 6am
- 5pm, and the other from 8am - 7pm. The exact times don't matter, other
than that there's a event that starts at $day_start, and an event that
starts before $day_start. The bug was the events I just described be
shown in the wrong order, the 8am one first and the 6am one second. This
was due to how the $this_time_arr was being built - it was appending
instead of building the events and prepending (you couldn't just always
prepend, because then if there were multiple events before $day_start,
you'd get them in reverse order). Should be relatively self-explanatory.
Files attached:
bug_example.ics - demo ics that shows this.
bug.patch - diff -u against latest cvs.
Still waiting to hear about the right way to do this (i.e., what will
get someone with cvs access to review/commit - I will happily mail
floppys if that's what it takes. ;)), but figured given the trivial
nature of the patches, this wouldn't be too bad.
dave
|