phpicalendar-devel Mailing List for PHP iCalendar (Page 8)

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Checked in the login button.
--
Wesley Miaw
we...@we...

2006/1/12, Wesley Miaw <we...@we...>:
> I think we're good, although I never incorporated those French language
> changes because I wasn't sure they were all correct, and didn't get any
> answer with regard to why those changes were made.

Doesn't matter.
Modifcations I've made, was to best fit each text field. I'm not a
grammar expert althought I'm french. So just keep your translation,
and go on.

> One other change which I think we might want to put in is a Login
> button into the login area, as it seems there are many browsers that
> don't support Enter which I wasn't aware of. Think this is a good idea?

I vote for!

By the way the 2.2 version fill the 'Quoted-printable' option, that
iCal (and the v2.1) doesn't!

(Ex:
The original (restricted server conf, so use of 'quoted-printable'
text option) : http://chronos.epita.net/week.php?cal=3DSIGL&getdate=3D20060=
110
The calendar in v2.1 :
http://eidolon.univ-lyon2.fr/~nicoconta/phpicalendar/week.php?cal=3DSIGL&ge=
tdate=3D20060110
The calendar in v2.2 :
http://serveur.mokuhi.com/cal/week.php?cal=3DSIGL&getdate=3D20060110)

Danon'.
--
I'm a poor and lonesome Yaourt... (Air connu)

I think we should go for it.  I'm sure we haven't squashed every bug,  
but I'm also sure that we got a lot since 2.1.  If nothing else, it  
would be nice to have all the things that arise be relative to where  
we are now.

Jim
=====================================
Jim Hu

On Jan 11, 2006, at 3:35 PM, Chad Little wrote:

> So is 2.2 ready to ship? Seems like we should get a release out  
> this month.
>
> -C
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through  
> log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD  
> SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel

I think we're good, although I never incorporated those French language 
changes because I wasn't sure they were all correct, and didn't get any 
answer with regard to why those changes were made.

One other change which I think we might want to put in is a Login 
button into the login area, as it seems there are many browsers that 
don't support Enter which I wasn't aware of. Think this is a good idea?

Quoting Chad Little <ch...@ch...>:

> So is 2.2 ready to ship? Seems like we should get a release out this  month.
-- 
Wesley Miaw
http://www.wesman.net/

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

So is 2.2 ready to ship? Seems like we should get a release out this  
month.

-C

Did something change? I didn't update from CVS but now my calendars  
are showing correctly in month and year view. ???

On Dec 28, 2005, at 1:26 PM, Jim Hu wrote:

> Wesley,
>
> Someone on the bbs just reported the same problem. Did you figure  
> it out?
>
> =====================================
> Jim Hu
>
> On Dec 14, 2005, at 9:34 PM, Wesley Miaw wrote:
>
>> For some reason, when I visit month.php or year.php, no calendar  
>> is displayed. Is anyone else having this problem?

--
Wesley Miaw
we...@we...

Wesley,

Someone on the bbs just reported the same problem. Did you figure it  
out?

=====================================
Jim Hu

On Dec 14, 2005, at 9:34 PM, Wesley Miaw wrote:

> For some reason, when I visit month.php or year.php, no calendar is  
> displayed. Is anyone else having this problem?
> --
> Wesley Miaw
> we...@we...
>
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through  
> log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD  
> SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel

I thought I had caught these in CVS by replacing

	strtotime("now +$second_offset seconds")

with

	time()+$second_offset

There's no reason to use strings here, guys.
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Jim Hu

On Dec 16, 2005, at 10:46 AM, ad...@jp... wrote:

> Nicolas,
> 	You need to change a few other things as well to get =
PHPiCalendar =20
> to work under PHP-5.1.1:
>
> 1.)  in week.php, day.php, year.php, and month.php; you must change =20=

> strtotime("now + $second_offset seconds") to read strtotime("now +=20
> $second_offset seconds").  The +/- must now be directly adjacent to =20=

> the offset.
> 2.)  in config.inc.php -- $second_offset must be given a value, =20
> even if it just is set to '0'.
>
>
>  - Justin Kulikowski
> 	[ http://www.jpk236.com ]
>
>
> Nicolas Contamin wrote:
>> On 12/15/05, Chad Little <ch...@ch...> wrote:
>>> We use the bug reporting built into sourceforge, no need to mail us
>>> here -- your report will be received by us there. There is a 5.1.1
>>> discussion on the website if you'd like to read more.
>>>
>> It seems that more and more people is swithcing to php 5.1.1 :-(
>> So I've made the change
>> * in 'date_function.php', by adding 'twoChar2Day()'
>> * and changing calls in 'ical_parser.php'
>> Can someone put this
>> (http://eidolon.univ-lyon2.fr/~nicoconta/diff_files/php511.diff.tgz)
>> into CVS. or simply make the changes.
>> Thanks.
>> Danon'.
>> Ps: I'll keep working on my loop bug
>> -------------------------------------------------------
>> This SF.net email is sponsored by: Splunk Inc. Do you grep through =20=

>> log files
>> for problems?  Stop!  Download the new AJAX search engine that makes
>> searching your log files as easy as surfing the  web.  DOWNLOAD =20
>> SPLUNK!
>> http://ads.osdn.com/?ad_idv37&alloc_id=16865&op=3Dclick
>> _______________________________________________
>> Phpicalendar-devel mailing list
>> Php...@li...
>> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through =20
> log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD =20
> SPLUNK!
> http://ads.osdn.com/?ad_id=3D7637&alloc_id=3D16865&op=3Dclick
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel

Nicolas,
	You need to change a few other things as well to get PHPiCalendar to 
work under PHP-5.1.1:

1.)  in week.php, day.php, year.php, and month.php; you must change 
strtotime("now + $second_offset seconds") to read strtotime("now 
+$second_offset seconds").  The +/- must now be directly adjacent to the 
offset.
2.)  in config.inc.php -- $second_offset must be given a value, even if 
it just is set to '0'.

  - Justin Kulikowski
	[ http://www.jpk236.com ]

Nicolas Contamin wrote:
> On 12/15/05, Chad Little <ch...@ch...> wrote:
> 
>>We use the bug reporting built into sourceforge, no need to mail us
>>here -- your report will be received by us there. There is a 5.1.1
>>discussion on the website if you'd like to read more.
>>
> 
> 
> It seems that more and more people is swithcing to php 5.1.1 :-(
> 
> So I've made the change
> * in 'date_function.php', by adding 'twoChar2Day()'
> * and changing calls in 'ical_parser.php'
> 
> Can someone put this
> (http://eidolon.univ-lyon2.fr/~nicoconta/diff_files/php511.diff.tgz)
> into CVS. or simply make the changes.
> 
> Thanks.
> 
> 
> Danon'.
> Ps: I'll keep working on my loop bug
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> http://ads.osdn.com/?ad_idv37&alloc_id865&op=click
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel

On 12/15/05, Chad Little <ch...@ch...> wrote:
> We use the bug reporting built into sourceforge, no need to mail us
> here -- your report will be received by us there. There is a 5.1.1
> discussion on the website if you'd like to read more.
>

It seems that more and more people is swithcing to php 5.1.1 :-(

So I've made the change
* in 'date_function.php', by adding 'twoChar2Day()'
* and changing calls in 'ical_parser.php'

Can someone put this
(http://eidolon.univ-lyon2.fr/~nicoconta/diff_files/php511.diff.tgz)
into CVS. or simply make the changes.

Thanks.

Danon'.
Ps: I'll keep working on my loop bug

I see that this went back to the change in basename I had tried  
before, which I think is better.
With respect to the larger question of CVS cleanliness...I think that  
I'm guilty of not checking all features when I add a patch.    
Sometimes I'm too quick on the uploads late at night!  I'd like to  
hear what others think should be the protocol for feature checking  
before uploads to CVS.  For example,

- I never check the different languages, but
- I'm probably the only one who always checks the directories  
specified by cpath, because I keep all my calendars in subdirectoris.
- But I don't check recursive_path.
- There's no way I can check against the different server configs and  
the different php versions out there...I usually just try to infer  
those issues from the php.net docs.
- I've started putting more and more test calendars on my server for  
things like repeating events.
- Until recently, I didn't check webcals.

Before the push to get 2.2 out, I would make a temporary backup of my  
phpicalendar folder and try stuff on my real install.  This tended to  
identify bugs quickly, since the real installation was driving some  
class webpages via rss (students would email to ask where the reading  
assignments went!)...but that's kind of dangerous.  So now I have 3  
copies on my server.  1 the current CVS.  2. my "real" one. 3. a copy  
that is mangled with things I'm trying.

I feel like I need a better checklist before I upload to CVS...or a  
tester script!
=====================================
Jim Hu

On Dec 14, 2005, at 9:27 PM, Wesley Miaw wrote:

> On Dec 13, 2005, at 4:50 PM, Nicolas Contamin wrote:
>>
>> * If I display multiple calendars, and use the jumpTo section of the
>> sidebar (this week, particularly), the calendar list in the URL is
>> troncated (and the error page is shown, depending on the last element
>> of the cpath_list).
>> Example:
>> Go to my default vue : http://eidolon.univ-lyon2.fr/~nicoconta/ 
>> phpicalendar/
>> And then select 'Cette semaine' ('This week', for non-french  
>> speaking)
>
> Fixed this. list_jumps() was passing in multiple calendar names to  
> getCalendarName(), instead of one at a time.
> --
> Wesley Miaw
> we...@we...
>
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through  
> log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD  
> SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel

no...I haven't had a chance to try to repeat danon's problems yet,  
though.
=====================================
Jim Hu
Associate Professor and Associate Head for Graduate Programs
Dept. of Biochemistry and Biophysics
2128 TAMU
Texas A&M Univ.
College Station, TX 77843-2128
979-862-4054

On Dec 14, 2005, at 9:34 PM, Wesley Miaw wrote:

> For some reason, when I visit month.php or year.php, no calendar is  
> displayed. Is anyone else having this problem?
> --
> Wesley Miaw
> we...@we...
>
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through  
> log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD  
> SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel

On 12/15/05, Wesley Miaw <we...@we...> wrote:
> Fixed this. list_jumps() was passing in multiple calendar names to
> getCalendarName(), instead of one at a time.

Thanks. That works great!

I've not seen anything about your other request (month/week view).
Would you mind to explain it a bit more ?

--
Nicolas.

For some reason, when I visit month.php or year.php, no calendar is  
displayed. Is anyone else having this problem?
--
Wesley Miaw
we...@we...

On Dec 13, 2005, at 4:50 PM, Nicolas Contamin wrote:
>
> * If I display multiple calendars, and use the jumpTo section of the
> sidebar (this week, particularly), the calendar list in the URL is
> troncated (and the error page is shown, depending on the last element
> of the cpath_list).
> Example:
> Go to my default vue : http://eidolon.univ-lyon2.fr/~nicoconta/ 
> phpicalendar/
> And then select 'Cette semaine' ('This week', for non-french speaking)

Fixed this. list_jumps() was passing in multiple calendar names to  
getCalendarName(), instead of one at a time.
--
Wesley Miaw
we...@we...

We use the bug reporting built into sourceforge, no need to mail us  
here -- your report will be received by us there. There is a 5.1.1  
discussion on the website if you'd like to read more.

-Chad

On Dec 14, 2005, at 6:47 PM, ad...@jp... wrote:

> To All:
> 	This probably isn't the right place for this -- but there seems to  
> be no mailing list devoted to reporting bugs.  Just wanted to know  
> if anyone here as upgraded to PHP-5.1.1, and if they're having  
> problems with PHPiCalendar-2.1.  Just from doing a little research  
> of my own, it appears that PHP-5.1.1 changed the way they handle  
> the strtotime() function.  Any thoughts on fixes/patches?
>
>
>  - Justin Kulikowski
> 	[ http://www.jpk236.com ]
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through  
> log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD  
> SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel

To All:
	This probably isn't the right place for this -- but there seems to be 
no mailing list devoted to reporting bugs.  Just wanted to know if 
anyone here as upgraded to PHP-5.1.1, and if they're having problems 
with PHPiCalendar-2.1.  Just from doing a little research of my own, it 
appears that PHP-5.1.1 changed the way they handle the strtotime() 
function.  Any thoughts on fixes/patches?

  - Justin Kulikowski
	[ http://www.jpk236.com ]

Hi,
Today seemed to be a bad day for me. I've turn my calendars to CVS
version, and many bugs appeared ...

First, a former one :
* This event (For those who doesn't want to click below, it's a
'COUNT' recurring event with 4 deleted items) is displayed COUNT+1
(!!!!) time in every views except year !!!
http://eidolon.univ-lyon2.fr/~nicoconta/phpicalendar/year.php?cal=3Dloop_te=
st&getdate=3D20051215
(calendar contains just this event, and is available at
%BASE%/calendars/loop_event.ics)

* If I display multiple calendars, and use the jumpTo section of the
sidebar (this week, particularly), the calendar list in the URL is
troncated (and the error page is shown, depending on the last element
of the cpath_list).
Example:
Go to my default vue : http://eidolon.univ-lyon2.fr/~nicoconta/phpicalendar=
/
And then select 'Cette semaine' ('This week', for non-french speaking)

This could be a language bug (I haven't test this with really default
config., but I don't this that's so).
I've more daily time to dedicate to dev (until christmas), so if
you've any clue about where to search, it would be great.

Nicolas.

On 12/13/05, Jim Hu <ji...@ta...> wrote:
> In the last email I suggested that the problem is in:
>
>       $byday[] =3D strtoupper(substr($daysofweekshort_lang[date('w',
> $start_date_time)], 0, 2));
>
> The goal is to get the english 3 letter codes in, since those are what is
> otherwise pulled from the .ics, right?

Right.

> So...I think this should work:
>
>       $byday[] =3D strtoupper(date('D', $start_date_time));

That's good, but you also have to erase the line 520 :
'$day =3D  two2threeCharDays($day);'

Danon'.
note: That doesn't resolve the 'php 5.1.1' bug mentionned on the bbs
(http://www.phpicalendar.net/forums/viewtopic.php?t=3D325).
--
I'm a poor and lonesome Yaourt... (Air connu)

In the last email I suggested that the problem is in:

      $byday[] =3D strtoupper(substr($daysofweekshort_lang[date('w', =20
$start_date_time)], 0, 2));

OK, in English, this line loads the $byday array with SUN, MON, TUE, =20
WED etc.
date(w,$start_date_time) gives a number for the day of the week, 0-6, =20=

where 0=3DSunday, 1=3DMonday etc.
$daysofweekshort_lang[0-6] in French takes its value from array =20
('Dimanche','Lundi','Mardi','Mercredi','Jeudi','Vendredi','Samedi')
substr trims to 3 letters, and then all hell breaks loose.  The goal =20
is to get the english 3 letter codes in, since those are what is =20
otherwise pulled from the .ics, right?

So...I think this should work:

      $byday[] =3D strtoupper(date('D', $start_date_time));

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Jim Hu

On Dec 12, 2005, at 6:26 PM, Nicolas Contamin wrote:

> Hi,
>
> I've just found something totally crazy.
> I've not yet solved the problem, I can't find a way to handle it.
>
> A teacher made reccuring event ending with a 'UNTIL' date.
> The english version displays it allright
> http://eidolon.univ-lyon2.fr/~nicoconta/calendrier/week.php?=20
> cal=3DMASTER&getdate=3D20060207
>
> but the french (and for the most danish, and dutch) one doesn't
> http://eidolon.univ-lyon2.fr/~nicoconta/phpicalendar-2.1/week.php?=20
> cal=3DMASTER2&getdate=3D20060207
>
> (I've changed the calendar's name for them not to be parsed in the
> same '/tmp' file)
> Have you ever seen something like that (I've tried every config
> variable, and the bug is language related) ?
>
> I'll scan the /tmp files, tomorrow and keep you informed, but if you
> have any advice about where to look at, it'll be helpfull.
>
>
> Nicolas.
> Ps: Even if my example use v2.1, the bug is also in the CVS version.
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through =20
> log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD =20
> SPLUNK!
> http://ads.osdn.com/?ad_idv37&alloc_id=16865&op=3Dclick
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel

I'm betting on line 515 in ical_parser.php:

$byday[] =3D strtoupper(substr($daysofweekshort_lang[date('w', =20
$start_date_time)], 0, 2));

This probably causes two2threeCharDays($day) on line 519 to return =20
undef.

Line numbers refer to CVS.  Need to think about the solution...
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Jim Hu

On Dec 12, 2005, at 6:26 PM, Nicolas Contamin wrote:

> Hi,
>
> I've just found something totally crazy.
> I've not yet solved the problem, I can't find a way to handle it.
>
> A teacher made reccuring event ending with a 'UNTIL' date.
> The english version displays it allright
> http://eidolon.univ-lyon2.fr/~nicoconta/calendrier/week.php?=20
> cal=3DMASTER&getdate=3D20060207
>
> but the french (and for the most danish, and dutch) one doesn't
> http://eidolon.univ-lyon2.fr/~nicoconta/phpicalendar-2.1/week.php?=20
> cal=3DMASTER2&getdate=3D20060207
>
> (I've changed the calendar's name for them not to be parsed in the
> same '/tmp' file)
> Have you ever seen something like that (I've tried every config
> variable, and the bug is language related) ?
>
> I'll scan the /tmp files, tomorrow and keep you informed, but if you
> have any advice about where to look at, it'll be helpfull.
>
>
> Nicolas.
> Ps: Even if my example use v2.1, the bug is also in the CVS version.
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through =20
> log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD =20
> SPLUNK!
> http://ads.osdn.com/?ad_idv37&alloc_id=16865&op=3Dclick
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel

Hi,

I've just found something totally crazy.
I've not yet solved the problem, I can't find a way to handle it.

A teacher made reccuring event ending with a 'UNTIL' date.
The english version displays it allright
http://eidolon.univ-lyon2.fr/~nicoconta/calendrier/week.php?cal=3DMASTER&ge=
tdate=3D20060207

but the french (and for the most danish, and dutch) one doesn't
http://eidolon.univ-lyon2.fr/~nicoconta/phpicalendar-2.1/week.php?cal=3DMAS=
TER2&getdate=3D20060207

(I've changed the calendar's name for them not to be parsed in the
same '/tmp' file)
Have you ever seen something like that (I've tried every config
variable, and the bug is language related) ?

I'll scan the /tmp files, tomorrow and keep you informed, but if you
have any advice about where to look at, it'll be helpfull.

Nicolas.
Ps: Even if my example use v2.1, the bug is also in the CVS version.

It causes repeating events set to repeat every 2 weeks to get out of  
synch.  So...something is broke.  The question is whether that's the  
place to fix or if there's somewhere else in the parser.
=====================================
Jim Hu

On Dec 9, 2005, at 6:33 PM, Chad Little wrote:

> Basically if it isn't broke.... don't fix it. I often find code I  
> wonder why its there, remove it, then a few months later it bites  
> in the ass. I can't recall why that code might be in there. I'd  
> have to search CVS to see.
>
> Let me know when 2.2 is done, sounds like its about ready. I'll do  
> all the release work for it.
>
> -Chad
>
> On Dec 6, 2005, at 5:16 PM, Jim Hu wrote:
>
>> Anyone get a chance to look at this yet?
>>
>> Jim
>>
>>> Message: 1
>>> To: php...@li...
>>> From: Jim Hu <ji...@ta...>
>>> Date: Sat, 3 Dec 2005 01:16:16 -0600
>>> Subject: [PHPiCalendar-DEV] Another repeat issue - what's this for?
>>> Reply-To: php...@li...
>>>
>>> This is in the case 'WEEKLY' part of ical_parser.php.
>>>
>>> // Since this renders events from $next_range_time to
>>> $next_range_time + 1 week, I need to handle intervals
>>> // as well. This checks to see if $next_date_time is after  
>>> $day_start
>>> (i.e., "next week"), and thus
>>> // if we need to add $interval weeks to $next_date_time.
>>> if ($next_date_time > strtotime($week_start_day,  
>>> $next_range_time) &&
>>> $interval > 1) {
>>>   	$next_date_time = strtotime('+'.($interval - 1).' '.$freq_type,
>>> $next_date_time);
>>> }
>>>
>>> This appears to be the cause of a bug reported on the bbs, where
>>> events that repeat every 2 weeks gain a week in successive months.
>>> Commenting it out seems to fix that bug, and my test calendar works
>>> with repeats of 1, 2, 3, 4, and 5 weeks.  But presumably the code  
>>> was
>>> put in the parser for a reason.  Or is it now redundant with
>>> something else? $next_range_time must be bumped by $interval  
>>> elsewhere.
>>>
>>> This has NOT been added to CVS, but the patch is noted on the bbs.
>>> =====================================
>>> Jim Hu
>>
>>
>> =====================================
>> Jim Hu
>> Associate Professor and Associate Head for Graduate Programs
>> Dept. of Biochemistry and Biophysics
>> 2128 TAMU
>> Texas A&M Univ.
>> College Station, TX 77843-2128
>> 979-862-4054
>>
>>
>>
>> -------------------------------------------------------
>> This SF.net email is sponsored by: Splunk Inc. Do you grep through  
>> log files
>> for problems?  Stop!  Download the new AJAX search engine that makes
>> searching your log files as easy as surfing the  web.  DOWNLOAD  
>> SPLUNK!
>> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
>> _______________________________________________
>> Phpicalendar-devel mailing list
>> Php...@li...
>> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through  
> log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD  
> SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel

Basically if it isn't broke.... don't fix it. I often find code I  
wonder why its there, remove it, then a few months later it bites in  
the ass. I can't recall why that code might be in there. I'd have to  
search CVS to see.

Let me know when 2.2 is done, sounds like its about ready. I'll do  
all the release work for it.

-Chad

On Dec 6, 2005, at 5:16 PM, Jim Hu wrote:

> Anyone get a chance to look at this yet?
>
> Jim
>
>> Message: 1
>> To: php...@li...
>> From: Jim Hu <ji...@ta...>
>> Date: Sat, 3 Dec 2005 01:16:16 -0600
>> Subject: [PHPiCalendar-DEV] Another repeat issue - what's this for?
>> Reply-To: php...@li...
>>
>> This is in the case 'WEEKLY' part of ical_parser.php.
>>
>> // Since this renders events from $next_range_time to
>> $next_range_time + 1 week, I need to handle intervals
>> // as well. This checks to see if $next_date_time is after $day_start
>> (i.e., "next week"), and thus
>> // if we need to add $interval weeks to $next_date_time.
>> if ($next_date_time > strtotime($week_start_day, $next_range_time) &&
>> $interval > 1) {
>>   	$next_date_time = strtotime('+'.($interval - 1).' '.$freq_type,
>> $next_date_time);
>> }
>>
>> This appears to be the cause of a bug reported on the bbs, where
>> events that repeat every 2 weeks gain a week in successive months.
>> Commenting it out seems to fix that bug, and my test calendar works
>> with repeats of 1, 2, 3, 4, and 5 weeks.  But presumably the code was
>> put in the parser for a reason.  Or is it now redundant with
>> something else? $next_range_time must be bumped by $interval  
>> elsewhere.
>>
>> This has NOT been added to CVS, but the patch is noted on the bbs.
>> =====================================
>> Jim Hu
>
>
> =====================================
> Jim Hu
> Associate Professor and Associate Head for Graduate Programs
> Dept. of Biochemistry and Biophysics
> 2128 TAMU
> Texas A&M Univ.
> College Station, TX 77843-2128
> 979-862-4054
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through  
> log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD  
> SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel

Hi just looked at it briefly, but I don't know why it was originally  
put in.

On Dec 6, 2005, at 5:16 PM, Jim Hu wrote:

> Anyone get a chance to look at this yet?
>
> Jim
>
>> Message: 1
>> To: php...@li...
>> From: Jim Hu <ji...@ta...>
>> Date: Sat, 3 Dec 2005 01:16:16 -0600
>> Subject: [PHPiCalendar-DEV] Another repeat issue - what's this for?
>> Reply-To: php...@li...
>>
>> This is in the case 'WEEKLY' part of ical_parser.php.
>>
>> // Since this renders events from $next_range_time to
>> $next_range_time + 1 week, I need to handle intervals
>> // as well. This checks to see if $next_date_time is after $day_start
>> (i.e., "next week"), and thus
>> // if we need to add $interval weeks to $next_date_time.
>> if ($next_date_time > strtotime($week_start_day, $next_range_time) &&
>> $interval > 1) {
>>   	$next_date_time = strtotime('+'.($interval - 1).' '.$freq_type,
>> $next_date_time);
>> }
>>
>> This appears to be the cause of a bug reported on the bbs, where
>> events that repeat every 2 weeks gain a week in successive months.
>> Commenting it out seems to fix that bug, and my test calendar works
>> with repeats of 1, 2, 3, 4, and 5 weeks.  But presumably the code was
>> put in the parser for a reason.  Or is it now redundant with
>> something else? $next_range_time must be bumped by $interval  
>> elsewhere.
>>
>> This has NOT been added to CVS, but the patch is noted on the bbs.
>> =====================================
>> Jim Hu
>
>
> =====================================
> Jim Hu
> Associate Professor and Associate Head for Graduate Programs
> Dept. of Biochemistry and Biophysics
> 2128 TAMU
> Texas A&M Univ.
> College Station, TX 77843-2128
> 979-862-4054
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through  
> log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD  
> SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel

--
Wesley Miaw
we...@we...

2002	Jan	Feb	Mar	Apr	May	Jun	Jul	Aug	Sep (5)	Oct (159)	Nov (123)	Dec (27)
2003	Jan (6)	Feb (11)	Mar (21)	Apr (29)	May (13)	Jun (2)	Jul (13)	Aug (5)	Sep (14)	Oct (21)	Nov (71)	Dec
2004	Jan (18)	Feb (12)	Mar	Apr (6)	May (29)	Jun (9)	Jul (3)	Aug (4)	Sep (7)	Oct (6)	Nov	Dec (20)
2005	Jan (6)	Feb (27)	Mar (4)	Apr (16)	May (61)	Jun (6)	Jul (4)	Aug (18)	Sep (19)	Oct (5)	Nov (55)	Dec (30)
2006	Jan (11)	Feb (9)	Mar (9)	Apr (26)	May (17)	Jun (3)	Jul (1)	Aug	Sep (20)	Oct	Nov (6)	Dec (9)
2007	Jan	Feb	Mar (5)	Apr	May (8)	Jun (2)	Jul	Aug	Sep	Oct (3)	Nov	Dec
2008	Jan	Feb (17)	Mar (11)	Apr (1)	May	Jun	Jul	Aug	Sep	Oct	Nov	Dec (2)
2009	Jan	Feb	Mar	Apr (4)	May	Jun	Jul	Aug	Sep (7)	Oct	Nov	Dec
2010	Jan	Feb	Mar	Apr	May (1)	Jun	Jul	Aug	Sep	Oct (1)	Nov	Dec (4)
2011	Jan	Feb	Mar	Apr	May	Jun	Jul	Aug	Sep	Oct (1)	Nov	Dec
2015	Jan	Feb	Mar	Apr	May	Jun	Jul	Aug	Sep (2)	Oct	Nov	Dec
2022	Jan	Feb	Mar	Apr (1)	May	Jun	Jul	Aug	Sep	Oct	Nov	Dec

phpicalendar-devel Mailing List for PHP iCalendar (Page 8)

phpicalendar-devel — Mailing list for PHP iCalendar Developers