phpicalendar-commits

[<ze...@us...>]

Update of /cvsroot/phpicalendar/phpicalendar3/functions
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv28801/functions

Modified Files:
	class.Settings.php class.Valarm.php class.Standard.php 
	init.inc.php class.iCalObj.php class.Parser.php 
	class.Vcalendar.php 
Log Message:
 * added a few @todo tags
 * minor whitespace adjustments
 * added basic functionality for language setter method in class.Settings.php

Index: class.Settings.php
===================================================================
RCS file: /cvsroot/phpicalendar/phpicalendar3/functions/class.Settings.php,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** class.Settings.php	9 Apr 2007 13:02:13 -0000	1.2
--- class.Settings.php	2 May 2007 13:41:52 -0000	1.3
***************
*** 8,13 ****
   * @package		
   * @subpackage
-  * @todo	Add methods to: 1) overwrite from config.inc.php; 2) read from 
-  *			cookie; and 3) set cookie
   */
  /**
--- 8,11 ----
***************
*** 16,19 ****
--- 14,25 ----
   * [Optional long description of this class]
   *
+  * @todo	Add methods to override from config.inc.php
+  * @todo	Add methods to get/set cookie
+  * @todo	Consider changing the 'yes/no' Settings to true boolean values
+  * @todo	Consider changing settings that store integers as Strings to
+  *			true ints
+  * @todo	Consider changing the legal values of $this->language to the
+  *			language codes used on the web
+  * 			(see http://babelwiki.babelzilla.org/index.php/Language_codes)
   */
  class Settings {
***************
*** 92,100 ****
  														// but may not be accurate depending on ftp server config.
  		
! 		// Calendar colors
! 		//
! 		// You can increase the number of unique colors by adding additional images (monthdot_n.gif) 
! 		// and in the css file (default.css) classes .alldaybg_n, .eventbg_n and .eventbg2_n
! 		// Colors will repeat from the beginning for calendars past $this->unique_colors (7 by default), with no limit.
  		$this->unique_colors			= '7';
  		$this->blacklisted_cals 		= array();
--- 98,107 ----
  														// but may not be accurate depending on ftp server config.
  		
! 		/* Calendar colors
! 		 *
! 		 * You can increase the number of unique colors by adding additional images (monthdot_n.gif) 
! 		 * and in the css file (default.css) classes .alldaybg_n, .eventbg_n and .eventbg2_n
! 		 * Colors will repeat from the beginning for calendars past $this->unique_colors (7 by default), with no limit.
! 		 */
  		$this->unique_colors			= '7';
  		$this->blacklisted_cals 		= array();
***************
*** 111,117 ****
  	 *
  	 * @access public
  	 */
! 	function setLang() {
! 		
  	}
  
--- 118,125 ----
  	 *
  	 * @access public
+ 	 * @todo	Add a check for legal values for $this->language
  	 */
! 	function setLang($language) {
! 		$this->language = $language;
  	}
  

Index: class.Valarm.php
===================================================================
RCS file: /cvsroot/phpicalendar/phpicalendar3/functions/class.Valarm.php,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** class.Valarm.php	9 Apr 2007 13:02:13 -0000	1.2
--- class.Valarm.php	2 May 2007 13:41:52 -0000	1.3
***************
*** 24,30 ****
  	 * @access public
  	 */
! 	function Valarm() {
! 	
! 	}
  
  } ?>
\ No newline at end of file
--- 24,28 ----
  	 * @access public
  	 */
! 	function Valarm() {}
  
  } ?>
\ No newline at end of file

Index: class.Standard.php
===================================================================
RCS file: /cvsroot/phpicalendar/phpicalendar3/functions/class.Standard.php,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** class.Standard.php	9 Apr 2007 13:02:13 -0000	1.2
--- class.Standard.php	2 May 2007 13:41:52 -0000	1.3
***************
*** 24,30 ****
  	 * @access public
  	 */
! 	function Standard() {
! 	
! 	}
  
  } ?>
\ No newline at end of file
--- 24,28 ----
  	 * @access public
  	 */
! 	function Standard() {}
  
  } ?>
\ No newline at end of file

Index: init.inc.php
===================================================================
RCS file: /cvsroot/phpicalendar/phpicalendar3/functions/init.inc.php,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** init.inc.php	9 Apr 2007 13:02:13 -0000	1.2
--- init.inc.php	2 May 2007 13:41:52 -0000	1.3
***************
*** 9,15 ****
   * @subpackage
   * 
!  * @todo Need to set configurations (paths, languages, templates, behaviors)
!  * @todo calendar list
!  * @todo range of dates to process
   */
  
--- 9,15 ----
   * @subpackage
   * 
!  * @todo	Set configurations: paths, languages, templates, behaviors
!  * @todo	calendar list
!  * @todo	range of dates to process
   */
  

Index: class.iCalObj.php
===================================================================
RCS file: /cvsroot/phpicalendar/phpicalendar3/functions/class.iCalObj.php,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** class.iCalObj.php	9 Apr 2007 13:02:13 -0000	1.2
--- class.iCalObj.php	2 May 2007 13:41:52 -0000	1.3
***************
*** 1,5 ****
  <?php
  /**
!  * Refactoring of the ical parser in phpicalendar to make the code more maintainable
   * 
   * @author
--- 1,6 ----
  <?php
  /**
!  * Refactoring of the ical parser in phpicalendar to make the code more
!  * maintainable.
   * 
   * @author
***************
*** 9,19 ****
   */
  /**
!  * Base class for icalendar objects. Some methods used by all, others only for timed events.
   * 
   * [Optional long description of this class]
   *
!  * @todo Since version3 of this project is OO, is it necessary for this class
!  *		to have the 'Obj' suffix at the end of its name?   
!  *
   */
  class iCalObj {
--- 10,20 ----
   */
  /**
!  * Base class for iCalendar objects. Some methods used by all, others only for
!  * timed events.
   * 
   * [Optional long description of this class]
   *
!  * @todo	Since version3 of this project is "OBJECT-oriented", is it necessary
!  *			for this class to have the 'Obj' suffix at the end of its name?
   */
  class iCalObj {
***************
*** 47,56 ****
  	 * RRULE:FREQ=MONTHLY;BYDAY=MO,TU,WE,TH,FR;BYSETPOS=-1
  	 * 
! 	 * Thus, note that key and value are both complex entities that can have multipart info.
  	 *
  	 * @access public
  	 */
  	function process_line($key, $line) {
! 		echo "\tfeed key= $key line=$line to the object of type ".get_class($this)."\n";
  		
  		switch ($key)
--- 48,59 ----
  	 * RRULE:FREQ=MONTHLY;BYDAY=MO,TU,WE,TH,FR;BYSETPOS=-1
  	 * 
! 	 * Thus, note that key and value are both complex entities.  
! 	 * (They can have multipart info.)
  	 *
  	 * @access public
  	 */
  	function process_line($key, $line) {
! 		echo "\tfeed key= $key line=$line to the object of type ".
! 			get_class($this)."\n";
  		
  		switch ($key)
***************
*** 70,74 ****
  	 */
  	function process_child($obj) {
! 		echo "\t".get_class($this)." object processing child of type ".get_class($obj)."\n";
  		$this->children[] = $obj;
  	}
--- 73,79 ----
  	 */
  	function process_child($obj) {
! 		echo "\t".get_class($this)." object processing child of type ".
! 			get_class($obj)."\n";
! 			
  		$this->children[] = $obj;
  	}

Index: class.Parser.php
===================================================================
RCS file: /cvsroot/phpicalendar/phpicalendar3/functions/class.Parser.php,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** class.Parser.php	9 Apr 2007 13:02:13 -0000	1.2
--- class.Parser.php	2 May 2007 13:41:52 -0000	1.3
***************
*** 58,61 ****
--- 58,62 ----
  	 *
  	 * @access public
+ 	 * @alias process_file
  	 */
  	function process_cal() {

Index: class.Vcalendar.php
===================================================================
RCS file: /cvsroot/phpicalendar/phpicalendar3/functions/class.Vcalendar.php,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** class.Vcalendar.php	9 Apr 2007 13:02:13 -0000	1.2
--- class.Vcalendar.php	2 May 2007 13:41:52 -0000	1.3
***************
*** 24,30 ****
  	 * @access public
  	 */
! 	function Vcalendar() {
! 	
! 	}
  
  } ?>
\ No newline at end of file
--- 24,28 ----
  	 * @access public
  	 */
! 	function Vcalendar() {}
  
  } ?>
\ No newline at end of file