From: Jim Hu <ji...@ta...> - 2005-12-15 16:23:56
|
I see that this went back to the change in basename I had tried before, which I think is better. With respect to the larger question of CVS cleanliness...I think that I'm guilty of not checking all features when I add a patch. Sometimes I'm too quick on the uploads late at night! I'd like to hear what others think should be the protocol for feature checking before uploads to CVS. For example, - I never check the different languages, but - I'm probably the only one who always checks the directories specified by cpath, because I keep all my calendars in subdirectoris. - But I don't check recursive_path. - There's no way I can check against the different server configs and the different php versions out there...I usually just try to infer those issues from the php.net docs. - I've started putting more and more test calendars on my server for things like repeating events. - Until recently, I didn't check webcals. Before the push to get 2.2 out, I would make a temporary backup of my phpicalendar folder and try stuff on my real install. This tended to identify bugs quickly, since the real installation was driving some class webpages via rss (students would email to ask where the reading assignments went!)...but that's kind of dangerous. So now I have 3 copies on my server. 1 the current CVS. 2. my "real" one. 3. a copy that is mangled with things I'm trying. I feel like I need a better checklist before I upload to CVS...or a tester script! ===================================== Jim Hu On Dec 14, 2005, at 9:27 PM, Wesley Miaw wrote: > On Dec 13, 2005, at 4:50 PM, Nicolas Contamin wrote: >> >> * If I display multiple calendars, and use the jumpTo section of the >> sidebar (this week, particularly), the calendar list in the URL is >> troncated (and the error page is shown, depending on the last element >> of the cpath_list). >> Example: >> Go to my default vue : http://eidolon.univ-lyon2.fr/~nicoconta/ >> phpicalendar/ >> And then select 'Cette semaine' ('This week', for non-french >> speaking) > > Fixed this. list_jumps() was passing in multiple calendar names to > getCalendarName(), instead of one at a time. > -- > Wesley Miaw > we...@we... > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. Do you grep through > log files > for problems? Stop! Download the new AJAX search engine that makes > searching your log files as easy as surfing the web. DOWNLOAD > SPLUNK! > http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click > _______________________________________________ > Phpicalendar-devel mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel |