|
From: Wesley M. <we...@we...> - 2005-12-07 01:56:05
|
Hi just looked at it briefly, but I don't know why it was originally
put in.
On Dec 6, 2005, at 5:16 PM, Jim Hu wrote:
> Anyone get a chance to look at this yet?
>
> Jim
>
>> Message: 1
>> To: php...@li...
>> From: Jim Hu <ji...@ta...>
>> Date: Sat, 3 Dec 2005 01:16:16 -0600
>> Subject: [PHPiCalendar-DEV] Another repeat issue - what's this for?
>> Reply-To: php...@li...
>>
>> This is in the case 'WEEKLY' part of ical_parser.php.
>>
>> // Since this renders events from $next_range_time to
>> $next_range_time + 1 week, I need to handle intervals
>> // as well. This checks to see if $next_date_time is after $day_start
>> (i.e., "next week"), and thus
>> // if we need to add $interval weeks to $next_date_time.
>> if ($next_date_time > strtotime($week_start_day, $next_range_time) &&
>> $interval > 1) {
>> $next_date_time = strtotime('+'.($interval - 1).' '.$freq_type,
>> $next_date_time);
>> }
>>
>> This appears to be the cause of a bug reported on the bbs, where
>> events that repeat every 2 weeks gain a week in successive months.
>> Commenting it out seems to fix that bug, and my test calendar works
>> with repeats of 1, 2, 3, 4, and 5 weeks. But presumably the code was
>> put in the parser for a reason. Or is it now redundant with
>> something else? $next_range_time must be bumped by $interval
>> elsewhere.
>>
>> This has NOT been added to CVS, but the patch is noted on the bbs.
>> =====================================
>> Jim Hu
>
>
> =====================================
> Jim Hu
> Associate Professor and Associate Head for Graduate Programs
> Dept. of Biochemistry and Biophysics
> 2128 TAMU
> Texas A&M Univ.
> College Station, TX 77843-2128
> 979-862-4054
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through
> log files
> for problems? Stop! Download the new AJAX search engine that makes
> searching your log files as easy as surfing the web. DOWNLOAD
> SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> Phpicalendar-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpicalendar-devel
--
Wesley Miaw
we...@we...
|