Re: [PHPiCalendar-DEV] Some fixes for preferences

[Wesley M. <we...@we...>]

Hi Jim,

> 2. the usual problems with $cpath.  I added cpath to the cookie,  
> but it is not settable by the user in preferences...it's a hidden  
> parameter for now.

What sort of problems are cpath causing for you?

About the calendar colors, I guess if people have a real use for  
allowing their visitors to choose a color scheme, that's a nice  
feature to have. I'm not sure there's any value in having the CSS be  
dynamically generated if you can't actually enter in your own colors  
in the preferences page though. Seems as though since the choices are  
static, simply making sure the templates contain the right CSS  
references and then having a choice of which CSS page to load would  
serve the same function, and result in less runtime overhead.

I guess I'm just saying that the script to write out your CSS color  
choices is good, but I think it would be better to output to a file  
for inclusion, instead of generating inline CSS every time based on  
the contents of a PHP configuration file.

This would make it easier for people who know CSS but don't know PHP  
(although I'm sure your CSS config file isn't that complicated) and  
remove the code hit, which is quite small to begin with. You could  
also make it so the preference choices are the names of whatever CSS  
files are available in a special directory. This would also ensure  
that no one is confused as to why CSS information is showing up from  
two different sources, instead of one. Well, maybe that's not good  
either, because then you'll be duplicating a lot of common CSS  
definitions.

Is there a precedence order defined for CSS, based on the order in  
which you reference them in the HTML? Maybe that's the best way to  
separate between the shared CSS and the user-specific CSS.

Maybe this doesn't make as much sense, since we're only talking about  
the calendar colors here. But if possible, I think it would be better  
for CSS stuff to not be generated at runtime.

Anyway, those are the thoughts I had on the issue.

Later,
--
Wesley Miaw
we...@we...