Re: [PHPiCalendar-DEV] webcals and array

[Wesley M. <we...@we...>]

Hi Jim,

> When I looked at this yesterday, I found several problems in  
> addition to the array.  In calendar functions, availableCalendars()  
> wasn't passing the webcal in $cal_filelist, and when I forced it  
> to, it has a pathname problem similar to the one I fixed for  
> selecting single webcals in the last upload to the CVS.  What I  
> can't figure out is why...and why this isn't a problem when using  
> the other methods - either all combined or selecting the webcal  
> directly.

Can you try this again using the latest in CVS? Webcals seem to be  
working for me now with the changes I checked in last night.

> I'm getting the feeling that init.inc.php and ical_parser.php are  
> getting complicated because of the way various calls into the  
> system have been added on.  I'm starting to think that a more  
> radical set of changes might be good...but I don't have time to  
> work that out and I don't think this should be done for 2.2.  I'm  
> thinking that better division of labor should be set for the two  
> scripts - init.inc.php should pass enough stuff to the parser so  
> that the parser doesn't care whether one or more calendars were  
> selected or whether any of them is a webcal.  I think this would  
> involve redefining some variables as arrays only, or possibly  
> defining an array of calendar objects where the attributes include  
> where to get the .ics file, the real name, the filemtime, and the  
> tmp, subscribe, download, and rss paths/urls.
>
> But this is just an idea.  Very half-baked at this point.

It's a good idea though. I tried to do some of this with the changes  
I made last night: to abstract away the concepts that need to be  
carried between files. It's quite difficult to process the linear  
procedural code in my head, especially when init.inc.php is dealing  
with the global namespace and any random variable set in there can  
show up anywhere else. I was beating my head against that for a while  
because I wasn't sure what "contract" I needed to maintain with my  
changes to make sure things didn't break elsewhere.

Later,
--
Wesley Miaw
we...@we...