[PHPiCalendar-DEV] webcals and array

[Jim Hu <ji...@ta...>]

Wes (and everyone else),

For some reason my subscription to the dev list is only sending me  
digests, so my responses have been slow...well, that contributes to  
my responses being slow.

> --__--__--
>
> Message: 3
> From: Wesley Miaw <we...@we...>
> Subject: Re: [PHPiCalendar-DEV] 2.2
> Date: Wed, 23 Nov 2005 18:00:03 -0800
> To: php...@li...
> Reply-To: php...@li...
>
> On Nov 23, 2005, at 12:08 AM, Jim Hu wrote:
>>
>> When I try putting a webcal in the config.inc.php, it works in all
>> calendar mode.  But when selecting it as an individual calendar, it
>> crashes the parser (at least on my setup).  I think that there are
>> a number of problems.
>
> I'm not getting a crash here, but it was failing because all
> calendars selected via the multiple-selection box are passed in as an
> array. Working on fixing this.

When I looked at this yesterday, I found several problems in addition  
to the array.  In calendar functions, availableCalendars() wasn't  
passing the webcal in $cal_filelist, and when I forced it to, it has  
a pathname problem similar to the one I fixed for selecting single  
webcals in the last upload to the CVS.  What I can't figure out is  
why...and why this isn't a problem when using the other methods -  
either all combined or selecting the webcal directly.

I'm getting the feeling that init.inc.php and ical_parser.php are  
getting complicated because of the way various calls into the system  
have been added on.  I'm starting to think that a more radical set of  
changes might be good...but I don't have time to work that out and I  
don't think this should be done for 2.2.  I'm thinking that better  
division of labor should be set for the two scripts - init.inc.php  
should pass enough stuff to the parser so that the parser doesn't  
care whether one or more calendars were selected or whether any of  
them is a webcal.  I think this would involve redefining some  
variables as arrays only, or possibly defining an array of calendar  
objects where the attributes include where to get the .ics file, the  
real name, the filemtime, and the tmp, subscribe, download, and rss  
paths/urls.

But this is just an idea.  Very half-baked at this point.

>
>> First, determining the modification time of the webcal using
>> filemtime doesn't work.  I'm not sure if this is important...but
>> there may be unintended consequences
>
> I think you fixed this in ical_parser.php? Around lines 51-52.

That was there before.  Probably Chad's original code.

Happy Thanksgiving, btw.

Jim Hu

>
> Later,
> --
> Wesley Miaw
> we...@we...
>