From: Jim Hu <ji...@ta...> - 2005-11-13 04:32:43
|
Wes, Hmm... appending $cpath should happen after $calendar_path gets reset to "calendars" if blank...but it may have been moved during various revisions. $tmp_dir is also reset because I put subdirectories in the tmp directory to mirror the directory structure of my calendars folder. That way I can find the parsed cals for each one, and I think it was needed to read the saved parsed cals...that was so long ago I forget why I did that. As for $support_ical, I see why I didn't follow you...my XServe is headless! So I never manipulate the iCals directly on the server...doh! Jim p.s. I hope by making the reply plain text instead of rtf I'll get rid of all the junk that's been coming with my replies. On Nov 12, 2005, at 10:11 PM, phpicalendar-devel- re...@li... wrote: <snip> > From: Wesley Miaw <we...@we...> > Subject: Re: [PHPiCalendar-DEV] ics extensions > Date: Sat, 12 Nov 2005 00:21:50 -0800 > To: php...@li... > Reply-To: php...@li... > > Hi Jim, > > I don't think there's anything to read with $support_ical, but the > issue is that with one of the newer versions of iCal, Apple changed > their repository structure. It used to just be a single directory > with a list of Calendar.ics files in it. Now it has become more > database-like (no doubt to support a richer feature set) so there is > a base directory, containing multiple subdirectories of some hashed > name. Inside each of those subdirectories is the corestorage.ics > file, a binary index, and an Info.plist file that contains meta > information. > > So that's what led me to include the two new config globals to > support iCal and recursively search directories. > > I remember seeing that $calendar_path .= "/$cpath" line. It works if > $calendar_path is not empty, but becomes a problem if $calendar_path > = '' in config.inc.php. What's $tmp_dir used for? I'd propose the > following for $cpath: > > if ($_REQUEST['cpath']) { > $cpath = $_REQUEST['cpath']; > if (empty $calendar_path) { > $calendar_path = "."; > } > $calendar_path .= "/$cpath"; > $tmp_dir .= "/$cpath"; > } > > I just checked in the changes we discussed below. Hopefully this will > fix the issues people have run into from my bad checkin earlier. > > Later, > Wes <snip> |