Re: [PHPiCalendar-DEV] code cleanup patch - more fixes

[<da...@d2...>]

> David Fallon wrote:
>
>> 3. I noticed a two  issues with the generation of master_array -
>> first, the recur data wasn't being replicated to each instance of the
>> event, only the first event - so (without iterating through the whole
>> array) there was no good way to get it. So, I fixed that. This raises
>> the size of master_array by a decent amount, so it's questionable, but
>> necessary for me to implement recur details in the event popup.
>
> Ah, that could be really good! I've not been developing phpicalendar but
> I have been using the object the parser generates in conjunction with  a
> modified version of Jim Hu's script which turns it into RSS. I then in
> turn use the customised RSS feed in conjunction with MagpieRSS to
> generate a page of events
> (http://www.catmosearts.co.uk/calendar/events.php).
>
> One problem I came across was that for recurring events, if the RSS feed
> started in the middle of a recurring event, the data regarding the
> recurrence was lost as it only appears in the original occurrence. The
> only way I got round it was a dirty hack which grabs the data from 6
> months in the past to make sure the recurrence data is grabbed. This
> has an obvious flaw but works for my specific needs.
>
> The one thing that I changed in phpicalendar ical parser was to supress
> the formatting of the until date (localizeDate($dateFormat_week,$until)
> I think) because the until date was in a useless format (for my needs)
> and it was more useful for me as a unixtime. This of course meant a
> separate parser for phpicalendar and the rss generator.
>
> Thanks for your work!

Well, it's not in CVS yet, but hopefully this will be more motivation for
someone to sign off on it. :)

If it doesn't make it into 2.0, let me know and I can give you a patch
that does it (it's a fairly small change).

dave