From: David F. <da...@d2...> - 2005-05-06 02:22:06
|
upon further review, the right answer is twofold - I change ical_parser to be a little more generous w/ bleed_time, and then I changed the default of bleed_time to "off" - '-1'. This is because, as it stands, the whole point of bleed_time is to not display multi-day events past the first day, if they're before bleed_time. Since the default is day_start, any 3 day events that end before bleed_time won't show up, and things are working "correctly" in that if you specifically set bleed_time to day_start, you'd get what you're looking for. However, that's not what the users who don't set bleed_time expect - they expect no "filtering" of their events, I think. So, does that make sense? Can someone with the know-how buy off on this, and I'll commit the patch? Jamin, you can test this by turning bleed_time off - let me know if there are still rendering issues when you do that. Attached is a patch to do the above, btw. dave Jamin W. Collins wrote: > On Thu, May 05, 2005 at 10:43:24AM -0700, David Fallon wrote: > >>Hmm, that's odd. I just tried this out, and it seems to render properly. >>I have both an allday event spanning multiple days, and an event that >>went from 10am thursday to 11am sunday. Both seemed to display fine - >>the only "weirdness" was on the day view on friday/sat, the times listed >>for the event were 12:am -> 11am (not the actual start, just the start >>in the day). That's semi-bogus, but I'm not sure what the 'intent' there >>is. If that is a bug, let me know and I'll fix it. It'd also be nice if >>it listed the date for events that ran into other days, so you knew just >>how long it is, but that's how it's worked. Can you post a calendar and >>explain in more detail, so I can fix it? > > > Take a look here: > http://asgardsrealm.net/~jcollins/phpicalendar/ > > Calendar files are here: > http://asgardsrealm.net/~jcollins/phpicalendar/calendars/Home.ics > http://asgardsrealm.net/~jcollins/phpicalendar/calendars/Work.ics > > This seems to be a problem with parsing a file created by Sunbird. I > tried replicating this using iCal under OS X and was unable to do so. > |