Menu

#602 The first incompatibility with php8.0

closed-fixed
None
5
2021-09-15
2021-09-13
No

Hi,
I've found the first incompatibility with PHP8.0 in the code. The error handler is no longer called with error_reporting()==0 when triggered from @ escaped operation. Now it is set to all values of fatal/critical errors so the value must be anded with the $errno value and then compared to zero. I believe it will work also in older PHPs. BTW: 'return true' should be written even in earlier versions.

T.B.

1 Attachments

Discussion

  • Gerry Kroll

    Gerry Kroll - 2021-09-13

    Thank you.

    You must have had fun tracking down this one! I wish the PHP developers would stop trying to fix things thereby making old programs incompatible. Another reason to avoid PHP 8.

    I'll add this correction to the SVN soon.

     
    • Tomasz Babczyński

      Well ;)
      the highlights at the php.net page helped much.
      In fact it is a good idea that fatal errors cannot be ignored, at lest so easily. But we teach students again and again that api must not be even touched after a release of a program was put into community and they never learn it.

       
  • Gerry Kroll

    Gerry Kroll - 2021-09-13
    • assigned_to: Gerry Kroll
     
  • Gerry Kroll

    Gerry Kroll - 2021-09-15
    • status: open --> closed-fixed
     
  • Gerry Kroll

    Gerry Kroll - 2021-09-15

    SVN 7319 incorporates this patch. Thank you.

     

Log in to post a comment.