Menu

#598 Lat/Lon mapping quick-link corrections.

open
None
5
2018-01-02
2018-01-02
David Smart
No

In the individual place entries, if the user enters individual Latitude and Longitude values, some quick-links appear that open a new window in one of a few mapping engines. Multimap was one of those, and is now automatically redirected to bing, but the parameters are not correct for that interface. Teraserver was another quick link, and its APIs have changed as well.

This simple patch provides updates to replace Multimap with bing and correct the terraserver interface.
Additionally, this adds to text records to the help system, for the Latitude and Longitude field. As I don't know the process for translations, I could not add the corresponding help.

1 Attachments

Discussion

  • Gerry Kroll

    Gerry Kroll - 2018-01-02

    David:
    Thank you, and best wishes for the new year.

    Generally, I prefer to receive whole files instead of patches, because it's easier for me. It's also a lot less work for users who wish to incorporate these modifications into their own copy of PhpGedView. They can just unzip the package and then copy it directly to their server's PhpGedView install directory.

    I can easily find out what changes were made by using a file compare program (old file vs. new file).

    I'll have a look at what you posted, and make whatever changes are necessary before submitting the whole works to the SVN repository.

     
  • Gerry Kroll

    Gerry Kroll - 2018-01-02

    David:
    Please try the attached ZIP file. Unzip locally, and then copy to your server into the PhpGedView install directory.

    Your Help text wording was changed, and the missing file "images/bing.png" was added.

    I'm not sure why the alt= and title= strings in the address pointers at lines 2287 to 2290 in "includes/functions/functions_print.php" contain the string " copy;" . This seems useless to me, and should probably be removed.

     
  • Gerry Kroll

    Gerry Kroll - 2018-01-02
    • assigned_to: Gerry Kroll
    • Priority: 1 --> 5
     
  • David Smart

    David Smart - 2018-01-02

    It all looks good - good improvement to the text too. Review and testing confirms it is a good update.

    I do like this bing graphic better (since it is "reversed", it doesn't have the same need for transparency).

    Oh, and agreed on the copyright tag - I would think if anything those should be trademark graphics, not copyright...

     

    Last edit: David Smart 2018-01-02
  • Gerry Kroll

    Gerry Kroll - 2018-01-02

    David:
    Please e-mail me the Bing icon you would like to see used. I'll make it the right size

    gkroll (at) keldine (dot) ca

    I have no problem manipulating images to implement transparency, if that's what's needed.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.