#542 Slight improvement of historical facts + French file

open
nobody
5
2009-08-16
2009-08-16
Jon48
No

Hi,

Find attached a patch with the following features:
- a demo file for French Historical facts, called histo.demo-fr
- an improvement in the way to get the list of historical facts. Depending on the type of facts, it is interesting to have the last one before the birth (to know the current President for instance).
- a quick fix for a bug on historical facts for people still alive: facts did not appear because there is not valid death date to compare with. My fix is to compare the fact date to the current date. Might need to be improved (and to be applied to other add_historical_facts-like functions.

This is just a slight change, and might not necessarily fit to everybody for historical facts management, so do not hesitate to improve it.

Jonathan.

Discussion

  • Jon48

    Jon48 - 2009-08-16

    Historical facts patch

     
  • Jon48

    Jon48 - 2009-08-16

    Hi again,

    Please put on hold this pach. One of my tester have jut reported me a bug, which shows that this improvement actually interfere with the CompareType function.
    I'm going to investigate and let you know when I find a fix.

    Thanks!

    Jonathan

     
  • Gerry Kroll

    Gerry Kroll - 2009-08-16

    It's better to post the entire set of files in ZIP format and organized according to the subdirectory they're in. Try not to use DIFF files.

     

Log in to post a comment.