#473 Xenea theme fixes and cleanup

closed-accepted
5
2008-11-26
2008-04-28
No

I use the Xenea theme on my site, and noticed a couple of CSS errors in the theme.

Specifically, header.html was missing units in one case, and print.css specified an auto padding in several places (which is not allowed).

Also, there were many instances of uppercase element selectors, which would stop working when (if) PGV gets around to properly supporting XHTML.

After that, I went through the whole lot with a fine-toothed comb, optimising CSS rules, fixing other little things, including moving several IE and Mozilla-only styles in style.css to their respective browser-specific files.

It would have been nice to do something about the url() font-family, but I'm not sure exactly how that's being used by PGV.

Attached is a ZIP of the files that I've changed.

Discussion

  • Andrew Gregory

    Andrew Gregory - 2008-04-28

    Updated Xenea theme files

     
  • KosherJava

    KosherJava - 2008-04-28

    Logged In: YES
    user_id=634811
    Originator: NO

    The URL font family is read on the server (it parses the CSS file) only and is used for creating the Circle Diagram.

     
  • Gerry Kroll

    Gerry Kroll - 2008-05-20

    Logged In: YES
    user_id=1198414
    Originator: NO

    Andrew:
    Thank you.

    I agree with many of your changes, BUT: I think that for consistency, all colours expressed as hexadecimal numbers should be 6 digits long. Colour numbers should all be upper-case, again for consistency.

    I'll change that back. Also, I'll use colour names where possible. Thus, #000000 (or #000 as you had it) should be "black", #FFFFFF should be "white", #FF0000 should be "red", #00FF00 should be "green", #0000FF should be "blue".

    There are a few other CSS improvements that you missed.

    Thanks again for doing such a massive clean-up.

     
  • Gerry Kroll

    Gerry Kroll - 2008-05-20
    • assigned_to: nobody --> canajun2eh
     
  • Andrew Gregory

    Andrew Gregory - 2008-05-20

    Logged In: YES
    user_id=785493
    Originator: YES

    Thanks to both of you for the font info and for following this up. Yes, I've probably over-optimised the colours - it's hard to stop once you get going! I'm a bit miffed I missed some improvements :( and look forward to seeing what you've done.

     
  • Gerry Kroll

    Gerry Kroll - 2008-11-26
    • status: open --> closed-accepted
     
  • Gerry Kroll

    Gerry Kroll - 2008-11-26

    The changes are in version 4.1.6

     

Log in to post a comment.