#467 Fix for possible bug in calendar.php (year=>blank)

closed-fixed
5
2008-04-15
2008-03-24
Ruben Stein
No

Hello,

I run pgv in v. 4.1.3. In the calendar I had the problem that with only one year written in the edit-box, no data of this year was shown. Selecting a range instead worked fine, as selecting a month or a day did.

So I read searched the help forum and found this entry:
http://sourceforge.net/forum/message.php?msg_id=4580358

Now I started looking at the code and found something that seems to me like a bug. In line 345 (referring to trunk) ged_date is passed to get_calendar_events though above cal_date is set to fit only this year's events.

I wrote a little patch which works fine with 4.1.3, I don't know if this problem is solved in trunk any other way.

Discussion

  • Ruben Stein

    Ruben Stein - 2008-03-24
    • summary: Possible Bug in calender (year=>blank) --> Fix for possible bug in calendar.php (year=>blank)
     
  • Greg Roach

    Greg Roach - 2008-03-24

    Logged In: YES
    user_id=1466942
    Originator: NO

    By using cal_date instead of ged_date, you are restricting the view to only the first year in the range.

    At the moment, you can enter "1900-1910" into the year box to get all events in this reange. With this patch, you only get events for 1900.

    I can't reproduce the problem (in the SVN/trunk).

     
  • Ruben Stein

    Ruben Stein - 2008-03-24

    Logged In: YES
    user_id=1526091
    Originator: YES

    Sorry - you are right. I wrote another patch for this before but I thought the wrong one would be less invasive. I will attach it and delete the old zip. To answer your question about PHP: Yes, PHP-Version 4.4.6 on my webserver.
    File Added: calendar_yearfix2.zip

     
  • Ruben Stein

    Ruben Stein - 2008-03-24

    diff and calendar.php

     
  • Greg Roach

    Greg Roach - 2008-03-31

    Logged In: YES
    user_id=1466942
    Originator: NO

    A permanent fix has been added to the code, which will be included in release 4.1.4

     
  • Greg Roach

    Greg Roach - 2008-03-31
    • assigned_to: nobody --> fisharebest
    • status: open --> pending-fixed
     
  • SourceForge Robot

    • status: pending-fixed --> closed-fixed
     
  • SourceForge Robot

    Logged In: YES
    user_id=1312539
    Originator: NO

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks