#439 Auto-continue gedcom upload

closed-accepted
5
2008-02-22
2008-01-11
No

Clicking continue to keep a gedcom upload going finally got to be too annoying for me, so I wrote a bit of JS to click the continue button automatically.

At about line 1095 in uploadgedcom.php, right after a </table> and before the following opening <?php, I inserted the following JS:

<script type="text/javascript"><!--
(function (fn) {
if (window.addEventListener) window.addEventListener('load', fn, false);
else window.attachEvent('onload', fn);
})(function() {document.forms['configform'].elements['continue'].click();});
//--></script>

I've tested using IE 6 and 7, Firefox 2, Opera 9 and Safari 3 (all on WinXP).

Discussion

  • Gerry Kroll

    Gerry Kroll - 2008-02-03

    Logged In: YES
    user_id=1198414
    Originator: NO

    I think it's useful to know that the "Continue" button had to be clicked. This indicates a configuration problem of some sort.

     
  • Andrew Gregory

    Andrew Gregory - 2008-02-03

    Logged In: YES
    user_id=785493
    Originator: YES

    ? The problem is the PHP execution time limit of 120sec (I don't want to set it any higher). The GEDCOM data in question takes about 20 minutes to process - much longer than the execution limit. I've also set the runtime limit in the GPV importer to be about half the PHP limit (just in case) - 60 seconds. It's several minutes between clicks anyway, and before my script I would switch away to do something other than stare at a slowly changing screen, which would of course make the import take even longer as it might be several minutes before I'd check back. My change means PGV is never waiting for *me*.

     
  • Gerry Kroll

    Gerry Kroll - 2008-02-03

    Logged In: YES
    user_id=1198414
    Originator: NO

    I can see your point, but it's not for everyone.

    What do you think about making this an option in the Import Options dialog, at the same place where you specify the time limit for Imports? That way, those who like clicking the Continue button can do it their way, and those who find clicking Continue buttons tedious can do it their way too.

     
  • Gerry Kroll

    Gerry Kroll - 2008-02-03
    • assigned_to: nobody --> canajun2eh
     
  • Gerry Kroll

    Gerry Kroll - 2008-02-08
    • status: open --> pending-accepted
     
  • Gerry Kroll

    Gerry Kroll - 2008-02-08

    Logged In: YES
    user_id=1198414
    Originator: NO

    Implemented in SVN 2527 for version 4.1.4.

     
  • SourceForge Robot

    • status: pending-accepted --> closed-accepted
     
  • SourceForge Robot

    Logged In: YES
    user_id=1312539
    Originator: NO

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks