#1135 Cosmetic change to user links

[fade2gray]

Would it be possible to make the following changes to "function print_user_links()" in functions_print.php?

1. Provide the use of an optional parameter allowing the login/logout element to be displayed on a single line when calling the function from header.php (preserving vertical space).
2. Either remove the preposition "as" from the phrase "Logged in as" or remove the surrounding parentheses from the username (doesn't make sense to use both).
3. Remove the vertical bar separating "Admin" and "Logout" (looks ugly when the colour attribute can't be changed to match the theme).

Suggested code change:

[code]
function print_user_links($option=0) {
global $pgv_lang, $SCRIPT_NAME, $QUERY_STRING, $GEDCOM;
global $LOGIN_URL, $SEARCH_SPIDER;

if (PGV_USER_ID) {
echo '<a href="edituser.php" class="link">'.$pgv_lang["logged_in_as"].' '.PGV_USER_NAME.'</a>';
if ($option) {
echo '&nbsp;';
} else {
echo '<br />';
}
if (PGV_USER_GEDCOM_ADMIN) {
echo "<a href=\"admin.php\" class=\"link\">[".$pgv_lang["admin"]."]</a>";
}
echo "<a href=\"index.php?logout=1\" class=\"link\">[".$pgv_lang["logout"]."]</a>";
} else {
$QUERY_STRING = normalize_query_string($QUERY_STRING.'&amp;logout=');
if (empty($SEARCH_SPIDER)) {
echo "<a href=\"$LOGIN_URL?url=".rawurlencode(basename($SCRIPT_NAME).decode_url(normalize_query_string($QUERY_STRING."&amp;ged=$GEDCOM")))."\" class=\"link\">".$pgv_lang["login"]."</a>";
}
}
echo "<br />";
}
[/code]

Thanks.

[Stephen Arnold]

Some of this 'rewording' goes hand-in-hand with my 2005 request to change the display of the LOGGED IN language and include as well as listing of other users currently online so one does not have to keep a tab open on the Portal or Welcome page just to see who else might be there.
Too, we suggested the removal of the parentheses around the U/N, as is suggested here.
https://sourceforge.net/tracker/index.php?func=detail&aid=1308333&group_id=55456&atid=477082
-Stephen