Menu

#1048 Put "Sort by birthdate" button on top

open
nobody
5
2008-10-27
2008-10-27
Wes Groleau
No

On a 768x1024 screen with cloudy theme, if a family has ten or more children, the buttons on the re-order children pop-up are off the screen.

This makes it appear to the inexperienced as if the "re-order children" link (which made the form appear) did not work. (Because the children are still out of order,
and we don't realize we're supposed to scroll down, click sort and then save.)

Suggest repeating the buttons at the top right corner.

Also, suggest (if possible) trying to estimate the size of the popup according to the number of children but never bigger then the screen.

Discussion

  • Anonymous

    Anonymous - 2008-11-18

    Wes, I like the idea of having the 'sort by birth dates' button(s) at the top. Its easy to do as well. Hopefully someone will add this to the core files, but meanwhile you / anyone who reads this, can change your own copy as follows:
    In file phpgedview/edit_interface.php, copy three rows (1960-1962 in my copy, yours may differ slightly):
    <button type="submit"><?php print $pgv_lang["save"]; ?></button>
    <button type="submit" onclick="document.reorder_form.action.value='reorder_fams'; document.reorder_form.submit();"><?php print $pgv_lang["sort_by_marriage"]; ?></button>
    <button type="submit" onclick="window.close();"><?php print $pgv_lang["cancel"]; ?></button>
    to just below the <form> tag (row 1923 for me).

    I say copy, as this gives users the choice of using them from the top or the bottom of the list, but you could choose to move them instead if you only want one set. Equally you could only move / copy the single 'sort by birthdates' button and leave the others at the bottom.

    For good measure I also print, just above the new top buttons :
    "Tip: Either click on "Sort by birth dates" or use your mouse to "drag & drop" children to the right order" to help users a little more. I do this with a new lang variable in extra.en.php

     
  • Anonymous

    Anonymous - 2008-11-18

    Oops, sorry, I got confused when typing that. Ignore those instructions, use these...

    In file phpgedview/edit_interface.php, copy three rows (1619-1621 in my
    copy, yours may differ slightly):

    <button type="submit"><?php print $pgv_lang["save"]; ?></button>
    <button type="submit" onclick="document.reorder_form.action.value='reorder_children'; document.reorder_form.submit();"><?php print $pgv_lang["sort_by_birth"]; ?></button>
    <button type="submit" onclick="window.close();"><?php print $pgv_lang["cancel"]; ?></button>

    to just below the row:
    <input type="hidden" name="option" value="bybirth" />
    which is row 1572 for me.

    Sorry about the confusion :-((

     

Log in to post a comment.