0 @I201@ INDI
1 NAME Claus /Rohwer/
1 SEX M
1 BIRT
2 DATE 02 APR 1852
2 PLAC Sande bei Pollhorn, Jevenstedt
1 DEAT
2 DATE 01 OCT 1932
1 REFN holstein
1 OCCU Kthner
1 FAMS @F125@
Where it used to return:
SUCCESS
0 @I201@ INDI
1 NAME Claus /Rohwer/
1 SEX M
1 BIRT
2 DATE 02 APR 1852
2 PLAC Sande bei Pollhorn, Jevenstedt
1 DEAT
2 DATE 01 OCT 1932
1 REFN holstein
1 OCCU Kthner
1 FAMS @F125@
The extra blank line returned between 'SUCCESS' and the result in in the getnext and getprev function are inconsistent with the way the other functions return their result-data.
Beside being inconsistent my homebrew GDBI-tester unfortunately grabs the results from the screen. It doesn't matter my GDBI-tester, if the result are to be grabbed from the first, the second or the third line, but at this time it must expect the result to be returned to any line out of 3 possible lines ;-(
It also complicates testing, if the GDBI-tester has to be changed to cope with a changed modus operandi every time a new version of phpGedView are tested.
best regard
Arne
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
http://eckmann.dk/b2phpGedView/gdbi.php?action=getxref&type=INDI&position=next&xref=I1&PHPSESSID=0a6a0df9eb014ab8d92907c4a9f021f4
still returns:
<br />
<b>Notice</b>: Undefined variable: gedrec in <b>e:\wwwroot\eckmann\b2phpGedView\gdbi.php</b> on line <b>268</b><br />
SUCCESS
http://eckmann.dk/b2phpGedView/gdbi.php?action=getxref&type=INDI&position=prev&xref=I2&PHPSESSID=0a6a0df9eb014ab8d92907c4a9f021f4
still returns:
<br />
<b>Notice</b>: Undefined variable: gedrec in <b>e:\wwwroot\eckmann\b2phpGedView\gdbi.php</b> on line <b>277</b><br />
SUCCESS
I3120
http://eckmann.dk/b2phpGedView/gdbi.php?action=getnext&xref=I200&PHPSESSID=0a6a0df9eb014ab8d92907c4a9f021f4
returns:
SUCCESS
0 @I201@ INDI
1 NAME Claus /Rohwer/
1 SEX M
1 BIRT
2 DATE 02 APR 1852
2 PLAC Sande bei Pollhorn, Jevenstedt
1 DEAT
2 DATE 01 OCT 1932
1 REFN holstein
1 OCCU Kthner
1 FAMS @F125@
Where it used to return:
SUCCESS
0 @I201@ INDI
1 NAME Claus /Rohwer/
1 SEX M
1 BIRT
2 DATE 02 APR 1852
2 PLAC Sande bei Pollhorn, Jevenstedt
1 DEAT
2 DATE 01 OCT 1932
1 REFN holstein
1 OCCU Kthner
1 FAMS @F125@
The extra blank line returned between 'SUCCESS' and the result in in the getnext and getprev function are inconsistent with the way the other functions return their result-data.
Beside being inconsistent my homebrew GDBI-tester unfortunately grabs the results from the screen. It doesn't matter my GDBI-tester, if the result are to be grabbed from the first, the second or the third line, but at this time it must expect the result to be returned to any line out of 3 possible lines ;-(
It also complicates testing, if the GDBI-tester has to be changed to cope with a changed modus operandi every time a new version of phpGedView are tested.
best regard
Arne