Menu

Bug from bugs-section

Help
Phantomas
2003-11-22
2003-11-24
  • Phantomas

    Phantomas - 2003-11-22

    Hi John,

    there is a bug described in the bugs section:

    Nr. 846389

    In v2.61b1 there is also a bug while editing the language files with the messages:

    $pgv_lang["mail01_subject"]
    $pgv_lang["mail02_subject"]
    $pgv_lang["mail03_subject"]
    $pgv_lang["mail04_subject"]

    This is the result of using the variable
    $_SERVER["SERVER_NAME"]
    inside the language files.

    I'd prefer to use something like:

    $pgv_lang["mail01_subject"]=
    "Your registration at #_SERVER_SERVER_NAME#";

    and not

    $pgv_lang["mail01_subject"]=
    "Your registration at http://".
    $_SERVER["SERVER_NAME"];

    This needs to change the source inside
    login_register.php
    and
    useradmin.php

    For example in login_register.php the line 286 should look like:

    mail($user_email,

    str_replace("#_SERVER_SERVER_NAME#",
    $newuser["fullname"],
    $pgv_lang["mail01_subject"]),

    $mail_body,
    $headers."\r\nContent-type: text/plain; charset=$CHARACTER_SET\r\n");

    and not

    mail($user_email,

    $pgv_lang["mail01_subject"],

    $mail_body,
    $headers."\r\nContent-type: text/plain; charset=$CHARACTER_SET\r\n");

    The problem is with the following messages inside lang.en.php:

    $pgv_lang["mail01_line02"]
    $pgv_lang["mail01_subject"]

    $pgv_lang["mail02_line02"]
    $pgv_lang["mail02_subject"]

    $pgv_lang["mail03_subject"]

    $pgv_lang["mail04_subject"]

    $pgv_lang["admin_approved"]

    Maybe also following messages should be changed:

    $pgv_lang["error_header"]
    ($GEDCOM) in this message

    $pgv_lang["gen_ped_chart"]
    ($PEDIGREE_GENERATIONS) in this message

    $pgv_lang["detected_change"]
    ($GEDCOM) in this message

    If you want I will change these lines in lang.en.php and the php-files, where these messages are used and will send you them by mail.

    bye, Kurt

     
    • Phantomas

      Phantomas - 2003-11-22

      The same inside "configure_help.en.php" with

      $pgv_lang["HIDE_LIVE_PEOPLE_help"]
      ($MAX_ALIVE_AGE) in message

       
    • Phantomas

      Phantomas - 2003-11-22

      Hi...

      As I said changed the most important messages inside the lang.en.php of v2.61b1:

      $pgv_lang["mail01_line02"]
      $pgv_lang["mail01_subject"]

      $pgv_lang["mail02_line02"]
      $pgv_lang["mail02_subject"]

      $pgv_lang["mail03_subject"]

      $pgv_lang["mail04_subject"]

      $pgv_lang["admin_approved"]

      and

      the files

      login_register.php
      useradmin.php

      where these messages are used.

      Now there are no more errors inside the language-edit-utility and I also think what Boudewijn meant in bug-nr 846389 should also be corrected because this problem was with the lang-files of v2.60 final.

      There are still the other messages I wrote in my first message of this threat and this will take a little bit more time to change.

      If anybody whishes, I could upload the changed files for v2.61b1:

      login_register.php
      useradmin.php
      lang.en.php
      lang.ge.php

      to the patches section.

      But all language files which were translated to v2.60 have to be translated to v2.61b1 where the messages I wrote above have to be changed to the new versions from the lang.en.php I will upload into the patches section.

      And... This will only work with v2.61b1!!!

      bye, Kurt

       
      • Boudewijn Sjouke

        Hi Kurt,

        Thanks for your effort! I understand that some fields have to be changed in the different language-files. I lost track of what fields they exactely are. Can you please summarize them in a small list?
        Thnx!
        Boudewijn.

         
    • Phantomas

      Phantomas - 2003-11-22

      Patch uploaded.

      Look at:

      http://sourceforge.net/tracker/index.php?func=detail&aid=847142&group_id=55456&atid=477081

      Following messages need to be updated:

      $pgv_lang["mail01_line02"]
      $pgv_lang["mail01_subject"]
      $pgv_lang["mail02_line02"]
      $pgv_lang["mail02_subject"]
      $pgv_lang["mail03_subject"]
      $pgv_lang["mail04_subject"]
      $pgv_lang["admin_approved"]

      I want to remember...

      This only works with the language files and source files of v2.61b1 !!!

      bye, Kurt

       
    • Phantomas

      Phantomas - 2003-11-22

      Please look at:

      http://sourceforge.net/tracker/index.php?func=detail&aid=847142&group_id=55456&atid=477081

      There is a new patch named:

      bug 846389 patch 2.zip

      This is the patch for the missing variables I wrote in this threat.

      Includes:
      configure_help.en.php
      configure_help.ge.php
      lang.en.php
      lang.ge.php
      edit_privacy.php
      editconfig_gedcom.php
      index.php
      LANG_CHANGELOG.txt

      Correction of the variables:
      *$pgv_lang["detected_change"]
      *$pgv_lang["gen_ped_chart"]
      *$pgv_lang["error_header"]
      *$pgv_lang["HIDE_LIVE_PEOPLE_help"]

      I want to remember...

      This only works with the language files and source files of v2.61b1 !!!

      bye, Kurt

       
    • Phantomas

      Phantomas - 2003-11-22

      John...

      I hope you can get throgh this patches.

      If not, please ask ;-)

      bye, Kurt

       
    • John Finlay

      John Finlay - 2003-11-24

      Thanks for your help, Kurt.  When I download and add a patch to the CVS code, I mark the patch as "Accepted" until I release the next version with the patch in place.  Then I close the patch.

      --John

       

Log in to post a comment.