Menu

4.2.2 class="starredname"

Help
Victor H.
2009-09-18
2013-05-30
  • Victor H.

    Victor H. - 2009-09-18

    I have some individuals whose preferred names are designated with an asterisk. Upon going from 4.1.7 to 4.2.2 their names are showing up oddly. I searched the patches, bug reports, and help forum, and I don't see this mentioned. This occurs on the individual page, family page, and lists.

    Augustus Franklin class="starredname">Gus Smithson ‎(I49)‎

    Gedcom is

    0 @I49@ INDI
    1 NAME Augustus Franklin /Smithson/
    2 GIVN Augustus Franklin
    2 NICK Gus*
    2 SURN Smithson

    The asterisk indicated highlight (underline) in 4.1.7. Has something changed?

    Thanks,
    Victor

     
  • Anonymous

    Anonymous - 2009-09-18

    Victor, no nothing has changed that I'm aware of. The asterix after a name, even a nickname, is working fine for me.

    Is

    "Augustus Franklin class="starredname">Gus Smithson ‎(I49)‎ "

    exactly what you are seeing displayed? If so, it looks like you might have a 'bad' file. Try replacing /includes/controllers/individual_ctrl.php with a fresh copy.

     
  • Victor H.

    Victor H. - 2009-09-18

    Yes, that is exactly how the name looks everywhere it is referenced. In the above example the gedcom file has Gus* as the nickname, and that part of the name is now displayed as . This happens on all individuals with a starred name.

    I double-checked the files on the servers against the files I downloaded from SourceForge using the compare function of FileZilla, and individual-ctrl.php was fine. I replaced it anyway to no effect. Thanks for the reminder anyway though, because I found that the edit-interface.php was a bad upload. So I got that fixed.

    I then downloaded a fresh copies of both the basic and full PGV 4.2.2 bundles from SF and checked those files against my server, and everything checks out there as well. No files of incorrect size.

    BTW… re this SourceForge board, how do you make the underscore show an underscore instead of being interpreted as emphasis? I had to change the above underscores to dash to get around this.

     
  • Stephen Arnold

    Stephen Arnold - 2009-09-18

    Victor
    Here's your problem. The * behind any name portion, either in the NAME line, or the GIVN line, or the NICK line, will add that star-named portion to underlined. However, the NICK portion of the naming convention "automatically underlines" that name portion when it adds it to the NAME display. So, you are double underlining the NICK.<p>
    The following code would generate the following display:<br>
    1 NAME John William* /Smith/<br>
    2 GIVN John William*<br>
    2 SURN Smith<br>
    display=  John <u>William</u> Smith<p>
    and in your case the following would be displayed<br>
    1 NAME John William /Smith/<br>
    2 GIVN John William<br>
    2 NICK Billy<br>
    2 SURN Smith<br>
    display=  John William <u>Billy</u> Smith<p>
    The use of an asterisk on an already emphasized display is redundant and can cause problems.  Just so you know, the "" still also underlines a name segment.<br>
    -Stephen

     
  • Anonymous

    Anonymous - 2009-09-18

    Stephen, I'm going to have to disagree. NICK causes the name to be enclosed in brackets like "(Gus)". The asterix causes underlining.

    I tested this when Victor raised it, by adding an asterisk to a NICK on my current system (4.2.3 SVN) and I got the nickname both in brackets and underlined, which is what Victor is expecting to see.  I sort of agree with you that this is over-emphasis, but it is and was possible to do it.

    The problem is not in individual_ctrl.php, because my version in 4.2.3 is still the same as the standard 4.2.2 release. So either Victor has  a unique problem, or there is still an issue with this in 4.2.2 but fixed in 4.2.3. I'll try to check this tomorrow, unless anyone else can do it sooner.

    Victor, re "how do you make the underscore show an underscore instead of being interpreted as emphasis" . You don't as far as I can see, This board has improved, but its still rubbish compared to most.

     
  • Anonymous

    Anonymous - 2009-09-18

    Sorry, small corerction. Should have said:

    "…NICK causes the name to be enclosed in quotes like "Gus" on display."

     
  • Stephen Arnold

    Stephen Arnold - 2009-09-19

    Kiwi 
    Strange, on my SVN 4.2.3, quotes causes underlines. If I use NICK and Asterisk too, then I get the underlined NICK name preceded by the STARRED_NAME error in quotes. That's the error I was discussing with doing both. But I, of course, have selected QUOTES to UNDERLINE in my gedcom configuration so that it matches the ASTERICK action. I thought both underline and quotes were confusing to users. 

    So strange on this screwy forum software, they tell you its ok to use markdown and html syntax, and the preview of my previous post was perfect, and then it posted all messed up. 
    -stephen

     
  • Anonymous

    Anonymous - 2009-09-19

    Thats interesting. It suggests the error is with the option to use quotes for underlining. I have always left that set to NO, and use the asterisk instead. So in my case I get the unerlining on NICK without any error message.

    So Victor, in the short term at least, go to your GEDCOM config and set "Use quotes for preferred name" to No. That should clear your error.

    I'll investigate the problem further tomorrow, and if I can't see the fix I'll raise a bug report.

     

Log in to post a comment.