Viewing of notes and shared notes on living people should be restricted to people who have obtained a user account.
At the moment everyone can view shared notes on living people.
E.g. if you search for a living person and select one of the notes, then the window with the shared note will be displayed. When you open the shared note, you can see all information in the note although the person you are viewing is still living.
How can we prevent viewing of shared notes on living people?
What are the purpose of shared notes?
Can't we just have "simpel notes" that only can be seen when you display "Personal Facts and Details" and only if you have obtained a user account or the person is dead?
Jens
Shared notes are a valuable tool to prevent lengthy, duplicated posts throughout your GEDCOM. Create once and link to mutliple individuals, familes, facts, events, sources and media. "Simple Notes" do exist and you can easily create them at level 1, 2, 3+.
You have identified a privacy bug as shared notes that reference a living person (linked), should not be visible except to registered users. Obviously, the appropriate privacy rules are not being applied.
Please submit a bug report and we'll see if it can't be addressed forthrightly. Stephen
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Dear Stephen
Thank you for your answer.
We import our ged-files from FTM, and our simple notes then become shared notes in PGV. As such, the notes become visible to unregistered users.
That I think is also a bug.
Where to do I submit a bug report?
Jens
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
<<our simple notes then become shared notes in PGV>>
PGV does not convert simple ("inline") notes to shared ("record") notes. See page 37 of the gedcom 5.5.1 spec for full details of the syntax. Here's a simple example:
0 @XXX@ SOME_OBJECT
1 NOTE This is an inline note that is embedded in other objects
0 @XXX@ SOME_OBJECT
1 NOTE @N123@
0 @N123@N NOTE This is a note record, that is referenced from one (or many) other records.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Replacement of these files in 4.2.3 may or may not cause issues with other files as there have been previous changes in these files in the release of 4.2.3 stable. You may wish to test both or simply download the most recent SVN tarball and replace your 4.2.3 files.
-Stephen
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Yes I understood Greg's comment. According to his comment our program use "shared notes" but the notes are in fact "simple notes". I tested GRAMPS which has the same problem.
When uploading a ged-file, will it then be possible to define notes to be simple notes instead of shared notes?
Where do I find SVN tarball?
Jens
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Jens
0 NOTE is never a simple note. It is defined by the spec as being a 'shared note'. These are clearly '0' level tags.
As Greg coded, to create 'simple notes', they simply need to be +1n level tags, subordinate to some other tag, and NOT reference a 0-level NOTE. FTM produces Shared Notes upon request, as well as simple notes (imbedded).
Per Greg's posting:
Here's a simple example:
0 @XXX@ SOME_OBJECT
1 NOTE This is an inline note that is embedded in other objects
0 @XXX@ SOME_OBJECT
1 NOTE @N123@
0 @N123@N NOTE This is a note record, that is referenced from one (or many) other records.
You should spend some time learning to navigate the PGV-SF site and examine all the menu options. It will make access and successful use to the plethora of information available much easier.
The genealogy program I use (FTM2010) outputs the code for shared note even if the note only belongs to one individual.
I have tried to import the ged-file into the following programs and then output a new ged-file:
GRAMPS - it also outputs the wrong code for simple note.
Legacy - it also outputs the wrong code.
PAF - it outputs the right code but renumbers individuals.
Based on above tests I suggest the following new feature in PGV:
During import of ged-file, it should be possible to choose if all notes should be simple notes.
I found the right place for the tarball, but got confused by the name GNU Tarball, as you wrote SVN Tarball.
I have now tested note.php and functions_privacy.php.
It is still possible to view shared notes for living individuals!
Could it be that I need some further corrections/files from the tarball in order to make it work?
Jens
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Jens
I am not the least bit confused. You explained yourself very well, but are simply mistaken as to your conclusions.
FTM 2010, as was true of several previous FTM versions, doesn't create Shared Notes from simple notes. It allows you to add Shared Notes, the same as PGV or webtrees or Brother's Keeper, or GEDitcom, or any of several dozen other programs. What FTM 2010 also does is a lousy job of explaining the difference to the user when creating/adding a note.
However, the choice is yours as FTM does not require each note to be shared in nature (or formation).
What is required is that, either you leave the Shared Notes already created while using FTM in place (it is OK to have a single reference for a Shared Note, but it has the capability of being posted to multiple tags - I have many), or you go back through your GEDCOM and remove the +1n NOTE @Nxxx@ tags and look up the replacement NOTE text to paste into the INDI or FAM or SOUR or REPO or OBJE or PLAC tag records.
Personally, I'd choose the first course of action and if you desire to continue to use FTM (for whatever misconceived reason IMHO), then start creating true 'simple notes' and not 'shared notes' that they simply call 'notes'.
<<It is still possible to view shared notes for living individuals! >>
The code that was added to SVN is not quite right. (The code is correct, but It was added in the wrong place). I am sure an updated version will be posted soon.
(If any of the developers are reading this, the new block of code needs to be moved down one line, outside the "if type==OBJE" block.)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
<<During import of ged-file, it should be possible to choose if all notes should be simple notes. >>
If you are just using PGV to display your data, then both formats will be displayed the same.
The only differences should be (a) editing is different and (b) the notes appear on the notelist.php page.
Converting during the import process is difficult. The import-process only reads the gedcom file once. Since you may find a reference to a note *before* you find the actual note, you would need to read the file twice, and store a temporary copy of all notes. This would require major changes to the importer.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
NOTE TO ALL
A revised functions_privacy.php file has just been uploaded to SVN which completes the Shared Note privacy by privatizing the page html TITLE as well.
-Stephen
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Viewing of notes and shared notes on living people should be restricted to people who have obtained a user account.
At the moment everyone can view shared notes on living people.
E.g. if you search for a living person and select one of the notes, then the window with the shared note will be displayed. When you open the shared note, you can see all information in the note although the person you are viewing is still living.
How can we prevent viewing of shared notes on living people?
What are the purpose of shared notes?
Can't we just have "simpel notes" that only can be seen when you display "Personal Facts and Details" and only if you have obtained a user account or the person is dead?
Regards
Jens Friismose
http://www.familiesporet.dk/
Why is this note shared with a person
Jens
Shared notes are a valuable tool to prevent lengthy, duplicated posts throughout your GEDCOM. Create once and link to mutliple individuals, familes, facts, events, sources and media. "Simple Notes" do exist and you can easily create them at level 1, 2, 3+.
You have identified a privacy bug as shared notes that reference a living person (linked), should not be visible except to registered users. Obviously, the appropriate privacy rules are not being applied.
Please submit a bug report and we'll see if it can't be addressed forthrightly.
Stephen
Dear Stephen
Thank you for your answer.
We import our ged-files from FTM, and our simple notes then become shared notes in PGV. As such, the notes become visible to unregistered users.
That I think is also a bug.
Where to do I submit a bug report?
Jens
I've coded a fix for this, and Stephen is testing it for me/
The new code will be posted soon.
<<our simple notes then become shared notes in PGV>>
PGV does not convert simple ("inline") notes to shared ("record") notes. See page 37 of the gedcom 5.5.1 spec for full details of the syntax. Here's a simple example:
0 @XXX@ SOME_OBJECT
1 NOTE This is an inline note that is embedded in other objects
0 @XXX@ SOME_OBJECT
1 NOTE @N123@
0 @N123@N NOTE This is a note record, that is referenced from one (or many) other records.
Jens
Did you understand Greg's comments? If you have 0 NOTE tag's, these are not 'simple' notes, but rather 'Shared Notes'.
As to the Shared Note privacy bug, we are working on a fix and should have it complete by Sunday.
-Stephen
Two new files have been added to SVN main branch that fix this bug:
note.php
http://phpgedview.svn.sourceforge.net/viewvc/phpgedview/trunk/phpGedView/note.php?sortby=date&view=log
functions_privacy.php
http://phpgedview.svn.sourceforge.net/viewvc/phpgedview/trunk/phpGedView/includes/functions/functions_privacy.php?sortby=date&view=log
Replacement of these files in 4.2.3 may or may not cause issues with other files as there have been previous changes in these files in the release of 4.2.3 stable. You may wish to test both or simply download the most recent SVN tarball and replace your 4.2.3 files.
-Stephen
Yes I understood Greg's comment. According to his comment our program use "shared notes" but the notes are in fact "simple notes". I tested GRAMPS which has the same problem.
When uploading a ged-file, will it then be possible to define notes to be simple notes instead of shared notes?
Where do I find SVN tarball?
Jens
Jens
0 NOTE is never a simple note. It is defined by the spec as being a 'shared note'. These are clearly '0' level tags.
As Greg coded, to create 'simple notes', they simply need to be +1n level tags, subordinate to some other tag, and NOT reference a 0-level NOTE. FTM produces Shared Notes upon request, as well as simple notes (imbedded).
Per Greg's posting:
0 @XXX@ SOME_OBJECT
1 NOTE This is an inline note that is embedded in other objects
0 @XXX@ SOME_OBJECT
1 NOTE @N123@
0 @N123@N NOTE This is a note record, that is referenced from one (or many) other records.
You should spend some time learning to navigate the PGV-SF site and examine all the menu options. It will make access and successful use to the plethora of information available much easier.
CODE > SVN BROWSE > TRUNK > PHPGEDVIEW >
You would arrive at the following URL with a DOWNLOAD TARBALL link at the bottom of the page:
http://phpgedview.svn.sourceforge.net/viewvc/phpgedview/trunk/phpGedView/
The direct TARBALL link is:
http://phpgedview.svn.sourceforge.net/viewvc/phpgedview/trunk/phpGedView/?view=tar
-Stephen
I didn't explain myself very well.
The genealogy program I use (FTM2010) outputs the code for shared note even if the note only belongs to one individual.
I have tried to import the ged-file into the following programs and then output a new ged-file:
GRAMPS - it also outputs the wrong code for simple note.
Legacy - it also outputs the wrong code.
PAF - it outputs the right code but renumbers individuals.
Based on above tests I suggest the following new feature in PGV:
During import of ged-file, it should be possible to choose if all notes should be simple notes.
I found the right place for the tarball, but got confused by the name GNU Tarball, as you wrote SVN Tarball.
I have now tested note.php and functions_privacy.php.
It is still possible to view shared notes for living individuals!
Could it be that I need some further corrections/files from the tarball in order to make it work?
Jens
Jens
I am not the least bit confused. You explained yourself very well, but are simply mistaken as to your conclusions.
FTM 2010, as was true of several previous FTM versions, doesn't create Shared Notes from simple notes. It allows you to add Shared Notes, the same as PGV or webtrees or Brother's Keeper, or GEDitcom, or any of several dozen other programs. What FTM 2010 also does is a lousy job of explaining the difference to the user when creating/adding a note.
However, the choice is yours as FTM does not require each note to be shared in nature (or formation).
What is required is that, either you leave the Shared Notes already created while using FTM in place (it is OK to have a single reference for a Shared Note, but it has the capability of being posted to multiple tags - I have many), or you go back through your GEDCOM and remove the +1n NOTE @Nxxx@ tags and look up the replacement NOTE text to paste into the INDI or FAM or SOUR or REPO or OBJE or PLAC tag records.
Personally, I'd choose the first course of action and if you desire to continue to use FTM (for whatever misconceived reason IMHO), then start creating true 'simple notes' and not 'shared notes' that they simply call 'notes'.
If you'd care to see how PGV/webtrees handles mixed presentation of 'simple notes' and 'shared notes', please see the record of my GGF:
http://www.myarnolds.com/individual.php?pid=I202&ged=Arnold.ged#notes
-Stephen
<<It is still possible to view shared notes for living individuals! >>
The code that was added to SVN is not quite right. (The code is correct, but It was added in the wrong place). I am sure an updated version will be posted soon.
(If any of the developers are reading this, the new block of code needs to be moved down one line, outside the "if type==OBJE" block.)
<<During import of ged-file, it should be possible to choose if all notes should be simple notes. >>
If you are just using PGV to display your data, then both formats will be displayed the same.
The only differences should be (a) editing is different and (b) the notes appear on the notelist.php page.
Converting during the import process is difficult. The import-process only reads the gedcom file once. Since you may find a reference to a note *before* you find the actual note, you would need to read the file twice, and store a temporary copy of all notes. This would require major changes to the importer.
NOTE TO ALL
A revised functions_privacy.php file has just been uploaded to SVN which completes the Shared Note privacy by privatizing the page html TITLE as well.
-Stephen
Thank you.
Privacy is now working.
Jens :-)