Menu

Cannot make multiple Changes at once

Help
buzz691
2009-09-05
2013-05-30
1 2 > >> (Page 1 of 2)
  • buzz691

    buzz691 - 2009-09-05

    I am using the latest version of PhpGedView 4.2.2 and when I go to change details within an Individuals file, I make the first change and that's fine, as it displays in a blue box the new changes, but when I make a second change to the same Individual straight after the first change, only that latest change get submitted for Accepting by the administrator.

    I'm the administrator, but it happens on edit accounts as well. Anybody with any ideas?

     
    • Anonymous

      Anonymous - 2009-09-06

      You need to accept the first changes, as admin, before you, or any other user can make subsequent changes.

      If thats a problem, then at least you as admin should change your user profile setting for "Auto accept changes" to YES, then the accept step is not required.

       
      • buzz691

        buzz691 - 2009-09-06

        thanks for your reply. i've looked at your suggestion and this works great for me as an admin, but for people with edit rights, it sounds very tedious. ie. they make one change, I accept, then they make another change, i accept it. If they have 5 changes to make, this process could take a week to finish.

        Just so I have this clear, if for example, they wanted to make minor changes to a profile eg add a time to a birth, and add a communion date, they would have to make one change to the time, wait for my (admin) acceptance, then add the communion in and again wait for my acceptance?

        There is no other way around this other than to give them accept privledges?

         
    • Anonymous

      Anonymous - 2009-09-06

      Sorry, I might have mis-understood your original question, or I might even have answered a bit too quick.

      I've just added a user with edit rights to my system, then logged in as them and went to an INDI page to make some changes. First I edited an existing event; then I added a completely new event; then finally I went back to that first event and changed it again.

      All on the same INDI page.

      Then, in another browser, I logged in as admin. I get the "Changes have been made to this GEDCOM. Accept / Reject Changes" note on My Portal page (I didn't wait for emails). I clicked on "Accept / Reject Changes".

      In the pop-up window I see the INDI with the changes, and  see three listed. I also see what I suspect you are referring to - only the last one has "Accept" in the left-hand box, and Undo in the right.

      Not sure if its by design or error - but for me at least that is irrelevant, as I would NEVER accept changes without reviewing them. Otherwise, why not just give that user auto-accept?

      So instead I click on "View Change Diff". That takes me to the INDI page, where I can see the red-blue boxes,. These highlight the new event added,  the change to the existing one - but of course only the second change, because the editor had already replaced his first attempt.

      So now I can choose whether to a) go back to the pop-up and "Accept all changes", or b) edit any of the individual changes to something I prefer. If I just change one, that will be accepted, and I can still decide what to do with the other.

      Sorry if thats all a bit long-winded, but I felt I should explain how I'm seeing it working, which I believe is how yours should work. If thats not the case, we'll need to look again.

       
      • buzz691

        buzz691 - 2009-09-06

        I have done exactly what you have just done. Created a temp account with editing priv. I go to an individual profile and edit exisiting data, ie add a time to a birth. (The refreshed screen shows me the red/blue boxes etc).

        Then I add a christening, save the data and the red/blue boxes are only around the christening info. The time data entered previously is not there.

        I then change the first box again to change the DOB year (save it) and again it only shows the red/blue boxes around the new DOB year.

        I log out and log in as Administrator. Go to Accept/Reject Changes, It shows the three changes in a table, but only has an accept next to the bottom change (the date/time column indicates the last chronological change). The is no accept next to the top  two changes. If I go to View Change Diff is has a red box around the old DOB year and the blue box around the newly changed DOB year.

        If I press the only accept button there it only accepts the last one ie the DOB year change? If I press accept all changes It still only accepts thelast changed data. I hope this makes sense?

         
    • Anonymous

      Anonymous - 2009-09-07

      Yes, it seems to make sense - but I can't reproduce it (also using 4.2.2). Unless someone else has any ideas I would have to recommend you raise a Bug Report for it (under "Trackers" in the menus above), as it is more likely one of the developers will pick that up from there.

       
    • Stephen Arnold

      Stephen Arnold - 2009-09-07

      Yes, several renditions ago (back in v.3+) PGV did allow the individual approval of changes from multiple conditions - i.e. there was an ACCEPT link adjacent to each line change, if there were multiple facts/events changed.  This was removed well over a year and one-half ago, maybe longer, as it led to possible data integrity issues with the order and total changes approved. Now, you can review all proposed changes and make changs yourself, before you approve or disapprove the change to the master data.

      Personally, I use RAW edit for every change by most of my users as I find, regardless of how much prodding I do, they still don't format their data entries correctly and its much easier to add the county name, or abbreviation or USA or media file name or TITL (or other format issue, like SOUR) before approving the change, than trying latter to remember to go back and modify the data.

      AFAICS, I'm with KIWI. We have dozens of users making hundreds of changes each day, and we see no issues with the current release or in beta-code (SVN). All changes made by our users are recorded in the pending change data report (ACCEPT/REJECT), waiting for our review.
      Stephen

       
      • buzz691

        buzz691 - 2009-09-09

        Thanks but I'm a little confused. Your saying that it is not possible to accept each individual change to a fact/event, but you can review the multiple changes if by going to RAW Edit.

        If I go in hereRAW edit or to View Change Diff i only see the very last change made. Not the 1st or subsequent change except for the last change. In view change diff it has a blue box around the last change only and the other mods have not changed.

        If you have dozens of users making hundredes of changes how can all their changes be made if all I'm seeing is the very last one??? I am new to all this, please let me know if I'm not making any sense.

         
      • buzz691

        buzz691 - 2009-09-09

        Thanks but I'm a little confused. Your saying that it is not possible to accept each individual change to a fact/event, but you can review the multiple changes if by going to RAW Edit.

        If I go in hereRAW edit or to View Change Diff i only see the very last change made. Not the 1st or subsequent change except for the last change. In view change diff it has a blue box around the last change only and the other mods have not changed.

        If you have dozens of users making hundredes of changes how can all their changes be made if all I'm seeing is the very last one??? I am new to all this, please let me know if I'm not making any sense.

         
    • Stephen Arnold

      Stephen Arnold - 2009-09-09

      Yup, not making any sense. TEE HEE.
      I'm sorry, like others have previously noted, I can not reproduce your problem. If I go to VIEW CHANGES, I see Red/Blue on every item changed, including the CHAN record as well as facts/events. Frankly, I don't care what changes were made as long as they have SOUR records attached and comply with my desired formatting conventions. That's my only reason to review changes prior to approval, hence why I view RAW data. I email my users after a series of changes where I'm required to make improvements and advise them to review their recent addtions to see how I changed the data to conform to the my conventions, asking politely that, for future changes, they try to have their data entry mirror these guidelines. Most often its location problems (missing county or county designator, so Marshall, IL , which I presume should be Marshall, Clark Co, Illinois, USA as the family hails from Clark Co, rather than Marshall County, Illinois, etc), incomplete SOUR notations or media files like  "1234.jpg" or "Uncle Ben.jpg" instead of "Ben_Smith-I12345-hdstn.jpg". Sooner or later, most learn.
      Don't get hung up on the whys and wherefores for every single change - as I can't imagine why you would. If someone isn't following your conventions, terminate their edit rights. That's what I do. BTW, if they don't have edit rights, they don't have ANY rights beyond normal casual visitor access (no living persons).
      Stephen

       
      • buzz691

        buzz691 - 2009-09-09

        Yeah, it make sense then from your last post. I cannot view or accept any changes other than the very last one. I have sent a request of for a bug analysis. Perhaps it has to do with my browser (IE8) or OS (Vista Ultimate, although I'm using XP and Windows 7 at work) or something else unique to my setup. Thanks anyway.

         
        • buzz691

          buzz691 - 2009-09-09

          in response to kiwi_pgv, I've got a few more screenshots of the View Diff page and the edit Gedcom Page, but how can I add them to the original bug post?

           
    • Anonymous

      Anonymous - 2009-09-09

      "something else unique to my setup"  - perhaps.
      "my browser (IE8) or OS (Vista Ultimate, although I'm using XP and Windows 7 at work)"  - not likely. I use all those myself, as well as FF, Safari, Opera, and Chrome browsers for testing. All give the same result.

      In my view, you're looking for something that doesn't exist, rather than a bug. At best perhaps a new Feature Request . The image attached to your bug report is normal - exactly what we've been using for years. But try attaching an image of the Individual page, after clicking "View Change Diff" instead. That might tells us something else.

      My practice is similar to Stephen's, except that I'm happier using "View Change Diff", rather than "Edit raw GEDCOM record", but thats just personal preference.

       
    • zdiva

      zdiva - 2009-09-10

      No offence to the designers and programmers of PGV - because it is the best genealogical programme there is - but the User Interface and especially Edit/Add/Modify, Quick Form, etc features are the weakest of the whole program.

      I've been using PGV for few years now, and after an honest try, I had to drop the user editing option for all except myself and one other person who was (and still is) extensively trained by me.

      My users come from several different countries and use several different languages, and each one of them has a different view of what a 'standard' is! And since there is hardly any checking built into the programme - the amount of wrong entries, inverted dates, incomplete or plainly wrong geografical places, general confusion of what goes where, and the amount of my time required to find out what the user had in mind, then correct the entries, and then approve them was not worth it.

      Over the years, I've developed a happy medium. No user editing period! And certainly not RAW anything! An average Joe is scared to even see the name GEDCOM - understanding the priciples behind it is beyond their interest.  And honestly, the internal mechanics of the programme should not be their concern anyway.

       
    • Stephen Arnold

      Stephen Arnold - 2009-09-10

      zdiva
      I dare say I think you are mistaken, misinformed, or ill-practiced. We have over 300 users, about 30 or so pretty active, with over 100 changes/additions each day. Every facet of the program is used by these users, including reports, multimedia and more. While certainly not perfect, PGV has come a long way in the 5 years I've been here. With a properly formatted base (read 'cleaned-up') gedcom, autocomplete makes incorrect entries of places almost a thing of the past. I find a little gentle prodding after the first series of entries nearly puts other data-entry difficulties to rest and  since I check every entry prior to approval, a quick glance at the RAW code lets me fix anything quickly.

      Better than bemoaning the situation, what about offering your time and talent to remedy what you think is wrong with the interface. Greg's recent recoding to a database-driven code structure from the older text-reliant files is not yet fully developed. There are many enhancements that can be made to the interface, storing individual preferences like popup window sizes and locations for various editing efforts.  Try a more constructive approach to your comments and proffer your services - this is OPEN SOURCE software and no one is getting paid.
      -Stephen

       
  • Walton

    Walton - 2009-09-12

    In response to the original question - I think this is a feature rather than a bug, forcing those without full admin rights to double check each edit before accepting it. If you really trust what they are likely to enter then go into User Admin, edit their account and tick the box that says "Automatically accept changes made by this user". Then they don't have to wait before making the next change and entries still get the "Last modified by…" comment underneath them.

    Personally I agree with zdiva - "One man. One vote." And I'm that man!

    Differences in style of listing really come into play with things like the google maps module, where "USA", "U.S.A", "US of A" and "United States of America" are actually four different countries and you have to install map locations for all of them. I have one relative that always puts a full stop after the country name, this is more annoying than many other errors because it's easy to not notice and that buggers up google maps too. If someone else really wants to change more than the odd spelling error they can always send an email.

    Cheers,

    Andrew.

     
  • Stephen Arnold

    Stephen Arnold - 2009-09-12

    Andrew - Either you and zdiva are using a different release version than either the current stable release, v4.2.2 or the SVN-code, or your belaboring under a misconception. Any EDIT-RIGHTS user, that is any registered user who can edit the gedcom, can make multiple changes, additions and deletions to any INDI, FAM, SOUR, etc within their purview. Every change will appear on the VIEW CHANGES page for that FAM or INDI record, but there is only ONE accept option for the multiplicity of changes. That is an ALL or NONE option for approval, but for UNDO, it is undone, one change at a time, in the order sequence in which they were entered.  Personally, I never think it wise to undo only one change (as I don't know ahead of time which line it will remove), so I will usually either deny all changes to that INDI or FAM or approve them all (if I can't fix the data prior to approval), and contact the party that entered the data to determine their real intentions, clarify a SOUR, or resolve a conflicting date.

    Again, PGV as currently structured allows multiple changes by editing users for an INDI or FAM and multiple changes across many INDI's or FAM's.  I have several users who, while I slept last night, added over 50 new persons, with media, sources and new places, all with multiple details, children, spouses and more. 
    Stephen

     
  • Anonymous

    Anonymous - 2009-09-12

    Andrew "where "USA", "U.S.A", "US of A" and "United States of America" are actually four different countries and you have to install map locations for all of them." seems like a very messy way to solve a fundamental data entry problem. Sure, you CAN load four sets of GM coordinates to cater for your users bad habits, but that won't help if you want to produce reports etc of people from the same location; or even use the Place Hierarchy lists.

    What you need to do is:

    1. make sure your current place list is cleaned up properly. Get rid of all those anomalies like U.S.A. etc
    2. tell your users what your data entry expectations are
    3. don't give edit rights away too easily, and monitor its use carefully
    4. once your existing places are tidy, turn on 'autocomplete' and teach your users to use it. That way the same correct name gets used every time. It is important to NOT have 'autocomplete' available UNTIL your existing places are tidy, as users will be presented with all those '*bad*' names to choose from still.

     
  • buzz691

    buzz691 - 2009-09-12

    So from what I've read, I have an unexplained problem with my setup, as I should be able to make multiple changes to an INDI in one session as an *edit* user.

    Just to make it clear I have added some screen shots which show that after making 3 changes to the one gedcom ie. add **blessing** in 1990, **christening** in 1991 and **confirmation** in 1992 with an *edit* profile.

    When I log in as Admin and press Accept/Reject Changes I get

    [When I click View Change Diff I see  which is only the last change.

    When I click view gedcom record I get

    When I press accept on the last line of the review gedcom changes box it accept only the last changed event which in this case was confirmation.

    As I can't see the first two changes made by the user temp (by going into view change diff), I cannot manually go in myself and make those first two changes. So at the moment edit user can only make one change at a time, until I verify it. Then they can make the second change. If this is what everyone else has I will accept it, but looking at the above comments they are able to make multiple changes in one sesson.
      : http://yfrog.com/18reviewgecomchangesj
      : http://yfrog.com/18viewchangediffj
      : http://yfrog.com/03viewgedcomrecordj](http://text)

     
  • Anonymous

    Anonymous - 2009-09-13

    buzz, thats definitely not 'normal' PGV behavior. I'd like to get to the bottom of this one, but your original query has become a little sidetracked here. Any chance you could give me access to your site, and to an individual I can experiment with? Email me direct through my user name here.

     
  • Stephen Arnold

    Stephen Arnold - 2009-09-13

    Buzz
    And same here - I'd be happy to take a look. I'd prefer two users - one as a simply EDIT user and one as an ADMIN level user. That way we can review all sides of the issue. 
    BTW, the 1 ADDR tag is incorrect. ADDR should be a LEVEL 2 tag, included within a RESI level 1 or OCCU level 1 or EDU level 1, etc.

    You can best email me directly using my SF profile, or visit our site and use one of the PGV email links at the bottom of ever page.

    I just finished over 300 changes by 4 power users in the lst six hours and all were without issue. Multiple changes and additions to INDI records. 
    Stephen

     
  • Stephen Arnold

    Stephen Arnold - 2009-09-13

    Buzz 
    Just one thought - Do you perchance have SYNC to gedcom enabled? I'm thinking that there may be an issue with writing to the text file on multiple events - not that I've checked that, but just curious since I know that both KIWI and I don't use SYNC, but rather speed our systems using DB write-to only and then frequent backups to protect data. 
    -stephen

     
  • potain

    potain - 2009-09-13

    Can't help feeling that this is related to my @NN post - I've now given that user auto accept changes telling her to make use it with extra care when editing records because I had to approve even the most minor of changes.

    While I can no longer see the changes that she makes I am hoping that these will be reported in the log file. If it isn't then I suggest that it be implemented.

    Jean

     
  • Greg Roach

    Greg Roach - 2009-09-13

    <<I am hoping that these will be reported in the log file>>

    Changes are recored in the logs, but a simpler way to see them is to use the "recent changes" block on the welcome page.

     
  • potain

    potain - 2009-09-13

    Thanks Greg

     
1 2 > >> (Page 1 of 2)

Log in to post a comment.