Cannot make multiple changes at once
Brought to you by:
canajun2eh,
yalnifj
Menu
▾
▴
Hi,
I'm starting a new thread on this because although I believe I have essentially the same problem that buzz691 reported on 2009-09-06, the thread seemed to wander off the track somewhat and no answer came from it - at least not for the problem as I see it . So I'd like to restate the problem as I am experiencing it.
- I am the admin and the only one with edit rights.
- I have PGV installed for about four years and moved steadily forward as new releases came available.
- A function that I have used continuously over this time with no problem at all has suddenly disappeared with 4.2.2 and I believe this must be a bug
- The problem relates to what for me is a very common process of making a number of different changes to the personal facts and details relating to one individual at the same time, eg.
- add baptism details, then
- add residence details, then
- modify date of death and source ref for death event
- then accept the change
I must have been through a similar sequence of changes thousands of times over the last few years, and what has always happened in the past is that at each of the steps listed the new information appears on the Personal Facts and Details page edged in blue, the original content remaining edged in red. So at the end of the first three steps I have a display with the new baptism data edged in blue, the new residence data edged in blue, the new death data edged in blue and the old death data edged in red. I then accept, and the page is re-presented with all the changes made.
However, what happens with 4.2.2 is that after the first step the new baptism data appears edged in blue, but after the second step the baptism data has disappeared and the only change data that now appears is the new residence data, edged in blue. If I continue, this also disappears as soon as I make the changes to the death data, and only the latest change - ie the new death data edged in blue and the old death data edged in red appears. If I then accept, the only change which has ben made is the death data change - the other data has been lost.
Hopefully you will agree with me that this must be a bug and also hopefully someone can suggest a simple fix.
Thanks in advance.
Best regards
Ron
I've just tried this again, as I did after the first report.
I cannot reproduce this.
I make three edits, to three facts. After each fact, I see all the previous values in red and all the new values in blue. After three edits, I see three pairs of changes.
<<Hopefully you will agree with me that this must be a bug and also hopefully someone can suggest a simple fix.>>
Unless myself or one of the other developers can reproduce this error (and several of us have tried), it is difficult to help you.
Thanks for the fast response. Let's double-check we are working with the same conditions. The problem is not intermittent for me but permanent. Here's my environment:
1. I am logged in as admin
2. I have PGV4.2.2 public release level (English)
3.PC: Windows Vista (French); IE8 (French)
3. Server software: Linux; PHP 5.2.8; MySQL 5.0.81; Apache 2.2.13 (Unix)
4. Physical location: France
5. If you want me to set up a user account with edit/admin rights so you can see for yourself, just say the word. If buzz691 is still reading this it would be good to know whether he still has the problem and if so what his details are - something that is different between your set-up and mine must be the clue to the problem.
6. I mentioned the problem to one of your fellow developers (Brian) when I had it with 4,2,2svn and he said he thought it had been fixed and should be OK in the public release version of 4.2.2. Have just dug out his e-mail - he referred to:
Quote Changes vanish Unquote
and said that it should have been fixed by svn 5895 - if we're talking about the same problem it didn't happen. I can't contact him to help me sort this out right now - hence this post. Any ideas?
Thanks in advance
Ron
Ron
I'm happy to test this on your site for you. End me two logins, one as edit, the other as admin.
One further question - what theme are you using for this test?
Oops, so for bad typing. Of course I meant "Send me two logins…. " :-(
OK, Ron gave me the logins, but meanwhile I looked further into his comment from Brian: "he referred to: Quote Changes vanish Unquote and said that it should have been fixed by svn 5895"
This has given me the answer, and Ron has just tested it and found I am correct.
As I result, I (and maybe others too) are somewhat embarrassed that we didn't recognise the problem before.
The reason I, for one, couldn't reproduce the error is that I assumed (always dangerous) that my svn copy of 4.2.2 (actually now 4.2.3 svn 6110) would be the same in this area as the release of 4.2.2. It isn't! This problem was fixed very recently (svn 6031) by melizza. So the fix isn't generally available yet.
It was partially fixed at 5895, before the release of 4.2.2, but needed a second go.
I will now post a revised file in the Patches section here that has this correction, and will work OK in 4.2.2 (it has none of the more recent changes, in case they are not compatible).
Awesome, so I'm not crazy and it wasn't only me!!
I'm assuming kiwi_pgv that I just copy and paste that file you posted?
Thank you to all who assisted, Cheers,
Buzz
I would say "replace" rather than copy and paste, but I guess thats what you meant :-)
DO TAKE AND KEEP A COPY OF THE ORIGINAL BEFORE YOU OVER-WRITE IT - JUST IN CASE.
Great detective work by kiwi_pgv - very many thanks for such a swift and effective response. All now working as it should.
Just one thing - I foolishly included an e-mail address in an earlier post on this thread - will someone with the the right to do so please remove it so that I don't end up with spam problems. Many thanks.