Menu

Visible to other users when online

Help
potain
2009-10-11
2013-05-30
  • potain

    potain - 2009-10-11

    Hi

    I have this field "unticked "  in User Admininistration for my guest users but their details still come up in the Send a message drop down list MyGedView Portal.

    They don't have IDs so can't use the privacy file to create a rule.

    Can you please tell me how to hide their details in the combo box.

    Thank you

     
  • potain

    potain - 2009-10-11

    Meant to say Show Only tro Admin Users - and hide from all other users.

    Jean

     
  • Anonymous

    Anonymous - 2009-10-12

    That is a bug, but I'll let ypu report it. Probably been there for a very long time, as far as I can tell, which I guess says its a feature few use. The fix is easy though

    In blocks/user_messages add this to line 141:

        && get_user_setting($user_id, 'visibleonline')=='Y'

    However, this might be too simplistic, as it will also remove such users from the list even for admin. It probably needs a bit more of a re-write to allow admin to see them but no-one else.

     
  • Anonymous

    Anonymous - 2009-10-12

    After a bit more playing I have a solution that "works", I think. I'll add it to the Patches section here. If someone could test it, then one of the developers can add it to the next release.

     
  • potain

    potain - 2009-10-12

    Hello kiwi

    Tested the change on all the guest logins and only those with Visible to other users when online ticked appeared on the Send message dropdown. (the guest logins were not)

    Logged in as admin and all users are listed.

    Excellent work and if I may can thank you ever so much for your prompt attention to my query. Much appreciated.

    Jean

     
  • potain

    potain - 2009-10-12

    FYI - probably of no import but still -

    Forgot to mention I changed user_messages.php to prefix12oct09user_messages.php before copying the new file to the server and got the following message which disappeared after I deleted it:

    Fatal error: Cannot redeclare print_user_messages() (previously declared in /home/……../………../………/blocks/prefix12oct09user_messages.php:45) in /……/…./…../…../blocks/user_messages.php on line 173

    So I guess just overwrite the old file.

     
  • Anonymous

    Anonymous - 2009-10-12

    Correct conclusion - you can't have PHP trying to run duplicate (or in this case, near-duplicate) files on the server.

     
  • Greg Roach

    Greg Roach - 2009-10-12

    The "show to other users when online" option is used in the logged_in_users block.  It allows other users to see who else is currently logged in.

    You probably want something like

    get_user_setting($user_id, 'contact_method')!='none'

     
  • Greg Roach

    Greg Roach - 2009-10-12

    A similar issue exists in the user list.

    Fixed in SVN (to check the contactmethod parameter, not the visible_online one)

     
  • Anonymous

    Anonymous - 2009-10-12

    Greg

    I don't understand your comment:

    *> You probably want something like
    getusersetting($userid, 'contactmethod')!='none'*

    The question was about the "visibleonline" option, not the contact_method

     
  • Greg Roach

    Greg Roach - 2009-10-12

    The question was about suppressing people appearing in the list of mail recipients.  It makes much more sense to do this by suppressing people with no contact-method specified.  In fact, we need to suppress these anyway.  If someone has no contact method, we can't mail them!

    The visible on line option is for showing the "logged in users" block.

     
  • Stephen Arnold

    Stephen Arnold - 2009-10-12

    Greg 
    Am I to assume that doing so would NOT disable the internal messaging to a user who had no email?   Frankly, I don't know why Jean doesn't set up a dummy/null email account for his guest concept, as certainly his situation is most unique (and still a bit confusing, IOHO). 
    Stephen

     
  • Greg Roach

    Greg Roach - 2009-10-12

    A user with no email address would set this option to "internal messaging".

    Jean has set up a number of "guest" accounts, which are shared among many people.  It doesn't make sense to send an email to a shared account - who would read it?  Therefore it makes sense to set the contact option for these guest accounts to "none".

     
  • Stephen Arnold

    Stephen Arnold - 2009-10-12

    Aaaahhh 
    Now I understand the NONE. Thanks….Stephen

     
  • potain

    potain - 2009-10-13

    Just logged in - my muter was misbehaving all day yesterday.

    Greg

    In Preferred Contact Method there is a No Contact Method in the drop down - are you adding another option "None" to this?

    As you say presently I have set it to "internal messaging with emails" with my admin email as the email address as I thought that they were required fields.

    So the new option will suppress sending internal messages and emails to the guest users ( like when choosing - Broadcast to all users from Send Message). So I can remove the email address field for my guest users. Great.

    Are you able to also commit kiwi's changes to SVN as unless I am mistaken the change that you've made won't stop the guest users appearing in the Send Message drop down list.

    Talking of SVNs and Stephen's warnings I am reluctant to play around with it - are you planning a patched version soon that we can download with all the current changes?

    Thanks.

    Jean

     
  • Stephen Arnold

    Stephen Arnold - 2009-10-13

    Jean 
    SVN 5333 was v4.2.1 - about 6 months ago 
    SVN 6020 was v4.2.2 - about 2 months ago 
    SVN 6233 is current code status (4.2.3) 

    It would be very soon to release a new version, especially given what we are working toward in the branch versions. Please become more familiar with PGV and its nuances and available options before pushing for newer code. V4.2.2 was, as usual, pretty stable.  If you wish to BLEED, then switch to SVN code and always be current, but remember that there is little support and SVN is not designed for use as a production server as it is truly beta code - sometimes almost alpha coding. 
    -Stephen

     
  • potain

    potain - 2009-10-13

    Thanks Stephen

    I'll wait for for the new version as I can't trust myself to use SVN properly.

    Cheers

    Jean

     

Log in to post a comment.