This change appears to apply to the script edit_changes.php
Exactly WHAT problem are you encountering when you're trying to view differences while approving changes?
Chrome and Firefox work just fine for me. The only problem I see is that the Approve Changes panel obscures part of the record being displayed when you click on the View Diff button.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Yes, when I click on Google Chrome to see the difference, nothing happens. I found through Google search that I need to change the code to what I provided in the article.When I looked at the change difference, I found that the record before the change was a red square, and the record was a blue border after the change.
I hope you can also fix the relationship privacy settings in gedcom privacy。If relational privacy is enabled, the relationship privacy restriction is turned off in user management, it does not work.
Last edit: xiaofo 2018-11-10
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
The behaviour you describe (red and blue box) is correct. That's what is supposed to happen.
My copy of Chrome works perfectly without the modification you recommend. Likewise for Firefox, Safari, Internet Explorer, and Opera.
I'm not going to implement your code change, since I am not able to reproduce your problem.
However, I'll look into changing the code so that JavaScript is not used to call up the display of the changed record. I don't see that the use of JavaScript is necessary here. A simple clickable link should be sufficient.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I have noticed that when reviewing changes, PhpGedView does not display the changed GEDCOM record. Instead, it displays the original (unchanged) GEDCOM record.
This will be fixed soon, by replacing gedrecord.php
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Fix chrome browser can't view difference record bug when approving gedcom file modification:
55 line，
window.opener.location = diffurl;change into：
window.opener.document.location.href = diffurl;This change appears to apply to the script edit_changes.php
Exactly WHAT problem are you encountering when you're trying to view differences while approving changes?
Chrome and Firefox work just fine for me. The only problem I see is that the Approve Changes panel obscures part of the record being displayed when you click on the View Diff button.
Yes, when I click on Google Chrome to see the difference, nothing happens. I found through Google search that I need to change the code to what I provided in the article.When I looked at the change difference, I found that the record before the change was a red square, and the record was a blue border after the change.
I hope you can also fix the relationship privacy settings in gedcom privacy。If relational privacy is enabled, the relationship privacy restriction is turned off in user management, it does not work.
Last edit: xiaofo 2018-11-10
The behaviour you describe (red and blue box) is correct. That's what is supposed to happen.
My copy of Chrome works perfectly without the modification you recommend. Likewise for Firefox, Safari, Internet Explorer, and Opera.
I'm not going to implement your code change, since I am not able to reproduce your problem.
However, I'll look into changing the code so that JavaScript is not used to call up the display of the changed record. I don't see that the use of JavaScript is necessary here. A simple clickable link should be sufficient.
https://stackoverflow.com/questions/7720061/window-opener-location-href-works-in-ie-but-not-chrome-or-safari
I found the way to change it from here, I think you should check it out, it does have problems in chrome.
I have noticed that when reviewing changes, PhpGedView does not display the changed GEDCOM record. Instead, it displays the original (unchanged) GEDCOM record.
This will be fixed soon, by replacing gedrecord.php