#2948 Adding new thumbnails under 4.3.1 now requires double admin acceptance

[Douglas Terry]

I was always adding new pictures to act as the thumbnail photos to each of my entries. I do this by going into each entry, selecting the media tab and selecting "Add a new media item". From the resulting dialog I choose the thumbnail to upload and choose the appropriate file, then change the "Always use main image?" to Yes before clicking the Save button.

When I was running 4.3.0 the resulting behavior was the picture was uploaded, a media number assigned to it, the current user entry I was on had that media number assigned to it, and all these changes were then subject to administrator accepting changes.

Now that I am running 4.3.1 SVN 7304, the following happens after I clicked the save button:
* the picture was uploaded (as before)
* The dialog box comes up with the message in RED "The Media item M143 does not exist" immediately followed by "Update successful".
* The photo (in this example M143) is NOT linked to the user entry (probably because it thinks it doesn't exist until it is committed by the administrator). However if you go to the Media Options-->Multimedia View, then the M143 is visible.
* So now if the administrator accepts the changes the logs now indicate that photo M143 has become appended to the database, but the user entry does not have any reference to M143.
* So now I have to go back to the user entry and "Link to an existing Media item" then again have the administrator accept the changes before it becomes visible in the user entry.

This looks to me as though it is a bug introduced since 4.3.0.

[Gerry Kroll]

You should set your account profile to automatically accept your changes as you make them. Presumably, you know what you're doing and don't need to verify your changes before they end up as a permanent feature of your database.

The auto-accept option should only be set for Editors whose input you can trust. On my site, that's nobody other than me.

I use the Manage Media page to upload new media items, enter their particulars, and link to the applicable person/family/source. That's a lot less complicated than adding new media items from the Personal Details (or whatever) page.

[Douglas Terry]

Agree that the auto-accept option makes that behaviour go away. I am however having a couple of key individuals do editing which I review before accepting, so in their cases this 4.3.1 behaviour is quite annoying. Since they are only editing their own few relations I (and they) did not think about using the Manage Media page, but I will look into that as a work around.

[Gerry Kroll]

Media objects are level zero records in the database, as are Person, Family, Source, and Repository records. Each zero level record requires its own Accept procedure.

The program is working the way it should.