#2755 4.2.3 Name entering and editing

v4.2.3
open
None
5
2010-01-18
2010-01-14
No

For historical reasons, my GEDCOM NAME records have the following structure:

1 NAME /Xx/ Yy Zz
2 GIVN Yy Zz
2 SURN Xx

This was to respect "surname first" convention in both PhpGedView version 1.4 and PAF software (this convention is used in Russian official records). Once imported in PhpGedView version 4.2.3, this GEDCOM file was parsed and indexed perfectly and everithing is displayed as it should be: surname first, no matter what are the language settings.
But, when you try to edit the name of such record in 4.2.3, you get the following result:

2 GIVN Yy Zz
2 SURN Xx
2 NSFX Yy Zz

The 1 NAME line disappears, and there is no way to get back to initial structure without editing raw GEDCOM record.
The same is for a new Name, if you put something like

/Xx/ Yy Zz

in the Name field, you get this in your record:

1 NAME //
2 GIVN Yy Zz
2 SURN Xx

I think, you understand that for consistency I would prefer to keep my initial record structure even for new records, but actually it implies editing raw GEDCOM for each new entry.

Thank you and best regards,

Eugene Fedorov,
PhpGedView user from 2003 and fist (and actual!) translator to Russian

Discussion

  • Greg Roach

    Greg Roach - 2010-01-14
    • milestone: --> v4.2.3
     
  • Greg Roach

    Greg Roach - 2010-01-14

    I cannot reproduce this error - it works as expected. Surname-first names are preserved and respected.

    The edit form uses javascript to generate the NAME record. Perhaps you have a javascript error on the page?

    Greg (author of most of the name handling code)

     
  • Greg Roach

    Greg Roach - 2010-01-14

    PS - what browser?

     
  • Eugene Fedorov

    Eugene Fedorov - 2010-01-14

    Hello Greg,

    Thank you for reply. There is no indication of JS error on the page and the browser is IE (6 at work and 8 at home, both give the same). I'll try on Chrome tonight.
    With the following GEDCOM tag

    1 NAME /Xx/ Yy Zz

    The surnames Yy Zz go directly to the Suffix field when you open the Edit Name form. No matter, cyrillic or latin characters used or what languge is active.

    Eugene

     
  • Greg Roach

    Greg Roach - 2010-01-14

    <<1 NAME /Xx/ Yy Zz

    The surnames Yy Zz go directly to the Suffix field when you open the Edit
    Name form.>>

    Your first post says you have 2 GIVN and 2 SURN sub-records. Your latest post says you do not.

    Which?

     
  • Eugene Fedorov

    Eugene Fedorov - 2010-01-15

    Both are true, I omitted sub-records in last post, they are always present, it was just an update of the same problem.
    Chrome does the same. The DB rebuild did'nt help. I can create you an account with edit rights and you will see it yourself.
    You can make a request here:

    http://www.ostrov.ca/drevo/login.php?url=index.php%3Fged%3Dfamily.ged

    Thank you.

     
  • Greg Roach

    Greg Roach - 2010-01-15

    OK - I can see the bug. I'll fix it as soon as I get access to SVN.

     
  • Greg Roach

    Greg Roach - 2010-01-15
    • status: open --> pending-fixed
     
  • Greg Roach

    Greg Roach - 2010-01-15

    This problem has been fixed in SVN.

    Please can you check that the fix works for you.

    If you agree that the problem is fixed, you should change the bug status to "Closed".

    If you think the problem is not fixed, please provide further information.

    Regards,

    The PGV Team

     
  • Greg Roach

    Greg Roach - 2010-01-15
    • assigned_to: nobody --> fisharebest
     
  • Eugene Fedorov

    Eugene Fedorov - 2010-01-15

    Fixed only partially. If you edit existing name, it does'nt copy the given names to suffix anymore.

    If you try to add new person it gives

    1 NAME //
    2 GIVN Yy Zz
    2 SURN Xx

    If you add /Xx/ Yy Zz in the name field.

    If you try to edit this entering once again /Xx/ Yy Zz in the name field, it removes 1 NAME completely, leaving only subrecords.

    What I would like, is to be able to enter correctly this GEDCOM structure:

    1 NAME /Xx/ Yy Zz
    2 GIVN Yy Zz
    2 SURN Xx

    From the PGV interface and to edit it without chaging the structure itself.

    Thank you.

     
  • Greg Roach

    Greg Roach - 2010-01-15

    <<it does'nt copy the given names to suffix anymore.>>

    <<What I would like, is to be able to enter correctly this GEDCOM structure:
    1 NAME /Xx/ Yy Zz
    2 GIVN Yy Zz
    2 SURN Xx
    >>

    How can PGV tell the difference between

    1 NAME /XX/ YY ZZ
    2 GIVN YY
    2 SURN XX
    2 NSFX ZZ

    and

    1 NAME /XX/ YY ZZ
    2 GIVN YY ZZ
    2 SURN XX

     
  • Eugene Fedorov

    Eugene Fedorov - 2010-01-16

    Greg,

    Exactly like to tell the difference between

    1 NAME XX /YY ZZ/
    2 GIVN XX
    2 SURN ZZ
    2 NPFX YY

    and

    1 NAME XX /YY ZZ/
    2 GIVN XX
    2 SURN YY ZZ

    By expicit Suffix or Prefix fields.

    But I understand what bothers you. The Name field in your PGV entering/editing forms actually is not intended to be filled manually, it fills automatically from other fields of these forms only in one direction:

    Givn /Npfx Surn/ Nsfx

    And the form script is not intended to receive reverse order in this field even from the GEDCOM record, this is why any record from my GEDCOM once opened by Edit Name command and immediately saved after become corrupted.

    Thre are two ways to overcome this.

    The first one is on your side. This is to add an optional checkbox Surname first near the Name field in the form in order to tell the script to fill it in this order:

    /Npfx Surn/ Givn Nsfx

    In functions_edit.php code, it will be possible to recognise this order by comparing the NAME record with all subrecords and to set correctly this flag when Edit Name command is issued.

    The second way is on my side. I have to edit my initial GEDCOM to meet these PGV requirements and to put 1 NAME tag in right order for every INDI record. This is feasible, I have just to be careful with the editing script. After this I have to put "yes" for Surname first option in all languages, as most of my GEDCOM individuals are Russians.

    The second option looks to be is easier, at least for you. The only thing that bothers me a little, is that in this case it will be no way to combine names in different order depending on the nationality of the person in the same GEDCOM. But non-Russians represent only 10% of my database, so this is not crytical.

    What do you think?

     
  • Eugene Fedorov

    Eugene Fedorov - 2010-01-18
    • status: pending-fixed --> closed-rejected
     
  • Eugene Fedorov

    Eugene Fedorov - 2010-01-18

    Ok, no problem.
    Please just mention somewhere in the documentation that the GEDCOM structure like

    1 NAME /Surn/ Givn
    2 GIVN Givn
    2 SURN Surn

    is not a valid one for PGV. It is correctly parsed and displayed, but cannot be correctly edited.
    As for me, I'll just change my GEDCOM file in UltraEdit to make it valid for PGV.

    Thank you.

     
  • Greg Roach

    Greg Roach - 2010-01-18

    Don't be so hasty. This is valid gedcom, and PGV needs to support it.

    <<The Name field in your PGV entering/editing forms actually is not intended to be filled manually, it fills automatically from other fields of these forms only in one direction:>>

    PGV has a setting (NAME_REVERSE) in the language-settings page. We use it in almost all of PGV's processing.

    I have a pretty good idea what needs to change - I am just very busy at the moment. Leave the bug report open, and I'll fix it as soon as I get time.

     
  • Greg Roach

    Greg Roach - 2010-01-18
    • status: closed-rejected --> open
     
  • Greg Roach

    Greg Roach - 2010-01-18

    PS - it helps if you use *real* names.

    For example

    1 NAME /Smith/ John jr
    1 NAME /Smith/ John Peter

    In the first, we have SURN GIVN NSFX. In the second, we have SURN GIVN GIVN.

    When you say XX YY ZZ, I don't know what you mean.

     
  • Greg Roach

    Greg Roach - 2010-01-18

    PS - it helps if you use *real* names.

    For example

    1 NAME /Smith/ John jr
    1 NAME /Smith/ John Peter

    In the first, we have SURN GIVN NSFX. In the second, we have SURN GIVN GIVN.

    When you say XX YY ZZ, I don't know what you mean.

     
  • Eugene Fedorov

    Eugene Fedorov - 2010-01-18

    What I would like to point out, Is that only the subrecords define the real structure of the name. Lines like these:

    1 NAME /Smith/ John jr
    1 NAME /Smith/ John Peter

    are for display and printout only, the real information for database and editing is here:

    2 GIVN Peter
    2 SURN Smith
    2 NSFX jr

    or

    2 GIVN John Peter
    2 SURN Smith

    As for NAME_REVERSE setting, I know it, if I change my GEDCOM file for direct name order, I'll use it. Actually my names are already displayed in reverse order, independently of language settings, but existing names cannot be edited correctly and new ones can be entered only in direct order.

    I prefer to keep my GEDCOM structure consistent, this is why if there would be no way to enter and edit records to get GEDCOM like this:

    1 NAME /von Smith/ John Peter jr
    2 GIVN John Peter
    2 SURN Smith
    2 NPFX von
    2 NSFX jr

    my only solution would be to change my initial GEDCOM to dorect name order. Ther is no rush, I only would like to know, should I take this decision or wait.

    Thank you.

     
  • Eugene Fedorov

    Eugene Fedorov - 2010-01-30

    Finally, I fixed my GEDCOM file to meet PGV requirements.

    I would suggest as a patch to change the PGV code to transform any occurance of reverse order like:

    1 NAME /Smith/ John Peter

    into direct one:

    1 NAME John Peter /Smith/

    during GEDCOM import. This would definitely remove this problem.

    Thank you.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks