#2516 Media Viewer using full GEDCOM Media URL

v4.2.0
closed-fixed
Brian Holland
None
5
2009-06-21
2009-02-05
Court
No

Hello,

I'm using the latest phpgedview 4.2.0 - and newly updated to 4.2.1 with svn. (I saw the problem after the upgrade to 4.2.0 and it continues after an svn upgrade.)

I'm noticing image problems with the new release for images that are viewed through the Media tab section on each individual. The file url that is used is not truncated to the correct path on the server. It seems to be using the full, original path from the GEDCOM file, which causes an error and doesn't display the image.

All images elsewhere do work just fine. This is just for images shown in the Media tab.

You can view the error live here: http://heritage.creightonfamily.org/

Discussion

  • Court
    Court
    2009-02-05

    One more thing... I should note that I'm not using the Lightbox image viewer. Just the plain media viewer.

     
  • Gerry Kroll
    Gerry Kroll
    2009-02-05

    What's your GEDCOM configuration for "Multi-Media directory levels to keep"? You find this in the Multi-Media group, "General" section.

     
  • Court
    Court
    2009-02-05

    It's set to "1", since I have one level of subdirectories below "/media" that I organize my media and pictures into.

     
  • Brian Holland
    Brian Holland
    2009-02-08

    Gerry, (and dezignguy)
    I wonder if this may fix it.
    On line 1564 of includes/functions/functions_print_facts.php change the parameter
    $rowm['m_file'] to $mainMedia
    i.e.

    // Get info on how to handle this media file
    //$mediaInfo = mediaFileInfo($rowm['m_file'], $thumbnail, $rowm['m_media'], $name, $notes);
    $mediaInfo = mediaFileInfo($mainMedia, $thumbnail, $rowm['m_media'], $name, $notes);

    Brian

     
  • Brian Holland
    Brian Holland
    2009-02-11

    Hey guys,

    Any comments as to my fix I proposed 3 days ago?
    Or is this no longer a bug.
    Please, at least, dezignguy you should reply, as you enacted this bug report.

    Brian

     
  • Court
    Court
    2009-02-11

    Sorry, for some reason, commenting on this bug was closed for me from about Friday on. And I wasn't motivated enough to test the fix AND figure out how to communicate my results back here. Commenting seems to be working now though.

    Anyways, I've tested your fix, and as near as I can tell it works... I don't see my original issue anymore. I'll leave the fix up and keep an eye on my logs for errors. Thanks for taking a look at my issue!

    These are the error messages that were filling up my log previously... but after your fix was applied, so far I haven't seen any errors. Will need another day or two to make sure nothing pops up though.

    ERROR 2: include‎()‎ ‎[function.include]‎: Failed opening './modules/lightbox/functions/lb_call_js.php' for inclusion ‎(include_path='.:/home/usern/public_html/heritage/includes:/home/usern/public_html/heritage:.:/usr/lib/php:/usr/local/lib/php')‎; 0 Error occurred on line 48 of file source.php in function include1 called from line 48 of file source.php

    ERROR 2: include‎(./modules/lightbox/functions/lb_call_js.php)‎ ‎[function.include]‎: failed to open stream: Permission denied; 0 Error occurred on line 48 of file source.php in function include1 called from line 48 of file source.php

     
  • Brian Holland
    Brian Holland
    2009-02-11

    Great,

    1) I thought that might fix the original issue.
    2) BTW I also saw the error reported by source.php, and I will fix this too.

    Now that I know the original error is corrected, I will post the 2 above fixes to SVN

    Gerry I hope you concur

    Brian

     
  • Brian Holland
    Brian Holland
    2009-02-11

    Hello,

    The problem is fixed in SVN. Please check if the problem has been
    solved and let us know.

    Regards,

    The PGV Team

     
  • Brian Holland
    Brian Holland
    2009-02-11

    • assigned_to: nobody --> windmillway
    • status: open --> pending-fixed
     
  • Brian Holland
    Brian Holland
    2009-02-11

    Fixed in SVN 5019

     
  • Brian Holland
    Brian Holland
    2009-02-11

    The fix works as I see on your site dezignguy.

    However I see also that for certain multimedia items on your media tab page that the "Notes" are duplicated. (As they were before I think)

    Any ideas why this is Gerry?

    Brian

     
  • Court
    Court
    2009-02-11

    • status: pending-fixed --> open-fixed
     
  • Court
    Court
    2009-02-11

    Yes, it does seem like they are being duplicated now. My genealogy program has a one-line Caption field and a multi-line Description field for media files, and PGV has shown these in the past as two Notes attached to media files that appear to be duplicates but actually contain both fields. But now that you mention it, I do notice that it does seem that now I'm seeing just the Description field and a duplicate of it. No Caption field at all.

     
  • Brian Holland
    Brian Holland
    2009-03-12

    • status: open-fixed --> pending-fixed
     
  • This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 100 days (the time period specified by
    the administrator of this Tracker).

     
    • status: pending-fixed --> closed-fixed