Import option on media- help text needs changing
Brought to you by:
canajun2eh,
yalnifj
Menu
▾
▴
#2375 Import option on media- help text needs changing
I refer to the discussion on the help forum https://sourceforge.net/forum/forum.php?thread_id=2609731&forum_id=185166
OBJ Tags are being duplicated on import at the bottom of the gedcom record out of the number hierarchy of the orginal 1 .... TAG that the OBJ Tag was in. ie if you had this structure
0 @I2222@ INDI
1 NAME .........
1 SEX M
1 BIRT
2 DATE 1803
2 PLAC Yorkshire, England
2 SOUR @S120@
3 OBJ @M100@
1 CHAN
2 DATE 25 NOV 2008
3 TIME 16:35:29
2 _PGVU wmeads001
After import you get
@I2222@ INDI
1 NAME .........
1 SEX M
1 BIRT
2 DATE 1803
2 PLAC Yorkshire, England
2 SOUR @S120@
3 OBJ @M100@
1 CHAN
2 DATE 25 NOV 2008
3 TIME 16:35:29
2 _PGVU wmeads001
3 OBJ @M100@
This means on the INDV display the media item displays as part of the CHAN record
I have used the duplicate tag plug in to identify most of these as there have been multi duplication where the orginal duplication has been repeated so you end up with at least 2 of the duplicated tags at the bottom. You need to alter them manually as you will not remove the last duplicated level 2 or level 3 tag. You can not also just remove the obj tags at the end as you may have a correct obj tag as the last record.
I think this bug was present in 4.1.6
I also think this is an important bug and should be fixed as soon as possible
I now understand this is not a bug but the designed functionality.
The Yes option keeps the mysql media tables and when you import the gedcom the entries in the media tables is duplicated
If you have media links in your gedcom that you want to retain you need to use the NO option as this will like the other tables delete the mysql data and replace it on import.
I have changed the title to reflect that this bug report is now about changing the help text on this option.
The help text should state
The yes option will retain any data you have previously in phpgedview for media objects. Any media objects in the gedcom will also be imported. This option is usually used where your gedcom does not have any media links because you have used an off line application, to edit and or create your gedcom, that does not support media links.
If you previously exported your gedcom from phpgedview and this contained media links and you are importing the same gedcome then you would use the No option
The no option deletes the data you have previously in phpgedview for media objects and if your gedcom contains media links then you should use this option. These media links will be imported from the gedcom.
I'll see what can be done.
The Help text has to be a lot more complicated than you propose.
If you import a GEDCOM that has no media information and then add media objects in PGV and then upload a replacement GEDCOM and elect to keep media objects, and then add more or edit existing media objects, the GEDCOM in the "index" directory will contain an incomplete set of media objects. In other words, when you elect to keep media information during an upload or re-import, the incoming GEDCOM is no longer synchronized with the database.
I think this is a bug: When you upload a GEDCOM and keep media information, PGV should add the existing media information to the incoming GEDCOM, but also make sure that the incoming GEDCOM doesn't already contain those same media objects.
In light of this bug, the proper course of action after you upload a replacement GEDCOM and also elect to keep existing media objects is to immediately export the GEDCOM and then upload again, but not keep media information.
It's probably better to change PGV this way: If the existing database contains no media objects, the "Keep media" option should not be shown to the user, and the selection should default to "no". You can't have media links without also having matching media objects, but the reverse isn't true; my database contains media objects complete with titles, etc. that haven't been linked yet. When the "Keep media" option is set to "yes", any media information in the incoming GEDCOM should be ignored.