#2118 Clippings cart

I so rarely look at this feature that I'm not sure if these are bugs or design that I don't understand:

1 - If I select "Include media", no media files are added to the zip folder. All the references to them are there, but no actual media files. (I use media firewall, so could that be blocking them?)

2 - In the code I see entries like "<?php print_help_link("clip_download_help", "qm"); ?>" and "print_help_link("add_by_id_help", "qm");?>" but nowhere on the page (clippings.php) do I see a help icon.

(PGV 4.1.6, svn 3519
logged in as admin.

[Anonymous]

Logged In: YES
user_id=1910459
Originator: YES

Sorry, I should have searched first. The media question has already been raised.
https://sourceforge.net/tracker/index.php?func=detail&aid=1891976&group_id=55456&atid=477079

Not a very satisfactory answer though. Surely there's a better way? Alternatively (as a lst resort)at least the "include media" should be disabled (with an explanation) if media firewall is in use.

Why don't the same privacy rules that apply everywhere else simply also apply in the clippings cart? The other 'bug' talks about issues related to watermarking - but I don't use it, so why can't my users download media files? It should be possible to check for the 'use watermarks' setting?

...and for the finale to this 'rant' if we can't download the media files, we also shouldn't download all the OBJ tags, and their related xrefs.

[John Finlay]

Logged In: YES
user_id=300048
Originator: NO

I just retested the clippings cart today and except for that media firewall issue it is working according to design.

Help icons are showing up for me.

--John

[Anonymous]

Logged In: YES
user_id=1910459
Originator: YES

Thanks John. I'll leave this open though, as it is the media firewall issue that is the most important. I'd love to see a fix for that someday.

[Larry Meaney]

Logged In: YES
user_id=45016
Originator: NO

Yeah, its not ideal. The issue is that you'd have to duplicate much of the media firewall logic for the clippings cart (or refactor it somehow). Didn't seem like a high priority since the reason you put images into the media firewall in the first place is to restrict access to them.

I'd say we don't need two bugs open for the same thing though, so probably one of these should be closed

-larry

[Anonymous]

Logged In: YES
user_id=1910459
Originator: YES

Larry, Ido see the point you make, that it would be hard, and not a priority, to merge firewall code into the clippings cart. I doubt its a very often used feature anyway.

But, I don't think the solution (or perhaps just 'a' solution) needs that. As you correctly state - "the reason you put images into the media firewall in the first place is to restrict access to them". So I come back to my earlier point, that at least the "include media" should be disabled (with an explanation) if media firewall is in use. I'm going to have a go at that, as I think it should just be a matter of wrapping each reference to downloading media items in an if-statement that checks if firewall is in use.

[Anonymous]

As at Nov 2009, item 1 is still relevant, but item 2 is not.