#1859 replace GEDCOM if filename changed crashes

[Wes Groleau]

With site at revision 2416, I downloaded my GEDCOM from (index)/wgroleau.ged

Copied it to (localpath)/full.ged to do some edits

Went to the website and selected Upload Replacement/Browse

Picked full.ged /save and got "Validating (index)/full.ged" followed by dozens of screenfuls of

Performing GEDCOM validation...

ERROR 8: Undefined index: full.ged
0 Error occurred on in function unknown
1 called from line 565 of file uploadgedcom.php

ERROR 2: feof(): supplied argument is not a valid stream resource
0 Error occurred on in function feof
1 called from line 567 of file uploadgedcom.php

Warning: feof(): supplied argument is not a valid stream resource in /home/content/G/T/S/GTSCFL/html/UG/PGV/uploadgedcom.php on line 567

ERROR 2: fread(): supplied argument is not a valid stream resource
0 Error occurred on in function fread
1 called from line 568 of file uploadgedcom.php

Warning: fread(): supplied argument is not a valid stream resource in /home/content/G/T/S/GTSCFL/html/UG/PGV/uploadgedcom.php on line 568

ERROR 2: feof(): supplied argument is not a valid stream resource
0 Error occurred on in function feof
1 called from line 567 of file uploadgedcom.php

Warning: feof(): supplied argument is not a valid stream resource in /home/content/G/T/S/GTSCFL/html/UG/PGV/uploadgedcom.php on line 567

ERROR 2: fread(): supplied argument is not a valid stream resource
0 Error occurred on in function fread

etc.

[Peter Sjöberg]

Logged In: YES
user_id=733818
Originator: NO

Did a quick hack to at least not generate a ton of errors but I think the correct solution is to handle filename change.
This is against stock v4.1.3

--- uploadgedcom.php-orig 2008-02-23 22:11:56.000000000 -0500
+++ uploadgedcom.php 2008-02-23 22:12:47.000000000 -0500
@@ -558,7 +558,8 @@
$l_placecleanup = false;
$l_datecleanup = false;
$l_isansi = false;
- $fp = fopen($GEDCOMS[$GEDFILENAME]["path"], "r");
+ if(!($fp = fopen($GEDCOMS[$GEDFILENAME]["path"], "r")))
+ die ("File failed to open $GEDFILENAME. Note that when replacing a file the uploaded file must have EXACTLY the same name including case");
//-- read the gedcom and test it in 8KB chunks
while (!feof($fp)) {
$fcontents = fread($fp, 1024 * 8);