#1822 SVN 2323: Individual page, Printer-friendly Version

[Im]

Hi,

The "Printer-friendly Version" from the individual page gives this error:

missing ; before statement
tabswitch(0)if (typeof toggleByClassName == "undefined") alert('phpgedview.js\na...

Thanks,
-Im

[Greg Roach]

Logged In: YES
user_id=1466942
Originator: NO

SVN2327

[Im]

Logged In: YES
user_id=1262354
Originator: YES

Hi Greg,

Thanks. That error is gone. But there is a new error message:

document.getElementById("door" + n) has no properties
tabswitch(0)individual.php (line 231)
document.getElementById('door'+n).className='door optionbox';

-Im

[Greg Roach]

Logged In: YES
user_id=1466942
Originator: NO

How do you trigger this error?

[Im]

Logged In: YES
user_id=1262354
Originator: YES

I'm not sure what triggers it. But the 'n' in "function tabswitch(n)" is allways '0'.
I tried with other tabs, but the result is the same. The 'n' is 0. So 'ALL' tab ends up on the "Printer-friendly Version" page.

When I try this:
individual.php?action=ajax&pid=I1&tab=0

I get this:
ERROR 8: Undefined offset: -1
0 Error occurred on line 972 of file individual_ctrl.php in function getTab
1 called from line 256 of file individual_ctrl.php in function init
2 called from line 2007 of file individual_ctrl.php in function require_once
3 called from line 29 of file individual.php

Notice: Undefined offset: -1 in .\includes\controllers\individual_ctrl.php on line 972
No tab found

Whith:
individual.php?action=ajax&pid=I1&tab=1
individual.php?action=ajax&pid=I1&tab=2
individual.php?action=ajax&pid=I1&tab=3
etc. .... it works

-Im

[Greg Roach]

Logged In: YES
user_id=1466942
Originator: NO

document.getElementById("door" + n) has no properties
tabswitch(0)individual.php (line 231)
document.getElementById('door'+n).className='door optionbox';

<<I'm not sure what triggers it.>>

Sorry, let me ask differently. You must do *something* to get the error. Open a page, click on something, etc.

What would I have to do to see this error?

[Im]

Logged In: YES
user_id=1262354
Originator: YES

Thats the thing, I don't do anything....
On the individual page (any page) I just click on the printer friendly version. Thats it...

I'll attach a picture for you to see, what I see.
If you have Firefox, you can also see this in the 'Error Console'

Any idea? What/how should I test this?

-Im
File Added: print.jpg

[Greg Roach]

Logged In: YES
user_id=1466942
Originator: NO

I've had another look at this. It's in the code that saves the current tab to a cookie for the "remember last tab visited" feature.

During print-preview, there is no "current tab", hence the javascript error.

[Im]

Logged In: YES
user_id=1262354
Originator: YES

Hi Greg,

Thanks for the info and your effords!

-Im

[Im]

Hi Greg,

I have just checked the SVN 4594 and this on persist.
In Firefox 'Error Console' I see this:

Error: document.getElementById("door" + n) is null
Source File: http://localhost/phpgedview/individual.php?view=preview&pid=I2
Line: 475

Thanks
-Im

[Łukasz Wileński]

please check this with the latest svn

[Im]

Hi Lukasz,

Sorry, still there with more info from the Error Console:

Warning: Empty string passed to getElementById().

Warning: Use of captureEvents() is deprecated. To upgrade your code, use the DOM 2 addEventListener() method. For more help http://developer.mozilla.org/en/docs/DOM:element.addEventListener
Source File: http://localhost/pgvtest/individual.php?view=preview&pid=I2
Line: 0

Error: document.getElementById("door" + n) is null
Source File: http://localhost/pgvtest/individual.php?view=preview&pid=I2
Line: 235

Something with mozilla (Firefox)

Thanks for your efforts,
-Im