#1754 Changes Report Sorting

[Meliza Amity]

The "to date" field shows the from date and the "from date" the to date data.

Changing the contents to match the names returns nothing.

[Gerry Kroll]

Logged In: YES
user_id=1198414
Originator: NO

Fixed in SVN 2059 for version 4.1.3

Changed input form and report heading so that the earlier date is shown first.

Also changed sort so that sorting by CHAN date will result in the most recent changes being shown first. (descending order of change date/time)

[Meliza Amity]

Logged In: YES
user_id=959928
Originator: YES

Are the pended changes also sorted with the last ones first?
On my test site I see the 2 with the older one first.

[Gerry Kroll]

Logged In: YES
user_id=1198414
Originator: NO

Pending changes are supposed to be sorted in their own list, with the most recent change first.

[Meliza Amity]

Logged In: YES
user_id=959928
Originator: YES

SVN 2101
I attach a sample test report.

The 2 report parts are not sorted correctly by date and time.
So far I have seen wrong date and time sorting in the pending part and wrong time sorting in the approved part.

Meliza
File Added: changes report.jpg

[Gerry Kroll]

Logged In: YES
user_id=1198414
Originator: NO

Meliza:
You're right.

Pending changes were not being sorted at all because the date sort logic in "functions.php" was looking for a GEDCOM record where it should have been looking for an "undo" record when sorting by CHAN date/time. The "undo" record is actually a mis-nomer -- it's a "replacement" record. The Pending changes list comes from the contents of file "index/pgv_changes.php".

Please answer this question:
Does it make any sense at all to sort the Pending changes by anything other than descending date (most recent first)? The other options are Name and Birth Date. If yes, do we sort by the original fact values or by the fact values as they would appear after changes have been accepted?

I suspect that the consensus will be "no".

Do we need an "ascending date" (oldest first) option too? My vote: "no".

Stephen:
Any thoughts?

[Meliza Amity]

Logged In: YES
user_id=959928
Originator: YES

Gerry,
Please pay attention that the approved changes are neither sorted as expected.

I think that occasionally it would be good to sort the report by the name.

I would sort the unapproved changes by the existing old name that is shown on the site.
If I am not mistaken, users should not see the changes till they are approved.
Only the admin and the initiator are supposed to see the pending changes.
I do not know if PGV still works this way.

If everyone sees the pending, not yet approved value, then we could use it here, too.

Meliza

[Gerry Kroll]

Logged In: YES
user_id=1198414
Originator: NO

I'm pretty sure that the approved changes are sorted according to date and time in the CHAN sub-record of the GEDCOM record in question.

If you've made a change and told the system that the CHAN record shouldn't be updated, your change won't show up in the Approved Changes list. If this change is still pending approval, depending on the original change date, it may or may not show up in the Pending Changes list. I haven't looked into the code in that much detail.

As I said, I know why the pending changes aren't sorted properly; the fix just hasn't been committed to SVN yet.

The Change Report is only available to users who have Edit rights. This means that ordinary users can't see anything other than the GEDCOM without the pending changes applied.

I'll check into the sorting of the Pending and Approved lists according to other sort criteria. You're right about occasionally needing to sort the lists into sequences other than change date, and that these sorts should be according to what's currently recorded in the database and not according what the proposed change says. I'm not sure whether sorting by birth date is useful.

[Gerry Kroll]

Logged In: YES
user_id=1198414
Originator: NO

SVN 2110 for version 4.1.3 fixes the missing sort on Change Date for the Pending Changes list. "includes/functions.php" was replaced.

My tests show that the other sort options work as expected.

Please note that the sort on Change Date does not consider Change Time when dates are equal. There's nothing that can be done about this in a timely manner -- there just isn't any program code for this that can be re-used.

[Meliza Amity]

Logged In: YES
user_id=959928
Originator: YES

Sorting by last change should sort also by the time.

I will open this posting till we get this into the code.

Meliza